From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F20C77B7D for ; Sat, 13 May 2023 18:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230501AbjEMSnr (ORCPT ); Sat, 13 May 2023 14:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjEMSnq (ORCPT ); Sat, 13 May 2023 14:43:46 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9F9B2680 for ; Sat, 13 May 2023 11:43:44 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-50bc394919cso16588876a12.2 for ; Sat, 13 May 2023 11:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684003423; x=1686595423; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SIKmkC8PkYUMuXvhvScc2QiWAE9GV9r1KXIulcRXAH8=; b=UzK297MAlDrAcB5KvseNrkyjkh7qqtX5yb3NexbK00a66SN4yP3gJMSx9gHbpDhObZ IELyhkZtWoyNtFNx3l5KzNkig/efTqW2t23NfsSfaRv3lSFO7wc4m6tWTWhdnZP3PmhB IrRaeYMNg0TaK3aR4cqt2nippuAi5ctxrjXWUoZVjGJ7B9DpCqCdzv1UC2JCtthPciYB GnmIqXPaNfMI4kc6jeyD4ykGL2rWCdiYFQiuTxokpoOopxh0I4OXjH2xfuHXM60DlFw6 sZdZZPFYipAcP1pNKjtCLhOzUTkyLyUhXXt8BGApxN1TxEzA8NU4L+ebs7RGaljhRiwb p1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684003423; x=1686595423; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SIKmkC8PkYUMuXvhvScc2QiWAE9GV9r1KXIulcRXAH8=; b=G5AfBcembuY3EG/ISSPXZYG72EXdFTfBvBOgrmBNBKQxmpGlYsvNtADIZCc3VOqu27 8aJjdjCSO0h6yo/BOLohAAg+LTGHqhxVuhB6RbZWUj+j1J/Q4f+oWxsyBLipuDHEa5Q2 WYEKMNcHHfG++w8dY7LQ5fHYIIULP/O45NQZVty6kjeGYR5rROvmHWDsCXgixL7IUGA2 CVu9nV7b2X9n9Ka735EYZB7+hZcRVZsjb+gtuDLbO0Sw7SFH1Uoajpn1R1byw/ElyIAh kgu9Ud3M5KsWsvd1JMfiNH4+k/Vqwc2vA5sFyaGO4RGoFnGzksQkiBE+lFksuOAApsfu UQzw== X-Gm-Message-State: AC+VfDxXe4STbBysq/i2aKldO2WkP/HJzyBv2f0VQvsXgaNn4nvv5UaT K6zzLrnGUDPDFVVoppc+i94DFg== X-Google-Smtp-Source: ACHHUZ5jqpHFV2p7aot+5EbJgXSqMf9auQVtjC5iHSUu1sc0uk/8irH6QB1cdep0CArMgZMauALo7A== X-Received: by 2002:a05:6402:51:b0:50d:bd2e:6dfa with SMTP id f17-20020a056402005100b0050dbd2e6dfamr10633472edu.17.1684003423301; Sat, 13 May 2023 11:43:43 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ba68:e5c9:694e:c6e4? ([2a02:810d:15c0:828:ba68:e5c9:694e:c6e4]) by smtp.gmail.com with ESMTPSA id m26-20020a50ef1a000000b0050690bc07a3sm5294907eds.18.2023.05.13.11.43.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 May 2023 11:43:42 -0700 (PDT) Message-ID: Date: Sat, 13 May 2023 20:43:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/2] dt-bindings: cdns,usb3: Add clock and reset Content-Language: en-US To: Roger Quadros , Minda Chen , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20230510132816.108820-1-minda.chen@starfivetech.com> <20230510132816.108820-2-minda.chen@starfivetech.com> <9cf5965a-8290-dfff-9f92-07ed2df66650@linaro.org> <05057f6d-cb38-8e4a-5d30-82863e0cda44@kernel.org> <028fb8ac-d6cc-6fee-f50b-b965e69e7d0c@linaro.org> <40592737-4330-101b-5425-091572e61c6f@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <40592737-4330-101b-5425-091572e61c6f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/05/2023 13:08, Roger Quadros wrote: > > > On 11/05/2023 17:49, Krzysztof Kozlowski wrote: >> On 11/05/2023 14:16, Roger Quadros wrote: >>> >>> >>> On 11/05/2023 12:26, Krzysztof Kozlowski wrote: >>>> On 10/05/2023 15:28, Minda Chen wrote: >>>>> To support generic clock and reset init in Cadence USBSS >>>>> controller, add clock and reset dts configuration. >>>>> >>>>> Signed-off-by: Minda Chen >>>>> --- >>>>> .../devicetree/bindings/usb/cdns,usb3.yaml | 14 ++++++++++++++ >>>>> 1 file changed, 14 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>>> index cae46c4982ad..623c6b34dee3 100644 >>>>> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>>> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>>> @@ -42,6 +42,18 @@ properties: >>>>> - const: otg >>>>> - const: wakeup >>>>> >>>>> + clocks: >>>>> + minItems: 1 >>>>> + maxItems: 8 >>>>> + description: >>>>> + USB controller clocks. >>>> >>>> You need to list the items. And why is it variable? Your clock choice in >>>> the example is poor, I doubt it is real. >>>> >>>>> + >>>>> + resets: >>>>> + minItems: 1 >>>>> + maxItems: 8 >>>>> + description: >>>>> + USB controller generic resets. >>>> >>>> Here as well. >>>> >>>> You had one clock last time, thus the review was - drop the names. Now >>>> you changed it to 8 clocks... I don't understand. >>>> >>> >>> Different platforms may have different number of clocks/resets or none. >>> So I don't think minItems/maxItems should be specified. >> >> Yeah, but we want the clocks to be specific per platform. Not anything >> anywhere. >> > > Agreed. So we don't specify min/maxItems at top level but use conditional > constraints per platform? > Which means we will need to add platform specific compatibles as well. Yes, exactly. This can be done here in this binding or through some re-usable common part and then multiple bindings using it and customizing. Best regards, Krzysztof