Re: [PATCH v1 17/25] arm64: dts: colibri-imx8x: eval: Add spi-to-can

[Philippe Schenker <dev@pschenker.ch>]

On Wed, 2023-03-08 at 15:34 +0100, Krzysztof Kozlowski wrote:
> On 08/03/2023 14:43, Philippe Schenker wrote:
> > > > +       mcp2515: can@0 {
> > > > +               compatible = "microchip,mcp2515";
> > > > +               reg = <0>;
> > > > +               interrupt-parent = <&lsio_gpio3>;
> > > > +               interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> > > > +               pinctrl-0 = <&pinctrl_can_int>;
> > > > +               pinctrl-names = "default";
> > > > +               clocks = <&clk16m>;
> > > 
> > > You just sorted all nodes in previous patches and add something
> > > unsorted? What is then the style of order? Random name?
> > 
> > My logic behind this one is
> > 
> > 1. compatible property
> > 2. reg property
> > 3. standard properties 
> >    - first interrupt
> >    - then pinctrl
> > 4. specific properties
> >    - again alphabetically: clocks, spi-max-frequency
> 
> clocks and spi-max-frequency are standard properties.
> 
> BTW, what is a specific property?

I mean specific to this driver. With standard properties I mean those
you can add everywhere like pinctrl, interrupts etc. But then yes I
agree you can pretty quickly start to argue...

Would in this particular case something like


	mcp2515: can@0 {
		compatible = "microchip,mcp2515";
		reg = <0>;
		pinctrl-0 = <&pinctrl_can_int>;
		pinctrl-names = "default";
		clocks = <&clk16m>;
		interrupt-parent = <&lsio_gpio3>;
		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
		spi-max-frequency = <10000000>;
	};

be better?


> 
> Best regards,
> Krzysztof
>