From: Milo Kim <woogyom.kim@gmail.com>
To: Tony Lindgren <tony@atomide.com>, Lee Jones <lee.jones@linaro.org>
Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts
Date: Mon, 21 Nov 2016 22:05:21 +0900 [thread overview]
Message-ID: <c04af1ac-b692-f3df-47b0-72c5263374bf@gmail.com> (raw)
In-Reply-To: <20161118151051.GV4082@atomide.com>
On 11/19/2016 12:10 AM, Tony Lindgren wrote:
>>> +#define TPS65217_IRQ_USB 0
>>> > > +#define TPS65217_IRQ_AC 1
>>> > > +#define TPS65217_IRQ_PB 2
>> >
>> > What are "AC" and "PB". Seeing as these are meant to be "human
>> > readable", let's make them more human friendly.
> Good idea. Milo, please do an incremental single follow-up patch as
> I already have applied this and the dts changes using it.
Thanks for catching this. Let me send a patch soon.
Best regards,
Milo
next prev parent reply other threads:[~2016-11-21 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 12:36 [PATCH v2 0/8] Support TPS65217 PMIC interrupt in DT Milo Kim
2016-10-28 12:36 ` [PATCH v2 1/8] ARM: dts: tps65217: Specify the interrupt controller Milo Kim
2016-10-28 12:36 ` [PATCH v2 2/8] ARM: dts: tps65217: Add the charger device Milo Kim
2016-10-28 12:36 ` [PATCH v2 3/8] ARM: dts: tps65217: Add the power button device Milo Kim
2016-10-28 12:36 ` [PATCH v2 4/8] ARM: dts: am335x: Support the PMIC interrupt Milo Kim
2016-10-28 12:36 ` [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts Milo Kim
[not found] ` <20161028123702.21849-6-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-18 14:53 ` Lee Jones
2016-11-18 15:10 ` Tony Lindgren
2016-11-21 13:05 ` Milo Kim [this message]
2016-10-28 12:37 ` [PATCH v2 6/8] ARM: dts: am335x: Add the charger interrupt Milo Kim
2016-10-28 12:37 ` [PATCH v2 7/8] ARM: dts: am335x: Add the power button interrupt Milo Kim
2016-10-28 12:37 ` [PATCH v2 8/8] mfd: tps65217: Fix mismatched interrupt number Milo Kim
[not found] ` <20161028123702.21849-1-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-09 21:38 ` [PATCH v2 0/8] Support TPS65217 PMIC interrupt in DT Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c04af1ac-b692-f3df-47b0-72c5263374bf@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).