* [PATCH v2 0/7] Add SM8150 and SM8250 interconnect drivers
@ 2020-07-13 15:41 Jonathan Marek
2020-07-13 15:41 ` [PATCH v2 1/7] dt-bindings: interconnect: single yaml file for RPMh " Jonathan Marek
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Jonathan Marek @ 2020-07-13 15:41 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Georgi Djakov, open list, open list:INTERCONNECT API,
Odelu Kukatla, Rob Herring
Most of this is generated from downstream dts using a script.
There are a couple things I'm still not sure about:
* When to set keepalive in DEFINE_QBCM macro (set to all false)
* Size for the reg fields. For the size I just used 0x1000.
v2: single yaml file for RPMh interconnect bindings, drop display RSC
Jonathan Marek (7):
dt-bindings: interconnect: single yaml file for RPMh interconnect
drivers
dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings
dt-bindings: interconnect: Add Qualcomm SM8250 DT bindings
interconnect: qcom: Add SM8150 interconnect provider driver
interconnect: qcom: Add SM8250 interconnect provider driver
arm64: dts: qcom: sm8150: add interconnect nodes
arm64: dts: qcom: sm8250: add interconnect nodes
.../{qcom,sc7180.yaml => qcom,rpmh.yaml} | 55 +-
.../bindings/interconnect/qcom,sdm845.yaml | 74 --
arch/arm64/boot/dts/qcom/sm8150.dtsi | 82 +++
arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 +++
drivers/interconnect/qcom/Kconfig | 20 +
drivers/interconnect/qcom/Makefile | 4 +
drivers/interconnect/qcom/sm8150.c | 639 +++++++++++++++++
drivers/interconnect/qcom/sm8150.h | 153 ++++
drivers/interconnect/qcom/sm8250.c | 655 ++++++++++++++++++
drivers/interconnect/qcom/sm8250.h | 163 +++++
.../dt-bindings/interconnect/qcom,sm8150.h | 163 +++++
.../dt-bindings/interconnect/qcom,sm8250.h | 173 +++++
12 files changed, 2186 insertions(+), 77 deletions(-)
rename Documentation/devicetree/bindings/interconnect/{qcom,sc7180.yaml => qcom,rpmh.yaml} (56%)
delete mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml
create mode 100644 drivers/interconnect/qcom/sm8150.c
create mode 100644 drivers/interconnect/qcom/sm8150.h
create mode 100644 drivers/interconnect/qcom/sm8250.c
create mode 100644 drivers/interconnect/qcom/sm8250.h
create mode 100644 include/dt-bindings/interconnect/qcom,sm8150.h
create mode 100644 include/dt-bindings/interconnect/qcom,sm8250.h
--
2.26.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH v2 1/7] dt-bindings: interconnect: single yaml file for RPMh interconnect drivers 2020-07-13 15:41 [PATCH v2 0/7] Add SM8150 and SM8250 interconnect drivers Jonathan Marek @ 2020-07-13 15:41 ` Jonathan Marek 2020-07-14 17:23 ` Rob Herring 2020-07-13 15:41 ` [PATCH v2 2/7] dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings Jonathan Marek ` (3 subsequent siblings) 4 siblings, 1 reply; 14+ messages in thread From: Jonathan Marek @ 2020-07-13 15:41 UTC (permalink / raw) To: linux-arm-msm Cc: Andy Gross, Bjorn Andersson, Georgi Djakov, Rob Herring, Odelu Kukatla, open list:INTERCONNECT API, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list These two bindings are almost identical, so combine them into one. This will make it easier to add the sm8150 and sm8250 interconnect bindings. Signed-off-by: Jonathan Marek <jonathan@marek.ca> --- .../{qcom,sc7180.yaml => qcom,rpmh.yaml} | 33 ++++++++- .../bindings/interconnect/qcom,sdm845.yaml | 74 ------------------- 2 files changed, 30 insertions(+), 77 deletions(-) rename Documentation/devicetree/bindings/interconnect/{qcom,sc7180.yaml => qcom,rpmh.yaml} (67%) delete mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc7180.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml similarity index 67% rename from Documentation/devicetree/bindings/interconnect/qcom,sc7180.yaml rename to Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml index d01bac80d416..9878139a73b8 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,sc7180.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml @@ -1,16 +1,17 @@ # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/interconnect/qcom,sc7180.yaml# +$id: http://devicetree.org/schemas/interconnect/qcom,rpmh.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Qualcomm SC7180 Network-On-Chip Interconnect +title: Qualcomm RPMh Network-On-Chip Interconnect maintainers: + - Georgi Djakov <georgi.djakov@linaro.org> - Odelu Kukatla <okukatla@codeaurora.org> description: | - SC7180 interconnect providers support system bandwidth requirements through + RPMh interconnect providers support system bandwidth requirements through RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is able to communicate with the BCM through the Resource State Coordinator (RSC) associated with each execution environment. Provider nodes must point to at @@ -36,6 +37,14 @@ properties: - qcom,sc7180-npu-noc - qcom,sc7180-qup-virt - qcom,sc7180-system-noc + - qcom,sdm845-aggre1-noc + - qcom,sdm845-aggre2-noc + - qcom,sdm845-config-noc + - qcom,sdm845-dc-noc + - qcom,sdm845-gladiator-noc + - qcom,sdm845-mem-noc + - qcom,sdm845-mmss-noc + - qcom,sdm845-system-noc '#interconnect-cells': const: 1 @@ -60,6 +69,24 @@ required: additionalProperties: false examples: + - | + #include <dt-bindings/interconnect/qcom,sdm845.h> + + mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem-noc"; + reg = <0x01380000 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + mmss_noc: interconnect@1740000 { + compatible = "qcom,sdm845-mmss-noc"; + reg = <0x01740000 0x1c1000>; + #interconnect-cells = <1>; + qcom,bcm-voter-names = "apps", "disp"; + qcom,bcm-voters = <&apps_bcm_voter>, <&disp_bcm_voter>; + }; + - | #include <dt-bindings/interconnect/qcom,sc7180.h> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml deleted file mode 100644 index 74536747b51d..000000000000 --- a/Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml +++ /dev/null @@ -1,74 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/interconnect/qcom,sdm845.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: Qualcomm SDM845 Network-On-Chip Interconnect - -maintainers: - - Georgi Djakov <georgi.djakov@linaro.org> - -description: | - SDM845 interconnect providers support system bandwidth requirements through - RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is - able to communicate with the BCM through the Resource State Coordinator (RSC) - associated with each execution environment. Provider nodes must point to at - least one RPMh device child node pertaining to their RSC and each provider - can map to multiple RPMh resources. - -properties: - reg: - maxItems: 1 - - compatible: - enum: - - qcom,sdm845-aggre1-noc - - qcom,sdm845-aggre2-noc - - qcom,sdm845-config-noc - - qcom,sdm845-dc-noc - - qcom,sdm845-gladiator-noc - - qcom,sdm845-mem-noc - - qcom,sdm845-mmss-noc - - qcom,sdm845-system-noc - - '#interconnect-cells': - const: 1 - - qcom,bcm-voters: - $ref: /schemas/types.yaml#/definitions/phandle-array - description: | - List of phandles to qcom,bcm-voter nodes that are required by - this interconnect to send RPMh commands. - - qcom,bcm-voter-names: - $ref: /schemas/types.yaml#/definitions/string-array - description: | - Names for each of the qcom,bcm-voters specified. - -required: - - compatible - - reg - - '#interconnect-cells' - - qcom,bcm-voters - -additionalProperties: false - -examples: - - | - #include <dt-bindings/interconnect/qcom,sdm845.h> - - mem_noc: interconnect@1380000 { - compatible = "qcom,sdm845-mem-noc"; - reg = <0x01380000 0x27200>; - #interconnect-cells = <1>; - qcom,bcm-voters = <&apps_bcm_voter>; - }; - - mmss_noc: interconnect@1740000 { - compatible = "qcom,sdm845-mmss-noc"; - reg = <0x01740000 0x1c1000>; - #interconnect-cells = <1>; - qcom,bcm-voter-names = "apps", "disp"; - qcom,bcm-voters = <&apps_bcm_voter>, <&disp_bcm_voter>; - }; -- 2.26.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/7] dt-bindings: interconnect: single yaml file for RPMh interconnect drivers 2020-07-13 15:41 ` [PATCH v2 1/7] dt-bindings: interconnect: single yaml file for RPMh " Jonathan Marek @ 2020-07-14 17:23 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2020-07-14 17:23 UTC (permalink / raw) To: Jonathan Marek Cc: Georgi Djakov, linux-pm, Andy Gross, linux-kernel, devicetree, linux-arm-msm, Bjorn Andersson, Rob Herring, Odelu Kukatla On Mon, 13 Jul 2020 11:41:10 -0400, Jonathan Marek wrote: > These two bindings are almost identical, so combine them into one. This > will make it easier to add the sm8150 and sm8250 interconnect bindings. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > .../{qcom,sc7180.yaml => qcom,rpmh.yaml} | 33 ++++++++- > .../bindings/interconnect/qcom,sdm845.yaml | 74 ------------------- > 2 files changed, 30 insertions(+), 77 deletions(-) > rename Documentation/devicetree/bindings/interconnect/{qcom,sc7180.yaml => qcom,rpmh.yaml} (67%) > delete mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml > My bot found errors running 'make dt_binding_check' on your patch: In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:14:0: warning: "MASTER_SDCC_2" redefined #define MASTER_SDCC_2 3 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:14:0: note: this is the location of the previous definition #define MASTER_SDCC_2 2 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:17:0: warning: "SLAVE_A1NOC_SNOC" redefined #define SLAVE_A1NOC_SNOC 6 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:19:0: note: this is the location of the previous definition #define SLAVE_A1NOC_SNOC 7 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:18:0: warning: "SLAVE_SERVICE_A1NOC" redefined #define SLAVE_SERVICE_A1NOC 7 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:20:0: note: this is the location of the previous definition #define SLAVE_SERVICE_A1NOC 8 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:24:0: warning: "MASTER_CRYPTO" redefined #define MASTER_CRYPTO 4 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:26:0: note: this is the location of the previous definition #define MASTER_CRYPTO 3 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:25:0: warning: "MASTER_IPA" redefined #define MASTER_IPA 5 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:27:0: note: this is the location of the previous definition #define MASTER_IPA 4 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:27:0: warning: "SLAVE_A2NOC_SNOC" redefined #define SLAVE_A2NOC_SNOC 7 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:32:0: note: this is the location of the previous definition #define SLAVE_A2NOC_SNOC 9 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:28:0: warning: "SLAVE_SERVICE_A2NOC" redefined #define SLAVE_SERVICE_A2NOC 8 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:34:0: note: this is the location of the previous definition #define SLAVE_SERVICE_A2NOC 11 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:30:0: warning: "MASTER_CAMNOC_HF0_UNCOMP" redefined #define MASTER_CAMNOC_HF0_UNCOMP 0 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:123:0: note: this is the location of the previous definition #define MASTER_CAMNOC_HF0_UNCOMP 13 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:31:0: warning: "MASTER_CAMNOC_HF1_UNCOMP" redefined #define MASTER_CAMNOC_HF1_UNCOMP 1 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:124:0: note: this is the location of the previous definition #define MASTER_CAMNOC_HF1_UNCOMP 14 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:32:0: warning: "MASTER_CAMNOC_SF_UNCOMP" redefined #define MASTER_CAMNOC_SF_UNCOMP 2 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:125:0: note: this is the location of the previous definition #define MASTER_CAMNOC_SF_UNCOMP 15 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:33:0: warning: "SLAVE_CAMNOC_UNCOMP" redefined #define SLAVE_CAMNOC_UNCOMP 3 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:126:0: note: this is the location of the previous definition #define SLAVE_CAMNOC_UNCOMP 16 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:39:0: warning: "MASTER_SNOC_CNOC" redefined #define MASTER_SNOC_CNOC 0 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:38:0: note: this is the location of the previous definition #define MASTER_SNOC_CNOC 2 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:40:0: warning: "MASTER_QDSS_DAP" redefined #define MASTER_QDSS_DAP 1 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:39:0: note: this is the location of the previous definition #define MASTER_QDSS_DAP 3 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:41:0: warning: "SLAVE_A1NOC_CFG" redefined #define SLAVE_A1NOC_CFG 2 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:40:0: note: this is the location of the previous definition #define SLAVE_A1NOC_CFG 4 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:42:0: warning: "SLAVE_A2NOC_CFG" redefined #define SLAVE_A2NOC_CFG 3 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:41:0: note: this is the location of the previous definition #define SLAVE_A2NOC_CFG 5 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:48:0: warning: "SLAVE_CAMERA_CFG" redefined #define SLAVE_CAMERA_CFG 9 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:44:0: note: this is the location of the previous definition #define SLAVE_CAMERA_CFG 8 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:51:0: warning: "SLAVE_CLK_CTL" redefined #define SLAVE_CLK_CTL 12 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:45:0: note: this is the location of the previous definition #define SLAVE_CLK_CTL 9 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:52:0: warning: "SLAVE_RBCPR_CX_CFG" redefined #define SLAVE_RBCPR_CX_CFG 13 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:47:0: note: this is the location of the previous definition #define SLAVE_RBCPR_CX_CFG 11 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:54:0: warning: "SLAVE_CRYPTO_0_CFG" redefined #define SLAVE_CRYPTO_0_CFG 15 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:48:0: note: this is the location of the previous definition #define SLAVE_CRYPTO_0_CFG 12 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:55:0: warning: "SLAVE_DCC_CFG" redefined #define SLAVE_DCC_CFG 16 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:49:0: note: this is the location of the previous definition #define SLAVE_DCC_CFG 13 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:56:0: warning: "SLAVE_CNOC_DDRSS" redefined #define SLAVE_CNOC_DDRSS 17 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:50:0: note: this is the location of the previous definition #define SLAVE_CNOC_DDRSS 14 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:57:0: warning: "SLAVE_DISPLAY_CFG" redefined #define SLAVE_DISPLAY_CFG 18 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:51:0: note: this is the location of the previous definition #define SLAVE_DISPLAY_CFG 15 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:61:0: warning: "SLAVE_GLM" redefined #define SLAVE_GLM 22 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:52:0: note: this is the location of the previous definition #define SLAVE_GLM 16 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:62:0: warning: "SLAVE_GFX3D_CFG" redefined #define SLAVE_GFX3D_CFG 23 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:53:0: note: this is the location of the previous definition #define SLAVE_GFX3D_CFG 17 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:63:0: warning: "SLAVE_IMEM_CFG" redefined #define SLAVE_IMEM_CFG 24 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:54:0: note: this is the location of the previous definition #define SLAVE_IMEM_CFG 18 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:64:0: warning: "SLAVE_IPA_CFG" redefined #define SLAVE_IPA_CFG 25 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:55:0: note: this is the location of the previous definition #define SLAVE_IPA_CFG 19 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:65:0: warning: "SLAVE_CNOC_MNOC_CFG" redefined #define SLAVE_CNOC_MNOC_CFG 26 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:56:0: note: this is the location of the previous definition #define SLAVE_CNOC_MNOC_CFG 20 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:70:0: warning: "SLAVE_PDM" redefined #define SLAVE_PDM 31 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:59:0: note: this is the location of the previous definition #define SLAVE_PDM 23 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:71:0: warning: "SLAVE_PIMEM_CFG" redefined #define SLAVE_PIMEM_CFG 32 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:61:0: note: this is the location of the previous definition #define SLAVE_PIMEM_CFG 25 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:72:0: warning: "SLAVE_PRNG" redefined #define SLAVE_PRNG 33 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:62:0: note: this is the location of the previous definition #define SLAVE_PRNG 26 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:73:0: warning: "SLAVE_QDSS_CFG" redefined #define SLAVE_QDSS_CFG 34 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:63:0: note: this is the location of the previous definition #define SLAVE_QDSS_CFG 27 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:79:0: warning: "SLAVE_SDCC_2" redefined #define SLAVE_SDCC_2 40 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:66:0: note: this is the location of the previous definition #define SLAVE_SDCC_2 30 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:81:0: warning: "SLAVE_SNOC_CFG" redefined #define SLAVE_SNOC_CFG 42 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:68:0: note: this is the location of the previous definition #define SLAVE_SNOC_CFG 32 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:82:0: warning: "SLAVE_TCSR" redefined #define SLAVE_TCSR 43 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:71:0: note: this is the location of the previous definition #define SLAVE_TCSR 35 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:84:0: warning: "SLAVE_TLMM_NORTH" redefined #define SLAVE_TLMM_NORTH 45 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:72:0: note: this is the location of the previous definition #define SLAVE_TLMM_NORTH 36 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:85:0: warning: "SLAVE_TLMM_SOUTH" redefined #define SLAVE_TLMM_SOUTH 46 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:73:0: note: this is the location of the previous definition #define SLAVE_TLMM_SOUTH 37 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:86:0: warning: "SLAVE_UFS_MEM_CFG" redefined #define SLAVE_UFS_MEM_CFG 47 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:76:0: note: this is the location of the previous definition #define SLAVE_UFS_MEM_CFG 40 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:88:0: warning: "SLAVE_VENUS_CFG" redefined #define SLAVE_VENUS_CFG 49 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:79:0: note: this is the location of the previous definition #define SLAVE_VENUS_CFG 43 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:90:0: warning: "SLAVE_VSENSE_CTRL_CFG" redefined #define SLAVE_VSENSE_CTRL_CFG 51 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:80:0: note: this is the location of the previous definition #define SLAVE_VSENSE_CTRL_CFG 44 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:91:0: warning: "SLAVE_SERVICE_CNOC" redefined #define SLAVE_SERVICE_CNOC 52 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:82:0: note: this is the location of the previous definition #define SLAVE_SERVICE_CNOC 46 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:95:0: warning: "SLAVE_LLCC_CFG" redefined #define SLAVE_LLCC_CFG 2 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:85:0: note: this is the location of the previous definition #define SLAVE_LLCC_CFG 1 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:101:0: warning: "MASTER_MNOC_HF_MEM_NOC" redefined #define MASTER_MNOC_HF_MEM_NOC 4 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:97:0: note: this is the location of the previous definition #define MASTER_MNOC_HF_MEM_NOC 3 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:102:0: warning: "MASTER_MNOC_SF_MEM_NOC" redefined #define MASTER_MNOC_SF_MEM_NOC 5 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:98:0: note: this is the location of the previous definition #define MASTER_MNOC_SF_MEM_NOC 4 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:103:0: warning: "MASTER_SNOC_GC_MEM_NOC" redefined #define MASTER_SNOC_GC_MEM_NOC 6 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:99:0: note: this is the location of the previous definition #define MASTER_SNOC_GC_MEM_NOC 5 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:104:0: warning: "MASTER_SNOC_SF_MEM_NOC" redefined #define MASTER_SNOC_SF_MEM_NOC 7 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:100:0: note: this is the location of the previous definition #define MASTER_SNOC_SF_MEM_NOC 6 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:105:0: warning: "MASTER_GFX3D" redefined #define MASTER_GFX3D 8 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:101:0: note: this is the location of the previous definition #define MASTER_GFX3D 7 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:106:0: warning: "SLAVE_MSS_PROC_MS_MPU_CFG" redefined #define SLAVE_MSS_PROC_MS_MPU_CFG 9 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:102:0: note: this is the location of the previous definition #define SLAVE_MSS_PROC_MS_MPU_CFG 8 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:108:0: warning: "SLAVE_LLCC" redefined #define SLAVE_LLCC 11 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:104:0: note: this is the location of the previous definition #define SLAVE_LLCC 10 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:114:0: warning: "MASTER_LLCC" redefined #define MASTER_LLCC 0 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:107:0: note: this is the location of the previous definition #define MASTER_LLCC 13 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:115:0: warning: "SLAVE_EBI1" redefined #define SLAVE_EBI1 1 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:108:0: note: this is the location of the previous definition #define SLAVE_EBI1 14 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:122:0: warning: "MASTER_ROTATOR" redefined #define MASTER_ROTATOR 5 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:116:0: note: this is the location of the previous definition #define MASTER_ROTATOR 6 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:123:0: warning: "MASTER_VIDEO_P0" redefined #define MASTER_VIDEO_P0 6 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:117:0: note: this is the location of the previous definition #define MASTER_VIDEO_P0 7 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:124:0: warning: "MASTER_VIDEO_PROC" redefined #define MASTER_VIDEO_PROC 7 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:119:0: note: this is the location of the previous definition #define MASTER_VIDEO_PROC 9 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:125:0: warning: "SLAVE_MNOC_HF_MEM_NOC" redefined #define SLAVE_MNOC_HF_MEM_NOC 8 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:121:0: note: this is the location of the previous definition #define SLAVE_MNOC_HF_MEM_NOC 11 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:126:0: warning: "SLAVE_MNOC_SF_MEM_NOC" redefined #define SLAVE_MNOC_SF_MEM_NOC 9 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:120:0: note: this is the location of the previous definition #define SLAVE_MNOC_SF_MEM_NOC 10 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:127:0: warning: "SLAVE_SERVICE_MNOC" redefined #define SLAVE_SERVICE_MNOC 10 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:122:0: note: this is the location of the previous definition #define SLAVE_SERVICE_MNOC 12 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:150:0: warning: "MASTER_PIMEM" redefined #define MASTER_PIMEM 4 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:134:0: note: this is the location of the previous definition #define MASTER_PIMEM 6 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:151:0: warning: "SLAVE_APPSS" redefined #define SLAVE_APPSS 5 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:136:0: note: this is the location of the previous definition #define SLAVE_APPSS 8 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:152:0: warning: "SLAVE_SNOC_CNOC" redefined #define SLAVE_SNOC_CNOC 6 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:137:0: note: this is the location of the previous definition #define SLAVE_SNOC_CNOC 9 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:155:0: warning: "SLAVE_IMEM" redefined #define SLAVE_IMEM 9 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:140:0: note: this is the location of the previous definition #define SLAVE_IMEM 12 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:156:0: warning: "SLAVE_PIMEM" redefined #define SLAVE_PIMEM 10 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:143:0: note: this is the location of the previous definition #define SLAVE_PIMEM 15 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:157:0: warning: "SLAVE_SERVICE_SNOC" redefined #define SLAVE_SERVICE_SNOC 11 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:144:0: note: this is the location of the previous definition #define SLAVE_SERVICE_SNOC 16 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:158:0: warning: "SLAVE_QDSS_STM" redefined #define SLAVE_QDSS_STM 12 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:145:0: note: this is the location of the previous definition #define SLAVE_QDSS_STM 17 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:53:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sc7180.h:159:0: warning: "SLAVE_TCU" redefined #define SLAVE_TCU 13 In file included from Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:19:0: ./scripts/dtc/include-prefixes/dt-bindings/interconnect/qcom,sdm845.h:146:0: note: this is the location of the previous definition #define SLAVE_TCU 18 Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dts:69.40-74.11: ERROR (duplicate_label): /example-1/interconnect@1740000: Duplicate label 'mmss_noc' on /example-1/interconnect@1740000 and /example-0/interconnect@1740000 ERROR: Input tree has errors, aborting (use -f to force output) scripts/Makefile.lib:315: recipe for target 'Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/interconnect/qcom,rpmh.example.dt.yaml] Error 2 make[1]: *** Waiting for unfinished jobs.... Makefile:1347: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1328116 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/7] dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings 2020-07-13 15:41 [PATCH v2 0/7] Add SM8150 and SM8250 interconnect drivers Jonathan Marek 2020-07-13 15:41 ` [PATCH v2 1/7] dt-bindings: interconnect: single yaml file for RPMh " Jonathan Marek @ 2020-07-13 15:41 ` Jonathan Marek 2020-07-16 19:22 ` Rob Herring 2020-07-13 15:41 ` [PATCH v2 3/7] dt-bindings: interconnect: Add Qualcomm SM8250 " Jonathan Marek ` (2 subsequent siblings) 4 siblings, 1 reply; 14+ messages in thread From: Jonathan Marek @ 2020-07-13 15:41 UTC (permalink / raw) To: linux-arm-msm Cc: Andy Gross, Bjorn Andersson, Georgi Djakov, Rob Herring, Odelu Kukatla, open list:INTERCONNECT API, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list The Qualcomm SM8150 platform has several bus fabrics that could be controlled and tuned dynamically according to the bandwidth demand. Signed-off-by: Jonathan Marek <jonathan@marek.ca> --- .../bindings/interconnect/qcom,rpmh.yaml | 11 ++ .../dt-bindings/interconnect/qcom,sm8150.h | 163 ++++++++++++++++++ 2 files changed, 174 insertions(+) create mode 100644 include/dt-bindings/interconnect/qcom,sm8150.h diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml index 9878139a73b8..9dfd1d75fdd3 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml @@ -45,6 +45,17 @@ properties: - qcom,sdm845-mem-noc - qcom,sdm845-mmss-noc - qcom,sdm845-system-noc + - qcom,sm8150-aggre1-noc + - qcom,sm8150-aggre2-noc + - qcom,sm8150-camnoc-noc + - qcom,sm8150-compute-noc + - qcom,sm8150-config-noc + - qcom,sm8150-dc-noc + - qcom,sm8150-gem-noc + - qcom,sm8150-ipa-virt + - qcom,sm8150-mc-virt + - qcom,sm8150-mmss-noc + - qcom,sm8150-system-noc '#interconnect-cells': const: 1 diff --git a/include/dt-bindings/interconnect/qcom,sm8150.h b/include/dt-bindings/interconnect/qcom,sm8150.h new file mode 100644 index 000000000000..ab42f04d93a2 --- /dev/null +++ b/include/dt-bindings/interconnect/qcom,sm8150.h @@ -0,0 +1,163 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Qualcomm SM8150 interconnect IDs + * + * Copyright (c) 2020, The Linux Foundation. All rights reserved. + */ + +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_SM8150_H +#define __DT_BINDINGS_INTERCONNECT_QCOM_SM8150_H + +#define MASTER_A1NOC_CFG 0 +#define MASTER_QUP_0 1 +#define MASTER_EMAC 2 +#define MASTER_UFS_MEM 3 +#define MASTER_USB3 4 +#define MASTER_USB3_1 5 +#define A1NOC_SNOC_SLV 6 +#define SLAVE_SERVICE_A1NOC 7 + +#define MASTER_A2NOC_CFG 0 +#define MASTER_QDSS_BAM 1 +#define MASTER_QSPI 2 +#define MASTER_QUP_1 3 +#define MASTER_QUP_2 4 +#define MASTER_SENSORS_AHB 5 +#define MASTER_TSIF 6 +#define MASTER_CNOC_A2NOC 7 +#define MASTER_CRYPTO_CORE_0 8 +#define MASTER_IPA 9 +#define MASTER_PCIE 10 +#define MASTER_PCIE_1 11 +#define MASTER_QDSS_ETR 12 +#define MASTER_SDCC_2 13 +#define MASTER_SDCC_4 14 +#define A2NOC_SNOC_SLV 15 +#define SLAVE_ANOC_PCIE_GEM_NOC 16 +#define SLAVE_SERVICE_A2NOC 17 + +#define MASTER_CAMNOC_HF0_UNCOMP 0 +#define MASTER_CAMNOC_HF1_UNCOMP 1 +#define MASTER_CAMNOC_SF_UNCOMP 2 +#define SLAVE_CAMNOC_UNCOMP 3 + +#define MASTER_NPU 0 +#define SLAVE_CDSP_MEM_NOC 1 + +#define MASTER_SPDM 0 +#define SNOC_CNOC_MAS 1 +#define MASTER_QDSS_DAP 2 +#define SLAVE_A1NOC_CFG 3 +#define SLAVE_A2NOC_CFG 4 +#define SLAVE_AHB2PHY_SOUTH 5 +#define SLAVE_AOP 6 +#define SLAVE_AOSS 7 +#define SLAVE_CAMERA_CFG 8 +#define SLAVE_CLK_CTL 9 +#define SLAVE_CDSP_CFG 10 +#define SLAVE_RBCPR_CX_CFG 11 +#define SLAVE_RBCPR_MMCX_CFG 12 +#define SLAVE_RBCPR_MX_CFG 13 +#define SLAVE_CRYPTO_0_CFG 14 +#define SLAVE_CNOC_DDRSS 15 +#define SLAVE_DISPLAY_CFG 16 +#define SLAVE_EMAC_CFG 17 +#define SLAVE_GLM 18 +#define SLAVE_GRAPHICS_3D_CFG 19 +#define SLAVE_IMEM_CFG 20 +#define SLAVE_IPA_CFG 21 +#define SLAVE_CNOC_MNOC_CFG 22 +#define SLAVE_NPU_CFG 23 +#define SLAVE_PCIE_0_CFG 24 +#define SLAVE_PCIE_1_CFG 25 +#define SLAVE_NORTH_PHY_CFG 26 +#define SLAVE_PIMEM_CFG 27 +#define SLAVE_PRNG 28 +#define SLAVE_QDSS_CFG 29 +#define SLAVE_QSPI 30 +#define SLAVE_QUP_2 31 +#define SLAVE_QUP_1 32 +#define SLAVE_QUP_0 33 +#define SLAVE_SDCC_2 34 +#define SLAVE_SDCC_4 35 +#define SLAVE_SNOC_CFG 36 +#define SLAVE_SPDM_WRAPPER 37 +#define SLAVE_SPSS_CFG 38 +#define SLAVE_SSC_CFG 39 +#define SLAVE_TCSR 40 +#define SLAVE_TLMM_EAST 41 +#define SLAVE_TLMM_NORTH 42 +#define SLAVE_TLMM_SOUTH 43 +#define SLAVE_TLMM_WEST 44 +#define SLAVE_TSIF 45 +#define SLAVE_UFS_CARD_CFG 46 +#define SLAVE_UFS_MEM_CFG 47 +#define SLAVE_USB3 48 +#define SLAVE_USB3_1 49 +#define SLAVE_VENUS_CFG 50 +#define SLAVE_VSENSE_CTRL_CFG 51 +#define SLAVE_CNOC_A2NOC 52 +#define SLAVE_SERVICE_CNOC 53 + +#define MASTER_CNOC_DC_NOC 0 +#define SLAVE_LLCC_CFG 1 +#define SLAVE_GEM_NOC_CFG 2 + +#define MASTER_AMPSS_M0 0 +#define MASTER_GPU_TCU 1 +#define MASTER_SYS_TCU 2 +#define MASTER_GEM_NOC_CFG 3 +#define MASTER_COMPUTE_NOC 4 +#define MASTER_GRAPHICS_3D 5 +#define MASTER_MNOC_HF_MEM_NOC 6 +#define MASTER_MNOC_SF_MEM_NOC 7 +#define MASTER_GEM_NOC_PCIE_SNOC 8 +#define MASTER_SNOC_GC_MEM_NOC 9 +#define MASTER_SNOC_SF_MEM_NOC 10 +#define MASTER_ECC 11 +#define SLAVE_MSS_PROC_MS_MPU_CFG 12 +#define SLAVE_ECC 13 +#define SLAVE_GEM_NOC_SNOC 14 +#define SLAVE_LLCC 15 +#define SLAVE_SERVICE_GEM_NOC 16 + +#define MASTER_IPA_CORE 0 +#define SLAVE_IPA_CORE 1 + +#define MASTER_LLCC 0 +#define MASTER_ALC 1 +#define SLAVE_EBI_CH0 2 + +#define MASTER_CNOC_MNOC_CFG 0 +#define MASTER_CAMNOC_HF0 1 +#define MASTER_CAMNOC_HF1 2 +#define MASTER_CAMNOC_SF 3 +#define MASTER_MDP_PORT0 4 +#define MASTER_MDP_PORT1 5 +#define MASTER_ROTATOR 6 +#define MASTER_VIDEO_P0 7 +#define MASTER_VIDEO_P1 8 +#define MASTER_VIDEO_PROC 9 +#define SLAVE_MNOC_SF_MEM_NOC 10 +#define SLAVE_MNOC_HF_MEM_NOC 11 +#define SLAVE_SERVICE_MNOC 12 + +#define MASTER_SNOC_CFG 0 +#define A1NOC_SNOC_MAS 1 +#define A2NOC_SNOC_MAS 2 +#define MASTER_GEM_NOC_SNOC 3 +#define MASTER_PIMEM 4 +#define MASTER_GIC 5 +#define SLAVE_APPSS 6 +#define SNOC_CNOC_SLV 7 +#define SLAVE_SNOC_GEM_NOC_GC 8 +#define SLAVE_SNOC_GEM_NOC_SF 9 +#define SLAVE_OCIMEM 10 +#define SLAVE_PIMEM 11 +#define SLAVE_SERVICE_SNOC 12 +#define SLAVE_PCIE_0 13 +#define SLAVE_PCIE_1 14 +#define SLAVE_QDSS_STM 15 +#define SLAVE_TCU 16 + +#endif -- 2.26.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/7] dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings 2020-07-13 15:41 ` [PATCH v2 2/7] dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings Jonathan Marek @ 2020-07-16 19:22 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2020-07-16 19:22 UTC (permalink / raw) To: Jonathan Marek Cc: Bjorn Andersson, Rob Herring, Georgi Djakov, Odelu Kukatla, linux-pm, Andy Gross, linux-arm-msm, linux-kernel, devicetree On Mon, 13 Jul 2020 11:41:11 -0400, Jonathan Marek wrote: > The Qualcomm SM8150 platform has several bus fabrics that could be > controlled and tuned dynamically according to the bandwidth demand. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > .../bindings/interconnect/qcom,rpmh.yaml | 11 ++ > .../dt-bindings/interconnect/qcom,sm8150.h | 163 ++++++++++++++++++ > 2 files changed, 174 insertions(+) > create mode 100644 include/dt-bindings/interconnect/qcom,sm8150.h > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/7] dt-bindings: interconnect: Add Qualcomm SM8250 DT bindings 2020-07-13 15:41 [PATCH v2 0/7] Add SM8150 and SM8250 interconnect drivers Jonathan Marek 2020-07-13 15:41 ` [PATCH v2 1/7] dt-bindings: interconnect: single yaml file for RPMh " Jonathan Marek 2020-07-13 15:41 ` [PATCH v2 2/7] dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings Jonathan Marek @ 2020-07-13 15:41 ` Jonathan Marek 2020-07-16 19:22 ` Rob Herring 2020-07-13 15:41 ` [PATCH v2 6/7] arm64: dts: qcom: sm8150: add interconnect nodes Jonathan Marek 2020-07-13 15:41 ` [PATCH v2 7/7] arm64: dts: qcom: sm8250: " Jonathan Marek 4 siblings, 1 reply; 14+ messages in thread From: Jonathan Marek @ 2020-07-13 15:41 UTC (permalink / raw) To: linux-arm-msm Cc: Andy Gross, Bjorn Andersson, Georgi Djakov, Rob Herring, Odelu Kukatla, open list:INTERCONNECT API, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list The Qualcomm SM8250 platform has several bus fabrics that could be controlled and tuned dynamically according to the bandwidth demand. Signed-off-by: Jonathan Marek <jonathan@marek.ca> --- .../bindings/interconnect/qcom,rpmh.yaml | 11 ++ .../dt-bindings/interconnect/qcom,sm8250.h | 173 ++++++++++++++++++ 2 files changed, 184 insertions(+) create mode 100644 include/dt-bindings/interconnect/qcom,sm8250.h diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml index 9dfd1d75fdd3..4894ff0e8246 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml @@ -56,6 +56,17 @@ properties: - qcom,sm8150-mc-virt - qcom,sm8150-mmss-noc - qcom,sm8150-system-noc + - qcom,sm8250-aggre1-noc + - qcom,sm8250-aggre2-noc + - qcom,sm8250-compute-noc + - qcom,sm8250-config-noc + - qcom,sm8250-dc-noc + - qcom,sm8250-gem-noc + - qcom,sm8250-ipa-virt + - qcom,sm8250-mc-virt + - qcom,sm8250-mmss-noc + - qcom,sm8250-npu-noc + - qcom,sm8250-system-noc '#interconnect-cells': const: 1 diff --git a/include/dt-bindings/interconnect/qcom,sm8250.h b/include/dt-bindings/interconnect/qcom,sm8250.h new file mode 100644 index 000000000000..fda27ac7b3c4 --- /dev/null +++ b/include/dt-bindings/interconnect/qcom,sm8250.h @@ -0,0 +1,173 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Qualcomm SM8250 interconnect IDs + * + * Copyright (c) 2020, The Linux Foundation. All rights reserved. + */ + +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_SM8250_H +#define __DT_BINDINGS_INTERCONNECT_QCOM_SM8250_H + +#define MASTER_A1NOC_CFG 0 +#define MASTER_QSPI_0 1 +#define MASTER_QUP_1 2 +#define MASTER_QUP_2 3 +#define MASTER_TSIF 4 +#define MASTER_PCIE_2 5 +#define MASTER_SDCC_4 6 +#define MASTER_UFS_MEM 7 +#define MASTER_USB3 8 +#define MASTER_USB3_1 9 +#define A1NOC_SNOC_SLV 10 +#define SLAVE_ANOC_PCIE_GEM_NOC_1 11 +#define SLAVE_SERVICE_A1NOC 12 + +#define MASTER_A2NOC_CFG 0 +#define MASTER_QDSS_BAM 1 +#define MASTER_QUP_0 2 +#define MASTER_CNOC_A2NOC 3 +#define MASTER_CRYPTO_CORE_0 4 +#define MASTER_IPA 5 +#define MASTER_PCIE 6 +#define MASTER_PCIE_1 7 +#define MASTER_QDSS_ETR 8 +#define MASTER_SDCC_2 9 +#define MASTER_UFS_CARD 10 +#define A2NOC_SNOC_SLV 11 +#define SLAVE_ANOC_PCIE_GEM_NOC 12 +#define SLAVE_SERVICE_A2NOC 13 + +#define MASTER_NPU 0 +#define SLAVE_CDSP_MEM_NOC 1 + +#define SNOC_CNOC_MAS 0 +#define MASTER_QDSS_DAP 1 +#define SLAVE_A1NOC_CFG 2 +#define SLAVE_A2NOC_CFG 3 +#define SLAVE_AHB2PHY_SOUTH 4 +#define SLAVE_AHB2PHY_NORTH 5 +#define SLAVE_AOSS 6 +#define SLAVE_CAMERA_CFG 7 +#define SLAVE_CLK_CTL 8 +#define SLAVE_CDSP_CFG 9 +#define SLAVE_RBCPR_CX_CFG 10 +#define SLAVE_RBCPR_MMCX_CFG 11 +#define SLAVE_RBCPR_MX_CFG 12 +#define SLAVE_CRYPTO_0_CFG 13 +#define SLAVE_CX_RDPM 14 +#define SLAVE_DCC_CFG 15 +#define SLAVE_CNOC_DDRSS 16 +#define SLAVE_DISPLAY_CFG 17 +#define SLAVE_GRAPHICS_3D_CFG 18 +#define SLAVE_IMEM_CFG 19 +#define SLAVE_IPA_CFG 20 +#define SLAVE_IPC_ROUTER_CFG 21 +#define SLAVE_LPASS 22 +#define SLAVE_CNOC_MNOC_CFG 23 +#define SLAVE_NPU_CFG 24 +#define SLAVE_PCIE_0_CFG 25 +#define SLAVE_PCIE_1_CFG 26 +#define SLAVE_PCIE_2_CFG 27 +#define SLAVE_PDM 28 +#define SLAVE_PIMEM_CFG 29 +#define SLAVE_PRNG 30 +#define SLAVE_QDSS_CFG 31 +#define SLAVE_QSPI_0 32 +#define SLAVE_QUP_0 33 +#define SLAVE_QUP_1 34 +#define SLAVE_QUP_2 35 +#define SLAVE_SDCC_2 36 +#define SLAVE_SDCC_4 37 +#define SLAVE_SNOC_CFG 38 +#define SLAVE_TCSR 39 +#define SLAVE_TLMM_NORTH 40 +#define SLAVE_TLMM_SOUTH 41 +#define SLAVE_TLMM_WEST 42 +#define SLAVE_TSIF 43 +#define SLAVE_UFS_CARD_CFG 44 +#define SLAVE_UFS_MEM_CFG 45 +#define SLAVE_USB3 46 +#define SLAVE_USB3_1 47 +#define SLAVE_VENUS_CFG 48 +#define SLAVE_VSENSE_CTRL_CFG 49 +#define SLAVE_CNOC_A2NOC 50 +#define SLAVE_SERVICE_CNOC 51 + +#define MASTER_CNOC_DC_NOC 0 +#define SLAVE_LLCC_CFG 1 +#define SLAVE_GEM_NOC_CFG 2 + +#define MASTER_GPU_TCU 0 +#define MASTER_SYS_TCU 1 +#define MASTER_AMPSS_M0 2 +#define MASTER_GEM_NOC_CFG 3 +#define MASTER_COMPUTE_NOC 4 +#define MASTER_GRAPHICS_3D 5 +#define MASTER_MNOC_HF_MEM_NOC 6 +#define MASTER_MNOC_SF_MEM_NOC 7 +#define MASTER_ANOC_PCIE_GEM_NOC 8 +#define MASTER_SNOC_GC_MEM_NOC 9 +#define MASTER_SNOC_SF_MEM_NOC 10 +#define SLAVE_GEM_NOC_SNOC 11 +#define SLAVE_LLCC 12 +#define SLAVE_MEM_NOC_PCIE_SNOC 13 +#define SLAVE_SERVICE_GEM_NOC_1 14 +#define SLAVE_SERVICE_GEM_NOC_2 15 +#define SLAVE_SERVICE_GEM_NOC 16 + +#define MASTER_IPA_CORE 0 +#define SLAVE_IPA_CORE 1 + +#define MASTER_LLCC 0 +#define MASTER_ALC 1 +#define SLAVE_EBI_CH0 2 + +#define MASTER_CNOC_MNOC_CFG 0 +#define MASTER_CAMNOC_HF 1 +#define MASTER_CAMNOC_ICP 2 +#define MASTER_CAMNOC_SF 3 +#define MASTER_VIDEO_P0 4 +#define MASTER_VIDEO_P1 5 +#define MASTER_VIDEO_PROC 6 +#define MASTER_MDP_PORT0 7 +#define MASTER_MDP_PORT1 8 +#define MASTER_ROTATOR 9 +#define SLAVE_MNOC_HF_MEM_NOC 10 +#define SLAVE_MNOC_SF_MEM_NOC 11 +#define SLAVE_SERVICE_MNOC 12 + +#define MASTER_NPU_SYS 0 +#define MASTER_NPU_CDP 1 +#define MASTER_NPU_NOC_CFG 2 +#define SLAVE_NPU_CAL_DP0 3 +#define SLAVE_NPU_CAL_DP1 4 +#define SLAVE_NPU_CP 5 +#define SLAVE_NPU_INT_DMA_BWMON_CFG 6 +#define SLAVE_NPU_DPM 7 +#define SLAVE_ISENSE_CFG 8 +#define SLAVE_NPU_LLM_CFG 9 +#define SLAVE_NPU_TCM 10 +#define SLAVE_NPU_COMPUTE_NOC 11 +#define SLAVE_SERVICE_NPU_NOC 12 + +#define MASTER_SNOC_CFG 0 +#define A1NOC_SNOC_MAS 1 +#define A2NOC_SNOC_MAS 2 +#define MASTER_GEM_NOC_SNOC 3 +#define MASTER_GEM_NOC_PCIE_SNOC 4 +#define MASTER_PIMEM 5 +#define MASTER_GIC 6 +#define SLAVE_APPSS 7 +#define SNOC_CNOC_SLV 8 +#define SLAVE_SNOC_GEM_NOC_GC 9 +#define SLAVE_SNOC_GEM_NOC_SF 10 +#define SLAVE_OCIMEM 11 +#define SLAVE_PIMEM 12 +#define SLAVE_SERVICE_SNOC 13 +#define SLAVE_PCIE_0 14 +#define SLAVE_PCIE_1 15 +#define SLAVE_PCIE_2 16 +#define SLAVE_QDSS_STM 17 +#define SLAVE_TCU 18 + +#endif -- 2.26.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/7] dt-bindings: interconnect: Add Qualcomm SM8250 DT bindings 2020-07-13 15:41 ` [PATCH v2 3/7] dt-bindings: interconnect: Add Qualcomm SM8250 " Jonathan Marek @ 2020-07-16 19:22 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2020-07-16 19:22 UTC (permalink / raw) To: Jonathan Marek Cc: Bjorn Andersson, linux-arm-msm, linux-pm, Georgi Djakov, linux-kernel, Rob Herring, devicetree, Odelu Kukatla, Andy Gross On Mon, 13 Jul 2020 11:41:12 -0400, Jonathan Marek wrote: > The Qualcomm SM8250 platform has several bus fabrics that could be > controlled and tuned dynamically according to the bandwidth demand. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > .../bindings/interconnect/qcom,rpmh.yaml | 11 ++ > .../dt-bindings/interconnect/qcom,sm8250.h | 173 ++++++++++++++++++ > 2 files changed, 184 insertions(+) > create mode 100644 include/dt-bindings/interconnect/qcom,sm8250.h > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 6/7] arm64: dts: qcom: sm8150: add interconnect nodes 2020-07-13 15:41 [PATCH v2 0/7] Add SM8150 and SM8250 interconnect drivers Jonathan Marek ` (2 preceding siblings ...) 2020-07-13 15:41 ` [PATCH v2 3/7] dt-bindings: interconnect: Add Qualcomm SM8250 " Jonathan Marek @ 2020-07-13 15:41 ` Jonathan Marek 2020-07-24 14:13 ` Sibi Sankar 2020-07-13 15:41 ` [PATCH v2 7/7] arm64: dts: qcom: sm8250: " Jonathan Marek 4 siblings, 1 reply; 14+ messages in thread From: Jonathan Marek @ 2020-07-13 15:41 UTC (permalink / raw) To: linux-arm-msm Cc: Andy Gross, Bjorn Andersson, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list Add the interconnect dts nodes for sm8150. Signed-off-by: Jonathan Marek <jonathan@marek.ca> --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 82 ++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 33ff99132f4f..fa9cd9d60093 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -11,6 +11,7 @@ #include <dt-bindings/clock/qcom,rpmh.h> #include <dt-bindings/clock/qcom,gcc-sm8150.h> #include <dt-bindings/clock/qcom,gpucc-sm8150.h> +#include <dt-bindings/interconnect/qcom,sm8150.h> #include <dt-bindings/thermal/thermal.h> / { @@ -440,6 +441,69 @@ uart2: serial@a90000 { }; }; + dc_noc: interconnect@14e0000 { + compatible = "qcom,sm8150-dc-noc"; + reg = <0 0x014e0000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + config_noc: interconnect@1500000 { + compatible = "qcom,sm8150-config-noc"; + reg = <0 0x01500000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + camnoc_virt: interconnect@1620000 { + compatible = "qcom,sm8150-camnoc-virt"; + reg = <0 0x01620000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + ipa_virt: interconnect-ipa@1620000 { + compatible = "qcom,sm8150-ipa-virt"; + reg = <0 0x01620000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + system_noc: interconnect@1629000 { + compatible = "qcom,sm8150-system-noc"; + reg = <0 0x01629000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + aggre1_noc: interconnect@16e4000 { + compatible = "qcom,sm8150-aggre1-noc"; + reg = <0 0x016e4000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + aggre2_noc: interconnect@1706000 { + compatible = "qcom,sm8150-aggre2-noc"; + reg = <0 0x01706000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + compute_noc: interconnect@1720000 { + compatible = "qcom,sm8150-compute-noc"; + reg = <0 0x01720000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + mmss_noc: interconnect@1749000 { + compatible = "qcom,sm8150-mmss-noc"; + reg = <0 0x01749000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + ufs_mem_hc: ufshc@1d84000 { compatible = "qcom,sm8150-ufshc", "qcom,ufshc", "jedec,ufs-2.0"; @@ -860,6 +924,20 @@ usb_2_ssphy: lane@88eb200 { }; }; + mc_virt: interconnect@9680000 { + compatible = "qcom,sm8150-mc-virt"; + reg = <0 0x09680000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + gem_noc: interconnect@96ab000 { + compatible = "qcom,sm8150-gem-noc"; + reg = <0 0x096ab000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + usb_1: usb@a6f8800 { compatible = "qcom,sm8150-dwc3", "qcom,dwc3"; reg = <0 0x0a6f8800 0 0x400>; @@ -1280,6 +1358,10 @@ rpmhpd_opp_turbo_l1: opp11 { }; }; }; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,bcm-voter"; + }; }; cpufreq_hw: cpufreq@18323000 { -- 2.26.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 6/7] arm64: dts: qcom: sm8150: add interconnect nodes 2020-07-13 15:41 ` [PATCH v2 6/7] arm64: dts: qcom: sm8150: add interconnect nodes Jonathan Marek @ 2020-07-24 14:13 ` Sibi Sankar 0 siblings, 0 replies; 14+ messages in thread From: Sibi Sankar @ 2020-07-24 14:13 UTC (permalink / raw) To: Jonathan Marek Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Rob Herring, devicetree, linux-kernel, linux-arm-msm-owner Hey Jonathan, Thanks for the patch! Please use the suggested register space definitions instead. On 2020-07-13 21:11, Jonathan Marek wrote: > Add the interconnect dts nodes for sm8150. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 82 ++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi > b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index 33ff99132f4f..fa9cd9d60093 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -11,6 +11,7 @@ > #include <dt-bindings/clock/qcom,rpmh.h> > #include <dt-bindings/clock/qcom,gcc-sm8150.h> > #include <dt-bindings/clock/qcom,gpucc-sm8150.h> > +#include <dt-bindings/interconnect/qcom,sm8150.h> > #include <dt-bindings/thermal/thermal.h> > > / { > @@ -440,6 +441,69 @@ uart2: serial@a90000 { > }; > }; > > + dc_noc: interconnect@14e0000 { > + compatible = "qcom,sm8150-dc-noc"; > + reg = <0 0x014e0000 0 0x1000>; 0x09160000 0x3200 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + config_noc: interconnect@1500000 { > + compatible = "qcom,sm8150-config-noc"; > + reg = <0 0x01500000 0 0x1000>; 0x01500000 0x7400 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + camnoc_virt: interconnect@1620000 { > + compatible = "qcom,sm8150-camnoc-virt"; > + reg = <0 0x01620000 0 0x1000>; 0x0ac00000 0x1000 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + ipa_virt: interconnect-ipa@1620000 { > + compatible = "qcom,sm8150-ipa-virt"; > + reg = <0 0x01620000 0 0x1000>; 0x01e00000 0x1000 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + system_noc: interconnect@1629000 { > + compatible = "qcom,sm8150-system-noc"; > + reg = <0 0x01500000 0 0x1000>; 0x01620000 0x19400 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + aggre1_noc: interconnect@16e4000 { > + compatible = "qcom,sm8150-aggre1-noc"; > + reg = <0 0x016e4000 0 0x1000>; 0x016e0000 0xd080 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + aggre2_noc: interconnect@1706000 { > + compatible = "qcom,sm8150-aggre2-noc"; > + reg = <0 0x01706000 0 0x1000>; 0x01700000 0x3b100 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + compute_noc: interconnect@1720000 { > + compatible = "qcom,sm8150-compute-noc"; > + reg = <0 0x01720000 0 0x1000>; 0x01720000 0x7000 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + mmss_noc: interconnect@1749000 { > + compatible = "qcom,sm8150-mmss-noc"; > + reg = <0 0x01749000 0 0x1000>; 0x01740000 0x1c100 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > ufs_mem_hc: ufshc@1d84000 { > compatible = "qcom,sm8150-ufshc", "qcom,ufshc", > "jedec,ufs-2.0"; > @@ -860,6 +924,20 @@ usb_2_ssphy: lane@88eb200 { > }; > }; > > + mc_virt: interconnect@9680000 { > + compatible = "qcom,sm8150-mc-virt"; > + reg = <0 0x09680000 0 0x1000>; 0x0163a000 0x1000 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + gem_noc: interconnect@96ab000 { > + compatible = "qcom,sm8150-gem-noc"; > + reg = <0 0x096ab000 0 0x1000>; 0x09680000 0x3e200 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > usb_1: usb@a6f8800 { > compatible = "qcom,sm8150-dwc3", "qcom,dwc3"; > reg = <0 0x0a6f8800 0 0x400>; > @@ -1280,6 +1358,10 @@ rpmhpd_opp_turbo_l1: opp11 { > }; > }; > }; > + > + apps_bcm_voter: bcm_voter { > + compatible = "qcom,bcm-voter"; > + }; > }; > > cpufreq_hw: cpufreq@18323000 { -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes 2020-07-13 15:41 [PATCH v2 0/7] Add SM8150 and SM8250 interconnect drivers Jonathan Marek ` (3 preceding siblings ...) 2020-07-13 15:41 ` [PATCH v2 6/7] arm64: dts: qcom: sm8150: add interconnect nodes Jonathan Marek @ 2020-07-13 15:41 ` Jonathan Marek 2020-07-24 14:13 ` Sibi Sankar 4 siblings, 1 reply; 14+ messages in thread From: Jonathan Marek @ 2020-07-13 15:41 UTC (permalink / raw) To: linux-arm-msm Cc: Andy Gross, Bjorn Andersson, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list Add the interconnect dts nodes for sm8250. Signed-off-by: Jonathan Marek <jonathan@marek.ca> --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 ++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 636e2196138c..dfc1b7fa7d85 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -11,6 +11,7 @@ #include <dt-bindings/power/qcom-aoss-qmp.h> #include <dt-bindings/power/qcom-rpmpd.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h> +#include <dt-bindings/interconnect/qcom,sm8250.h> / { interrupt-parent = <&intc>; @@ -978,6 +979,55 @@ spi13: spi@a94000 { }; }; + config_noc: interconnect@1500000 { + compatible = "qcom,sm8250-config-noc"; + reg = <0 0x01500000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + ipa_virt: interconnect@1620000 { + compatible = "qcom,sm8250-ipa-virt"; + reg = <0 0x01620000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + system_noc: interconnect@1632000 { + compatible = "qcom,sm8250-system-noc"; + reg = <0 0x01632000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + aggre1_noc: interconnect@16e2000 { + compatible = "qcom,sm8250-aggre1-noc"; + reg = <0 0x016e2000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + aggre2_noc: interconnect@1703000 { + compatible = "qcom,sm8250-aggre2-noc"; + reg = <0 0x01703000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + compute_noc: interconnect@1733000 { + compatible = "qcom,sm8250-compute-noc"; + reg = <0 0x01733000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + mmss_noc: interconnect@174a000 { + compatible = "qcom,sm8250-mmss-noc"; + reg = <0 0x0174a000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + ufs_mem_hc: ufshc@1d84000 { compatible = "qcom,sm8250-ufshc", "qcom,ufshc", "jedec,ufs-2.0"; @@ -1364,6 +1414,34 @@ usb_2_ssphy: lane@88eb200 { }; }; + dc_noc: interconnect@90c0000 { + compatible = "qcom,sm8250-dc-noc"; + reg = <0 0x090c0000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + mc_virt: interconnect@9100000 { + compatible = "qcom,sm8250-mc-virt"; + reg = <0 0x09100000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + gem_noc: interconnect@9121000 { + compatible = "qcom,sm8250-gem-noc"; + reg = <0 0x09121000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + npu_noc: interconnect@9990000 { + compatible = "qcom,sm8250-npu-noc"; + reg = <0 0x09990000 0 0x1000>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + usb_1: usb@a6f8800 { compatible = "qcom,sm8250-dwc3", "qcom,dwc3"; reg = <0 0x0a6f8800 0 0x400>; @@ -2359,6 +2437,10 @@ rpmhpd_opp_turbo_l1: opp10 { }; }; }; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,bcm-voter"; + }; }; }; -- 2.26.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes 2020-07-13 15:41 ` [PATCH v2 7/7] arm64: dts: qcom: sm8250: " Jonathan Marek @ 2020-07-24 14:13 ` Sibi Sankar 2020-07-24 14:36 ` Jonathan Marek 0 siblings, 1 reply; 14+ messages in thread From: Sibi Sankar @ 2020-07-24 14:13 UTC (permalink / raw) To: Jonathan Marek Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Rob Herring, devicetree, linux-kernel, linux-kernel-owner Hey Jonathan, Thanks for the patch! Please use the suggested register space definitions instead. On 2020-07-13 21:11, Jonathan Marek wrote: > Add the interconnect dts nodes for sm8250. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 ++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi > b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 636e2196138c..dfc1b7fa7d85 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -11,6 +11,7 @@ > #include <dt-bindings/power/qcom-aoss-qmp.h> > #include <dt-bindings/power/qcom-rpmpd.h> > #include <dt-bindings/soc/qcom,rpmh-rsc.h> > +#include <dt-bindings/interconnect/qcom,sm8250.h> please fix ^^ sort order > > / { > interrupt-parent = <&intc>; > @@ -978,6 +979,55 @@ spi13: spi@a94000 { > }; > }; > > + config_noc: interconnect@1500000 { > + compatible = "qcom,sm8250-config-noc"; > + reg = <0 0x01500000 0 0x1000>; 0x01500000 0xa580 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + ipa_virt: interconnect@1620000 { > + compatible = "qcom,sm8250-ipa-virt"; > + reg = <0 0x01620000 0 0x1000>; 0x01e00000 0x1000 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + system_noc: interconnect@1632000 { > + compatible = "qcom,sm8250-system-noc"; > + reg = <0 0x01632000 0 0x1000>; 0x01620000 0x1C200 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + aggre1_noc: interconnect@16e2000 { > + compatible = "qcom,sm8250-aggre1-noc"; > + reg = <0 0x016e2000 0 0x1000>; 0x016e0000 0x1f180 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + aggre2_noc: interconnect@1703000 { > + compatible = "qcom,sm8250-aggre2-noc"; > + reg = <0 0x01703000 0 0x1000>; 0x01700000 0x33000 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + compute_noc: interconnect@1733000 { > + compatible = "qcom,sm8250-compute-noc"; > + reg = <0 0x01733000 0 0x1000>; 0x01733000 0xd180 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + mmss_noc: interconnect@174a000 { > + compatible = "qcom,sm8250-mmss-noc"; > + reg = <0 0x0174a000 0 0x1000>; 0x01740000 0x1f080 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > ufs_mem_hc: ufshc@1d84000 { > compatible = "qcom,sm8250-ufshc", "qcom,ufshc", > "jedec,ufs-2.0"; > @@ -1364,6 +1414,34 @@ usb_2_ssphy: lane@88eb200 { > }; > }; > > + dc_noc: interconnect@90c0000 { > + compatible = "qcom,sm8250-dc-noc"; > + reg = <0 0x090c0000 0 0x1000>; 0x090c0000 0x4200 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + mc_virt: interconnect@9100000 { > + compatible = "qcom,sm8250-mc-virt"; > + reg = <0 0x09100000 0 0x1000>; 0x0163d000 0x1000 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + gem_noc: interconnect@9121000 { > + compatible = "qcom,sm8250-gem-noc"; > + reg = <0 0x09121000 0 0x1000>; 0x09100000 0xb4000 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + npu_noc: interconnect@9990000 { > + compatible = "qcom,sm8250-npu-noc"; > + reg = <0 0x09990000 0 0x1000>; 0x09990000 0x1600 > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > usb_1: usb@a6f8800 { > compatible = "qcom,sm8250-dwc3", "qcom,dwc3"; > reg = <0 0x0a6f8800 0 0x400>; > @@ -2359,6 +2437,10 @@ rpmhpd_opp_turbo_l1: opp10 { > }; > }; > }; > + > + apps_bcm_voter: bcm_voter { > + compatible = "qcom,bcm-voter"; > + }; > }; > }; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes 2020-07-24 14:13 ` Sibi Sankar @ 2020-07-24 14:36 ` Jonathan Marek 2020-07-24 16:55 ` Sibi Sankar 0 siblings, 1 reply; 14+ messages in thread From: Jonathan Marek @ 2020-07-24 14:36 UTC (permalink / raw) To: Sibi Sankar Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Rob Herring, devicetree, linux-kernel, linux-kernel-owner On 7/24/20 10:13 AM, Sibi Sankar wrote: > Hey Jonathan, > > Thanks for the patch! Please use the > suggested register space definitions > instead. > Thanks for the suggestions, I was unsure what to use for the sizes. The reg field is unused by the upstream driver so it is hard to figure out. However, I'm not sure about some of your suggestions for the base address. For example, for "mc_virt" you suggest 0x0163d000, and I have 0x09100000. In the downstream dts, "mc_virt-base" is 0x9100000 and qcom,base-offset for fab_mc_virt is 0. Do you have an explanation for why your suggestion is so different? > On 2020-07-13 21:11, Jonathan Marek wrote: >> Add the interconnect dts nodes for sm8250. >> >> Signed-off-by: Jonathan Marek <jonathan@marek.ca> >> --- >> arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 ++++++++++++++++++++++++++++ >> 1 file changed, 82 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi >> b/arch/arm64/boot/dts/qcom/sm8250.dtsi >> index 636e2196138c..dfc1b7fa7d85 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi >> @@ -11,6 +11,7 @@ >> #include <dt-bindings/power/qcom-aoss-qmp.h> >> #include <dt-bindings/power/qcom-rpmpd.h> >> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >> +#include <dt-bindings/interconnect/qcom,sm8250.h> > > please fix ^^ sort order > >> >> / { >> interrupt-parent = <&intc>; >> @@ -978,6 +979,55 @@ spi13: spi@a94000 { >> }; >> }; >> >> + config_noc: interconnect@1500000 { >> + compatible = "qcom,sm8250-config-noc"; >> + reg = <0 0x01500000 0 0x1000>; > > 0x01500000 0xa580 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + ipa_virt: interconnect@1620000 { >> + compatible = "qcom,sm8250-ipa-virt"; >> + reg = <0 0x01620000 0 0x1000>; > > 0x01e00000 0x1000 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + system_noc: interconnect@1632000 { >> + compatible = "qcom,sm8250-system-noc"; >> + reg = <0 0x01632000 0 0x1000>; > > 0x01620000 0x1C200 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + aggre1_noc: interconnect@16e2000 { >> + compatible = "qcom,sm8250-aggre1-noc"; >> + reg = <0 0x016e2000 0 0x1000>; > > 0x016e0000 0x1f180 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + aggre2_noc: interconnect@1703000 { >> + compatible = "qcom,sm8250-aggre2-noc"; >> + reg = <0 0x01703000 0 0x1000>; > > 0x01700000 0x33000 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + compute_noc: interconnect@1733000 { >> + compatible = "qcom,sm8250-compute-noc"; >> + reg = <0 0x01733000 0 0x1000>; > > 0x01733000 0xd180 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + mmss_noc: interconnect@174a000 { >> + compatible = "qcom,sm8250-mmss-noc"; >> + reg = <0 0x0174a000 0 0x1000>; > > 0x01740000 0x1f080 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> ufs_mem_hc: ufshc@1d84000 { >> compatible = "qcom,sm8250-ufshc", "qcom,ufshc", >> "jedec,ufs-2.0"; >> @@ -1364,6 +1414,34 @@ usb_2_ssphy: lane@88eb200 { >> }; >> }; >> >> + dc_noc: interconnect@90c0000 { >> + compatible = "qcom,sm8250-dc-noc"; >> + reg = <0 0x090c0000 0 0x1000>; > > 0x090c0000 0x4200 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + mc_virt: interconnect@9100000 { >> + compatible = "qcom,sm8250-mc-virt"; >> + reg = <0 0x09100000 0 0x1000>; > > 0x0163d000 0x1000 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + gem_noc: interconnect@9121000 { >> + compatible = "qcom,sm8250-gem-noc"; >> + reg = <0 0x09121000 0 0x1000>; > > 0x09100000 0xb4000 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> + npu_noc: interconnect@9990000 { >> + compatible = "qcom,sm8250-npu-noc"; >> + reg = <0 0x09990000 0 0x1000>; > > 0x09990000 0x1600 > >> + #interconnect-cells = <1>; >> + qcom,bcm-voters = <&apps_bcm_voter>; >> + }; >> + >> usb_1: usb@a6f8800 { >> compatible = "qcom,sm8250-dwc3", "qcom,dwc3"; >> reg = <0 0x0a6f8800 0 0x400>; >> @@ -2359,6 +2437,10 @@ rpmhpd_opp_turbo_l1: opp10 { >> }; >> }; >> }; >> + >> + apps_bcm_voter: bcm_voter { >> + compatible = "qcom,bcm-voter"; >> + }; >> }; >> }; > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes 2020-07-24 14:36 ` Jonathan Marek @ 2020-07-24 16:55 ` Sibi Sankar 2020-07-28 2:43 ` Jonathan Marek 0 siblings, 1 reply; 14+ messages in thread From: Sibi Sankar @ 2020-07-24 16:55 UTC (permalink / raw) To: Jonathan Marek Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Rob Herring, devicetree, linux-kernel, linux-kernel-owner On 2020-07-24 20:06, Jonathan Marek wrote: > On 7/24/20 10:13 AM, Sibi Sankar wrote: >> Hey Jonathan, >> >> Thanks for the patch! Please use the >> suggested register space definitions >> instead. >> > > Thanks for the suggestions, I was unsure what to use for the sizes. > The reg field is unused by the upstream driver so it is hard to figure > out. > > However, I'm not sure about some of your suggestions for the base > address. For example, for "mc_virt" you suggest 0x0163d000, and I have > 0x09100000. In the downstream dts, "mc_virt-base" is 0x9100000 and > qcom,base-offset for fab_mc_virt is 0. Do you have an explanation for > why your suggestion is so different? AFAIK for providers with virt suffix the register space definition is just an arbitrary choice and doesn't matter. Since mc_virt was just re-using gem_noc address space I suggested we stick to how it was done on sc7180 i.e place it between system_noc and aggre1_noc. > >> On 2020-07-13 21:11, Jonathan Marek wrote: >>> Add the interconnect dts nodes for sm8250. >>> >>> Signed-off-by: Jonathan Marek <jonathan@marek.ca> >>> --- >>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 >>> ++++++++++++++++++++++++++++ >>> 1 file changed, 82 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi >>> b/arch/arm64/boot/dts/qcom/sm8250.dtsi >>> index 636e2196138c..dfc1b7fa7d85 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi >>> @@ -11,6 +11,7 @@ >>> #include <dt-bindings/power/qcom-aoss-qmp.h> >>> #include <dt-bindings/power/qcom-rpmpd.h> >>> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >>> +#include <dt-bindings/interconnect/qcom,sm8250.h> >> >> please fix ^^ sort order >> >>> >>> / { >>> interrupt-parent = <&intc>; >>> @@ -978,6 +979,55 @@ spi13: spi@a94000 { >>> }; >>> }; >>> >>> + config_noc: interconnect@1500000 { >>> + compatible = "qcom,sm8250-config-noc"; >>> + reg = <0 0x01500000 0 0x1000>; >> >> 0x01500000 0xa580 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + ipa_virt: interconnect@1620000 { >>> + compatible = "qcom,sm8250-ipa-virt"; >>> + reg = <0 0x01620000 0 0x1000>; >> >> 0x01e00000 0x1000 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + system_noc: interconnect@1632000 { >>> + compatible = "qcom,sm8250-system-noc"; >>> + reg = <0 0x01632000 0 0x1000>; >> >> 0x01620000 0x1C200 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + aggre1_noc: interconnect@16e2000 { >>> + compatible = "qcom,sm8250-aggre1-noc"; >>> + reg = <0 0x016e2000 0 0x1000>; >> >> 0x016e0000 0x1f180 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + aggre2_noc: interconnect@1703000 { >>> + compatible = "qcom,sm8250-aggre2-noc"; >>> + reg = <0 0x01703000 0 0x1000>; >> >> 0x01700000 0x33000 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + compute_noc: interconnect@1733000 { >>> + compatible = "qcom,sm8250-compute-noc"; >>> + reg = <0 0x01733000 0 0x1000>; >> >> 0x01733000 0xd180 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + mmss_noc: interconnect@174a000 { >>> + compatible = "qcom,sm8250-mmss-noc"; >>> + reg = <0 0x0174a000 0 0x1000>; >> >> 0x01740000 0x1f080 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> ufs_mem_hc: ufshc@1d84000 { >>> compatible = "qcom,sm8250-ufshc", "qcom,ufshc", >>> "jedec,ufs-2.0"; >>> @@ -1364,6 +1414,34 @@ usb_2_ssphy: lane@88eb200 { >>> }; >>> }; >>> >>> + dc_noc: interconnect@90c0000 { >>> + compatible = "qcom,sm8250-dc-noc"; >>> + reg = <0 0x090c0000 0 0x1000>; >> >> 0x090c0000 0x4200 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + mc_virt: interconnect@9100000 { >>> + compatible = "qcom,sm8250-mc-virt"; >>> + reg = <0 0x09100000 0 0x1000>; >> >> 0x0163d000 0x1000 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + gem_noc: interconnect@9121000 { >>> + compatible = "qcom,sm8250-gem-noc"; >>> + reg = <0 0x09121000 0 0x1000>; >> >> 0x09100000 0xb4000 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + npu_noc: interconnect@9990000 { >>> + compatible = "qcom,sm8250-npu-noc"; >>> + reg = <0 0x09990000 0 0x1000>; >> >> 0x09990000 0x1600 >> >>> + #interconnect-cells = <1>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> usb_1: usb@a6f8800 { >>> compatible = "qcom,sm8250-dwc3", "qcom,dwc3"; >>> reg = <0 0x0a6f8800 0 0x400>; >>> @@ -2359,6 +2437,10 @@ rpmhpd_opp_turbo_l1: opp10 { >>> }; >>> }; >>> }; >>> + >>> + apps_bcm_voter: bcm_voter { >>> + compatible = "qcom,bcm-voter"; >>> + }; >>> }; >>> }; >> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes 2020-07-24 16:55 ` Sibi Sankar @ 2020-07-28 2:43 ` Jonathan Marek 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Marek @ 2020-07-28 2:43 UTC (permalink / raw) To: Sibi Sankar Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Rob Herring, devicetree, linux-kernel, linux-kernel-owner On 7/24/20 12:55 PM, Sibi Sankar wrote: > On 2020-07-24 20:06, Jonathan Marek wrote: >> On 7/24/20 10:13 AM, Sibi Sankar wrote: >>> Hey Jonathan, >>> >>> Thanks for the patch! Please use the >>> suggested register space definitions >>> instead. >>> >> >> Thanks for the suggestions, I was unsure what to use for the sizes. >> The reg field is unused by the upstream driver so it is hard to figure >> out. >> >> However, I'm not sure about some of your suggestions for the base >> address. For example, for "mc_virt" you suggest 0x0163d000, and I have >> 0x09100000. In the downstream dts, "mc_virt-base" is 0x9100000 and >> qcom,base-offset for fab_mc_virt is 0. Do you have an explanation for >> why your suggestion is so different? > > AFAIK for providers with virt suffix the > register space definition is just an > arbitrary choice and doesn't matter. > Since mc_virt was just re-using gem_noc > address space I suggested we stick to > how it was done on sc7180 i.e place it > between system_noc and aggre1_noc. > I sent a v3 with most of your suggestions applied as-is, except for: - sm8150: aggre2_noc, reduced size to 0x20000 to avoid overlap with compute_noc region - sm8250: compute_noc, reduced size to 0xa180 to avoid overlap with mmss_noc region (could have been 0xd000, but 0xa180 makes it match the region in the downstream dts, so seemed more likely to be correct) I did notice other inconsistencies, but since this is unused by the upstream driver I don't want to think about it too much.. >> >>> On 2020-07-13 21:11, Jonathan Marek wrote: >>>> Add the interconnect dts nodes for sm8250. >>>> >>>> Signed-off-by: Jonathan Marek <jonathan@marek.ca> >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 ++++++++++++++++++++++++++++ >>>> 1 file changed, 82 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi >>>> b/arch/arm64/boot/dts/qcom/sm8250.dtsi >>>> index 636e2196138c..dfc1b7fa7d85 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi >>>> @@ -11,6 +11,7 @@ >>>> #include <dt-bindings/power/qcom-aoss-qmp.h> >>>> #include <dt-bindings/power/qcom-rpmpd.h> >>>> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >>>> +#include <dt-bindings/interconnect/qcom,sm8250.h> >>> >>> please fix ^^ sort order >>> >>>> >>>> / { >>>> interrupt-parent = <&intc>; >>>> @@ -978,6 +979,55 @@ spi13: spi@a94000 { >>>> }; >>>> }; >>>> >>>> + config_noc: interconnect@1500000 { >>>> + compatible = "qcom,sm8250-config-noc"; >>>> + reg = <0 0x01500000 0 0x1000>; >>> >>> 0x01500000 0xa580 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + ipa_virt: interconnect@1620000 { >>>> + compatible = "qcom,sm8250-ipa-virt"; >>>> + reg = <0 0x01620000 0 0x1000>; >>> >>> 0x01e00000 0x1000 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + system_noc: interconnect@1632000 { >>>> + compatible = "qcom,sm8250-system-noc"; >>>> + reg = <0 0x01632000 0 0x1000>; >>> >>> 0x01620000 0x1C200 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + aggre1_noc: interconnect@16e2000 { >>>> + compatible = "qcom,sm8250-aggre1-noc"; >>>> + reg = <0 0x016e2000 0 0x1000>; >>> >>> 0x016e0000 0x1f180 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + aggre2_noc: interconnect@1703000 { >>>> + compatible = "qcom,sm8250-aggre2-noc"; >>>> + reg = <0 0x01703000 0 0x1000>; >>> >>> 0x01700000 0x33000 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + compute_noc: interconnect@1733000 { >>>> + compatible = "qcom,sm8250-compute-noc"; >>>> + reg = <0 0x01733000 0 0x1000>; >>> >>> 0x01733000 0xd180 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + mmss_noc: interconnect@174a000 { >>>> + compatible = "qcom,sm8250-mmss-noc"; >>>> + reg = <0 0x0174a000 0 0x1000>; >>> >>> 0x01740000 0x1f080 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> ufs_mem_hc: ufshc@1d84000 { >>>> compatible = "qcom,sm8250-ufshc", "qcom,ufshc", >>>> "jedec,ufs-2.0"; >>>> @@ -1364,6 +1414,34 @@ usb_2_ssphy: lane@88eb200 { >>>> }; >>>> }; >>>> >>>> + dc_noc: interconnect@90c0000 { >>>> + compatible = "qcom,sm8250-dc-noc"; >>>> + reg = <0 0x090c0000 0 0x1000>; >>> >>> 0x090c0000 0x4200 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + mc_virt: interconnect@9100000 { >>>> + compatible = "qcom,sm8250-mc-virt"; >>>> + reg = <0 0x09100000 0 0x1000>; >>> >>> 0x0163d000 0x1000 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + gem_noc: interconnect@9121000 { >>>> + compatible = "qcom,sm8250-gem-noc"; >>>> + reg = <0 0x09121000 0 0x1000>; >>> >>> 0x09100000 0xb4000 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> + npu_noc: interconnect@9990000 { >>>> + compatible = "qcom,sm8250-npu-noc"; >>>> + reg = <0 0x09990000 0 0x1000>; >>> >>> 0x09990000 0x1600 >>> >>>> + #interconnect-cells = <1>; >>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>> + }; >>>> + >>>> usb_1: usb@a6f8800 { >>>> compatible = "qcom,sm8250-dwc3", "qcom,dwc3"; >>>> reg = <0 0x0a6f8800 0 0x400>; >>>> @@ -2359,6 +2437,10 @@ rpmhpd_opp_turbo_l1: opp10 { >>>> }; >>>> }; >>>> }; >>>> + >>>> + apps_bcm_voter: bcm_voter { >>>> + compatible = "qcom,bcm-voter"; >>>> + }; >>>> }; >>>> }; >>> > ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-07-28 2:44 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-07-13 15:41 [PATCH v2 0/7] Add SM8150 and SM8250 interconnect drivers Jonathan Marek 2020-07-13 15:41 ` [PATCH v2 1/7] dt-bindings: interconnect: single yaml file for RPMh " Jonathan Marek 2020-07-14 17:23 ` Rob Herring 2020-07-13 15:41 ` [PATCH v2 2/7] dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings Jonathan Marek 2020-07-16 19:22 ` Rob Herring 2020-07-13 15:41 ` [PATCH v2 3/7] dt-bindings: interconnect: Add Qualcomm SM8250 " Jonathan Marek 2020-07-16 19:22 ` Rob Herring 2020-07-13 15:41 ` [PATCH v2 6/7] arm64: dts: qcom: sm8150: add interconnect nodes Jonathan Marek 2020-07-24 14:13 ` Sibi Sankar 2020-07-13 15:41 ` [PATCH v2 7/7] arm64: dts: qcom: sm8250: " Jonathan Marek 2020-07-24 14:13 ` Sibi Sankar 2020-07-24 14:36 ` Jonathan Marek 2020-07-24 16:55 ` Sibi Sankar 2020-07-28 2:43 ` Jonathan Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).