From: Mark Brown <broonie@kernel.org>
To: Neo Chang <YLCHANG2@nuvoton.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, robh@kernel.org,
krzk+dt@kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
neo.chang70@gmail.com, kchsu0@nuvoton.com, sjlin0@nuvoton.com
Subject: Re: [PATCH v3] ASoC: codecs: nau8360: Block DSP path selection when firmware load fails
Date: Tue, 8 Sep 2026 14:31:16 +0100 [thread overview]
Message-ID: <c068db2b-e21c-4891-847d-01a6a201e33e@sirena.org.uk> (raw)
In-Reply-To: <20260908030342.222655-1-YLCHANG2@nuvoton.com>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
On Tue, Sep 08, 2026 at 11:03:42AM +0800, Neo Chang wrote:
> Block the DSP path selection if the firmware fails to load to prevent
> invalid routing states.
> +++ b/sound/soc/codecs/nau8360.c
> @@ -719,6 +719,11 @@ static int nau8360_dac_mux_put_enum(struct snd_kcontrol *kcontrol,
> return ret;
> }
>
> + if (item[0] == NAU8360_DAC_SRC_DSP && !nau8360->load_fw_done) {
> + dev_warn(nau8360->dev, "Cannot enable DSP: Firmware not ready or disabled\n");
> + return ret;
ret is 0 at this point so this will look like success, you need to
return an error code (-EBUSY might be good). I'd also use a _ratelimit
print here to avoid spamming the logs.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-09-08 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 3:03 [PATCH v3] ASoC: codecs: nau8360: Block DSP path selection when firmware load fails Neo Chang
2026-09-08 3:17 ` sashiko-bot
2026-09-08 13:31 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c068db2b-e21c-4891-847d-01a6a201e33e@sirena.org.uk \
--to=broonie@kernel.org \
--cc=YLCHANG2@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=kchsu0@nuvoton.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=neo.chang70@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sjlin0@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox