From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Keguang Zhang <keguang.zhang@gmail.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH V2 1/3] dt-bindings: clock: Add Loongson-1 clock
Date: Fri, 10 Feb 2023 12:38:09 +0100 [thread overview]
Message-ID: <c06f5b63-2667-2a01-fa1f-7efe4c6f3867@linaro.org> (raw)
In-Reply-To: <20230209132614.1079198-2-keguang.zhang@gmail.com>
On 09/02/2023 14:26, Keguang Zhang wrote:
> Add devicetree binding document and related header file
> for the Loongson-1 clock.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> V1 -> V2: Change to one clock controller
> Add clock-related dt-binding header file
> Fix the warning of dt_binding_check
> ---
Thank you for your patch. There is something to discuss/improve.
> diff --git a/include/dt-bindings/clock/loongson,ls1x-clk.h b/include/dt-bindings/clock/loongson,ls1x-clk.h
> new file mode 100644
> index 000000000000..579552c5f14b
> --- /dev/null
> +++ b/include/dt-bindings/clock/loongson,ls1x-clk.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
Same license as binding please.
> +/*
> + * Loongson-1 clock tree IDs
> + *
> + * Copyright (C) 2023 Keguang Zhang <keguang.zhang@gmail.com>
> + */
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-10 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 13:26 [PATCH V2 0/3] Devicetree support for Loongson-1 clock Keguang Zhang
2023-02-09 13:26 ` [PATCH V2 1/3] dt-bindings: clock: Add " Keguang Zhang
2023-02-10 11:38 ` Krzysztof Kozlowski [this message]
2023-02-09 13:26 ` [PATCH V2 2/3] clk: loongson1: Remove the outdated driver Keguang Zhang
2023-02-09 13:26 ` [PATCH V2 3/3] clk: loongson1: Re-implement the clock driver Keguang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c06f5b63-2667-2a01-fa1f-7efe4c6f3867@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=keguang.zhang@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).