From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9DCAC6379F for ; Fri, 10 Feb 2023 11:38:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232114AbjBJLiQ (ORCPT ); Fri, 10 Feb 2023 06:38:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbjBJLiP (ORCPT ); Fri, 10 Feb 2023 06:38:15 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F8D57164E for ; Fri, 10 Feb 2023 03:38:13 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so6070827wmb.2 for ; Fri, 10 Feb 2023 03:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I3AfScb5eZBvuleQTKe5gvMdffqFNjAeOX6lI523hQE=; b=asmkAOnSBKcu3XreoHNmILuUKNc/O5vXcAx16D9bRMvAcqlhx5cTBBNm0tKvQ3rgex f0Bq51Uwmmx0s2dB9RyO9NLeHrxNYWJEK76BNaNLyDrKXfcj4Ynfyrh3Ub0+64672wtg c6s1fETV3nNjhgs/ccwSbzsIRS2caC4jhGyMb+VDouBbN6h+WBm991X8M95leA0HmRmr Omwu2BxnUDZhaXzWKfIh5jIODy5gV1lacSU9icmnYnaq0KryF4K0Npk9zx7F4QCMME25 Mu5itB1MRcVrMLpHB448z1asKPcl6ZIdJ5ZtaZZ00JLN/ldWkhxpEUMBefWWL5lHbXtO r0qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I3AfScb5eZBvuleQTKe5gvMdffqFNjAeOX6lI523hQE=; b=qNwSENri0EQT8VXRSr/wi1p7b7EW2pS7CaL9d5/2vQeDITtMaImVD1+O2jZTAcoDc8 RHCsEul03Ex4cqW0vYOxgwckr5pB/hrNhinKTKqukmJdCZomUD2Cg1vVstJtCKnUvqdA TOb4OTOrktxuhPOtf6ETN/hWpzVtZ3+WgC6GonW1u7nvKmBIFhgE4ZU+AEcfG1umej9J wb4q5M+IA+XUrm/p+GxlgONjX9k8HbqRC7kEy2eNnuzX2NkrsMtpuQGmEw4LypSbVv5u k5pompT5XlwhcIK+tCI+8ww9j/OfSvxk6DZZAIjUElhtmPHx8NPms8xiZdASC7AJc13Y aWfQ== X-Gm-Message-State: AO0yUKUxNnLbkRI+uG6H7VHCUityW2V4FPvW8UOBztkTU9Fg0gJ7xyUP JMMxi6PioOMXiN/LRDqd0XLmng== X-Google-Smtp-Source: AK7set+uEknYw9udTW1kl3Txp9GCn0dwLcAHml7YyNdx8cs9cBLJqKM2WD3mlV1dCTNf8dW4llZy/A== X-Received: by 2002:a05:600c:ccd:b0:3df:e1d8:cd8f with SMTP id fk13-20020a05600c0ccd00b003dfe1d8cd8fmr9580566wmb.6.1676029092269; Fri, 10 Feb 2023 03:38:12 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c42c600b003df245cd853sm4408871wme.44.2023.02.10.03.38.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 03:38:11 -0800 (PST) Message-ID: Date: Fri, 10 Feb 2023 12:38:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH V2 1/3] dt-bindings: clock: Add Loongson-1 clock Content-Language: en-US To: Keguang Zhang , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski References: <20230209132614.1079198-1-keguang.zhang@gmail.com> <20230209132614.1079198-2-keguang.zhang@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230209132614.1079198-2-keguang.zhang@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/02/2023 14:26, Keguang Zhang wrote: > Add devicetree binding document and related header file > for the Loongson-1 clock. > > Signed-off-by: Keguang Zhang > --- > V1 -> V2: Change to one clock controller > Add clock-related dt-binding header file > Fix the warning of dt_binding_check > --- Thank you for your patch. There is something to discuss/improve. > diff --git a/include/dt-bindings/clock/loongson,ls1x-clk.h b/include/dt-bindings/clock/loongson,ls1x-clk.h > new file mode 100644 > index 000000000000..579552c5f14b > --- /dev/null > +++ b/include/dt-bindings/clock/loongson,ls1x-clk.h > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ Same license as binding please. > +/* > + * Loongson-1 clock tree IDs > + * > + * Copyright (C) 2023 Keguang Zhang > + */ Best regards, Krzysztof