From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B75503090C6; Sun, 24 May 2026 18:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779647006; cv=none; b=BSky8pXnvrSPsupqH3ImvncBPtqz/Izpartmqj8sh8bQmsS6FbhkKLaeUAO1z3Y7eph+SxOr9Q3Wgj0o/SxIDld1H9FnoTI/3c9Xi4ZH1KqnfBVsK8VQcXFnpqs5g+dkoM6YY/I03yJpwi61C823MxXLbC4b1Kb9DLgHPZ1CNcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779647006; c=relaxed/simple; bh=61vma2EcoifwcyBr+lIjzTa5nYyd/rnvIJlytmPzj9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ho1QFg7cT2A2++ofVvWLPN6yFGuMgpUxteVqFZmNLHdLwXZK8z95E9XAddAw29yqtKUi1gfdZNlV6jSmU0sDZIaRn7FDXu5Ulq4sO1mo3+COsAUJ2E6F0h9W3chO+Qm1DVLKQxubKreh4N5S9cyCNWzaENNRiSRn/4tHcfC0B5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j7h+M6ok; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j7h+M6ok" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A03C1F000E9; Sun, 24 May 2026 18:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779647005; bh=cdRFPHuGugLSaiWwmHoaI+iYoeLkYCWY9qj5dYQBZFc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=j7h+M6okoB+43HaV6uDqKk0O9HpoI6lBpCY8f0taGPJP1ZxMNQml0q2bz6kvHnkmn r2wBBRyIZYPpK+1S+NglbhtC4XmdukK2PHPWKBKXhRr2uFFfNmDS9IIIWlMNc9rkux 8yWou7gsaWpj/rUOFUJlefxwTIw3mXYTXJS4CHXyeC4jAq/peb7MpSAg7+EJqpb152 LfjzR/UmBcDPAQRnWQF/xpTG9ktl79JT9i2/1z1eupwDrpIsAEsj78w1FY0G5hWwr/ iaDCO8JAu5bXXncDCaQgKoDHztdDlETyrYs90c/wpzA1KaoGEISLyrN3CzeYuSw/1T ntX8raJ/UoQfg== Message-ID: Date: Sun, 24 May 2026 20:23:20 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: Move board nodes to common DTSI To: Pankaj Patil , Dmitry Baryshkov , Gopikrishna Garmidi Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sibi.sankar@oss.qualcomm.com, rajendra.nayak@oss.qualcomm.com References: <20260326-glymur-mahua-common-nodes-v1-1-12bb26920ea4@oss.qualcomm.com> <03996c07-f9f3-4586-96ae-075927da2577@kernel.org> <83c78333-4db9-4943-b90f-164981bb68d8@oss.qualcomm.com> <05c377ab-33ef-44e7-8708-575647de088e@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <05c377ab-33ef-44e7-8708-575647de088e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/05/2026 11:14, Pankaj Patil wrote: > On 3/29/2026 4:27 PM, Dmitry Baryshkov wrote: >> On Fri, Mar 27, 2026 at 06:16:59PM +0530, Gopikrishna Garmidi wrote: >>> >>> >>> On 3/26/2026 7:55 PM, Krzysztof Kozlowski wrote: >>>> On 26/03/2026 15:21, Gopikrishna Garmidi wrote: >>>>> The display, peripherals (touchpad/touchscreen/keypad), usb and their >>>>> dependent device nodes are common to both Glymur and Mahua CRDs, >>>>> so move them from glymur-crd.dts to glymur-crd.dtsi to enable code >>>>> reuse. >>>>> >>>> >>>> Same questions as for earlier tries (why this has to be repeated?), e.g. >>>> x1-crd: Please describe here what is the actual common hardware. In >>>> terms of physical hardware, not what you want to share. >>>> >>> >>> Hi krzysztof, >>> >>> Thanks for the review, >>> >>> Will update the commit message in the next re-spin. >> >> Before you respin, you can actually respond to the question. Do Glymur >> and Mahua CRD actually share those devices (in case of USB that would >> mean having the same baseboard with different SoCs being wired) or is it >> just "oh, this looks similar enough, let's create a common file". >> > > Hello, > Yes we've verified across glymur crd and mahua crd schematics, the regulator supply > and data lines are common across both targets for the nodes in the patch That's not an answer to the question. Or rather you just confirmed - they are similar, so let's create a common file. That's not a valid reason. Don't create common parts just because a few nodes are the same. Best regards, Krzysztof