From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99716C432BE for ; Thu, 5 Aug 2021 09:17:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A48D610A8 for ; Thu, 5 Aug 2021 09:17:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239544AbhHEJRm (ORCPT ); Thu, 5 Aug 2021 05:17:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239416AbhHEJRl (ORCPT ); Thu, 5 Aug 2021 05:17:41 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20788C061765 for ; Thu, 5 Aug 2021 02:17:27 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id c9so5558600wri.8 for ; Thu, 05 Aug 2021 02:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fzThuEjTrYhg1qOmjws2RuEPYFGd40kLfkIG1ZhFyqU=; b=H9MbDpONaMfqEQsHonMKiW0qkmxYLMwS0uRUZg6wtXAdVU5M/dJLOsFiJe5OER+G1p IFQupaw/WaJxRHlv064WK/6b2o0QsZxtImi+8S22GS74wVbd37V2WeDQfMiWJTJlw+wJ oopRPsr0AIOCDAPlEj9HWzlN8FaRlH5HJI5fDhhURhHhxQYvTYoQVCzpIRS+UhF7Vdcj /I1SZFFnYCwuv2tbAaJ7RZ6coY/XmZ+vSq8Kfsjaddy5+fmq2x6h8Mg1DZL1TY8EaMOR QTypTYgGMOvWudH0T1SP1QaR3ZNYKrsTA1NUmQy+GNoNEzpLNMkofeSPXk6EFmZOHrNG h8Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fzThuEjTrYhg1qOmjws2RuEPYFGd40kLfkIG1ZhFyqU=; b=UfkPxQdREazCz680icEW3pqVEpeHNds7Rb8zU1mMcaJz+3tb13Gl4g7QJHAiLn4hU5 EPzwwoeqSr7KOYA1bMBg+upZxXAfH2+uxabhI3iEC3dpbD19EJpKCYd40OegcYWA24mr BHEZ5WFkbEcAhTKbxC6B//sow0pHaAxg/OxBaSqnHtZj+j9p9ehJNzx7hOza3DVuOjHW qTiGufPNGiU9gxcZqeKYKrsMiO/3PTpJTNnwq5Qbjge+eVYV6FPRokvi7fHBzx2160Gu vJQ3DpHN/AX+fjyQQBHrGlXKxtJybD2UrpfBlGoli5/WLFpmFQEPzxpWk63W8tbPJX64 5w3w== X-Gm-Message-State: AOAM5313xxxmjfbhAovKWFbq9JAilMQekeLEDCCuMFjTlUbazAyj/bY9 oVERGrxkvLw0AzuMwK/Mztw56Q== X-Google-Smtp-Source: ABdhPJxWILAsnwsT+9R3gsOKWSUR18ggJyUkK0YIVKtH9k/P3tlswSZoHeyJCACfIZYqUmV1QJxxTw== X-Received: by 2002:adf:d20c:: with SMTP id j12mr4026181wrh.74.1628155045815; Thu, 05 Aug 2021 02:17:25 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id d16sm5400324wrx.76.2021.08.05.02.17.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 02:17:25 -0700 (PDT) Subject: Re: [PATCH v3 12/20] ASoC: dt-bindings: q6dsp-clocks: add q6prm clocks compatible To: Mark Brown Cc: bjorn.andersson@linaro.org, robh@kernel.org, plai@codeaurora.org, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, lgirdwood@gmail.com, bgoswami@codeaurora.org References: <20210803125411.28066-1-srinivas.kandagatla@linaro.org> <20210803125411.28066-13-srinivas.kandagatla@linaro.org> <20210804180249.GH26252@sirena.org.uk> From: Srinivas Kandagatla Message-ID: Date: Thu, 5 Aug 2021 10:17:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210804180249.GH26252@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks Mark for the review, On 04/08/2021 19:02, Mark Brown wrote: > On Tue, Aug 03, 2021 at 01:54:03PM +0100, Srinivas Kandagatla wrote: > >> + enum: >> + - qcom,q6afe-clocks >> + - qcom,q6prm-clocks > > Again, what do these mean? One of the goals with DT bindings > documentation is to be able to relate hardware to bindings. > Old Elite QDSP framework has service called "Audio Front End" aka q6afe which is responsible for managing the LPASS Audio clocks. So We endup with "qcom,q6afe-clocks" in the past to represent this. With New AudioReach framework this functionality is now managed by "Proxy Resource Manager" aka q6prm. I will rename "qcom,q6prm-clocks" to "qcom,q6prm-lpass-clocks" to be more explicit about the hardware LPASS (Low Power Audio Sub System)IP here. --srini