From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9369235DA7B for ; Wed, 16 Sep 2026 14:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789570589; cv=none; b=QRIXv3I/Wht1FqSpscGJxqYX98pRLEBaQdj0eplMC02Wn5z6SfTdZygzIKUIbiqZxxfF9CYEEUOeTsaF1X23+PppHFAUlIDKn/R/lMaGCi1/xFToKuizkFwP/KhWMCIBLRZDItlYndBySb6yngudCkTJrYYuNbs4SsIy7IBzgaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789570589; c=relaxed/simple; bh=w5hmfYQd5qS6jmp5if4MTfMkG4gKJAqCpM+ctVlrJx8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WRMGE5DH2m8DblVR0BOAOYSXquYVRGZp7U7CYAyV6Q74sLhYgWXlkATeRktiYXDzB7udRvz+LLTsNIb0OcovTMwqjoena2DNHj+nfGDe7Z9QOq1xtuAggSssoHlUOzvuh62JP3UUfjerqGq+1aVbjApkVPYDf6GbDJgasjWiIcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gpsB+0pX; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gpsB+0pX" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2d9004a1ac0so7645185ad.3 for ; Wed, 16 Sep 2026 07:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789570587; x=1790175387; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=fOtt4epAjEgetEW4Rf7UpxEkjN1u8RJ270fhKCbRhRQ=; b=gpsB+0pXhV5Fpk8oz8ZAIm1e0F4oG/SJmYb8KutcgEoeU5P5gRBEKrOTTOmuVSszWx /sgU9r4nBZP6Ne3OZjTW0ZJNsMaGgR3HYblsJ8JyO9V/bcATeox1PrPLWL6XihGJ12Xo U0gemKPW3fIh5pvfnbrYk9orM+IzDKn3hN/2A8Luoc73QZpAITuQ/U+Lyp6AghAt13P9 323JOe8rt8BB0Q+5IpCDQnnVOJFFN83tHNSt4D2xayA7VQCOxZOiMEpijOypzwSjrMRu CV0YVG+9j8Y507nBIm4Hp1LmqNh9sKlMnulMvMb1wWKZlzj0Bhg/MU8TkUgHnkhDvyYw YQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789570587; x=1790175387; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fOtt4epAjEgetEW4Rf7UpxEkjN1u8RJ270fhKCbRhRQ=; b=a28cTiLZi8qGarwlc/EGq39DbLmq1EAR6XT+zNs99l4ZDdXzU1aqYOtzOjQN8PwVgC lHgBIgRqbkQ4n/usYcWj7/AtWTkdss1SUt0EDYN38I9kETmdvApYBd4HimvveAEyPco8 tYm7Cdud0PYVOPCN+fASCwwDpAkWXIwfBHChmEm3WKkVWP+RcYMTv5bxEfAAdtdWSExX URjm/IAYuxWzB+Dp6YQW2Par2PzGG1NNa9+zJzVsnqJC+EUzNpSd0vihBPGf4yFIolZe 69Rbp1BrRXg9sl3hd9P3Qj/1tjgdiLDX2zIw1kJ2bMoDtI7i2xTFgL0I3DojxRfVpoj4 OTqQ== X-Forwarded-Encrypted: i=1; AKwUvBxxXkNeYdoxYIvUWchwDXU/s0U53qjSQx4/U2tMsd+KHR+cHwfy+Dqy4ASzZhRxMAYYw4yblue7Hk/m@vger.kernel.org X-Gm-Message-State: AFuF++mxNKILWyI3JrcSg2HAU48sVKK2DKGNCGGWlsxkhNVnp0cLUB6b JW/xeKaeZ1JfhsM5x478uMKVdLvXf2mKfG/uDM2SBszPAgZJx+LEuxaQ X-Gm-Gg: AYBFou1hofrVIPf6naxIg4UvNsLFSDLZk6o05W7sxwDirrwVcb86jiqnHrbLk3zeXlW u/0r7NeLCCJqJHBIMI8A/NDq0qeggxZbNwuHzOMKsY+mB0RU8bWv4vVRW+HZxC3f8UhUDQUMywB sjIp8eQtSDGaXGRLEf/tA2Y6LA0/7F/QtElWC99FAEbll9GeF7Qa4iDVyHOXM2nUDDPr1lsmYaU v9kQaC66qBBuVA9AJ/outLPvF0j3Z8ab+jrJjGLmDe4/aA5PK5rjiyOOVEl85UIMFfgyJX32IQJ p0qNccyugV8y/xZoc0izrcICRkE76KT0hYczfmVIrRTkEgZS3DcHT3As/bRaxUkBe86+O9kWTTY M9NnMf9yU82GDT2fyp1pvQdHIRqt8fGRiRgLKQYI8UwQPAMSDFinySM7laL/Joex7xoVw9i35p0 +bReJ+uXqUGmRsZ0jBRksNw2vpeuUmUDMfihKWmSWg/NWEDg82nv4wNPDW+u4yLU3zIFhqRTsST xbGs/hKoRwS X-Received: by 2002:a17:902:d588:b0:2dd:7593:8634 with SMTP id d9443c01a7336-2dd8e412565mr65993445ad.13.1789570586585; Wed, 16 Sep 2026 07:56:26 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2dd89d8fe00sm13413325ad.12.2026.09.16.07.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 07:56:26 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 16 Sep 2026 07:56:25 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: Re: [PATCH v2 1/3] hwmon: (pmbus/tps53679) Fix TPS53676 phase page decoding Message-ID: References: <20260915164823.160977-1-sanman.pradhan@hpe.com> <20260915164823.160977-2-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260915164823.160977-2-sanman.pradhan@hpe.com> On Tue, Sep 15, 2026 at 04:48:35PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > tps53676_identify() reads the USER_DATA_03 phase configuration to count > the phases assigned to each channel and derive the number of PMBus pages. > In each 16-bit phase descriptor the channel (PAGE) is encoded in bit 4 and > the firing order in bits 3:0, but the code tested bit 3 (0x08), which is > part of the firing-order field. > > TPS53676 supports up to seven phases, so firing-order bit 3 is never set. > As a result the existing test classifies every enabled phase as channel A. > On a dual-channel configuration the phases assigned to channel B are > therefore miscounted as channel A and page 1 is not exposed. > > Test the PAGE field (bit 4) instead. > > Fixes: cb3d37b59012 ("hwmon: (pmbus/tps53679) Add support for TI TPS53676") > Cc: stable@vger.kernel.org > Signed-off-by: Sanman Pradhan Applied. I'll fix the other problem separately. Thanks, Guenter