Re: [PATCH v2 2/4] dt-bindings: power: reset: atmel,at91sam9260-shdwc: convert to yaml

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 24/05/2023 14:35, Claudiu Beznea wrote:
> Convert Atmel shutdown controller to YAML.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---


> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - atmel,at91sam9260-shdwc
> +              - atmel,at91sam9rl-shdwc
> +    then:
> +      properties:
> +        atmel,wakeup-rtt-timer:
> +          description: enable real-time timer wake-up
> +          type: boolean

No, don't define properties in allOf.

> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - atmel,at91sam9rl-shdwc
> +              - atmel,at91sam9x5-shdwc
> +    then:
> +      properties:
> +        atmel,wakeup-rtc-timer:
> +          description: enable real-time clock wake-up
> +          type: boolean

Same problem.

> +
> +unevaluatedProperties: false

This should be additionalProperties: false.
> +
> +examples:
> +  - |
> +    shdwc: poweroff@fffffd10 {
> +        compatible = "atmel,at91sam9260-shdwc";
> +        reg = <0xfffffd10 0x10>;
> +        clocks = <&clk32k>;
> +    };
> +
> +...

Best regards,
Krzysztof