From: Frank Rowand <frowand.list@gmail.com>
To: Daniel Walker <danielwa@cisco.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>,
xe-linux-external@cisco.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver: of: overlay: demote message to warning
Date: Thu, 8 Sep 2022 12:55:39 -0500 [thread overview]
Message-ID: <c0c66918-f55e-83e4-edea-b2d32fdb27a7@gmail.com> (raw)
In-Reply-To: <20220908003510.GE4320@zorba>
On 9/7/22 19:35, Daniel Walker wrote:
> On Wed, Sep 07, 2022 at 06:54:02PM -0500, Frank Rowand wrote:
>> On 9/7/22 18:07, Daniel Walker wrote:
>>> This warning message shows by default on the vast majority of overlays
>>> applied. Despite the text identifying this as a warning it is marked
>>> with the loglevel for error. At Cisco we filter the loglevels to only
>>> show error messages. We end up seeing this message but it's not really
>>> an error.
>>>
>>> For this reason it makes sense to demote the message to the warning
>>> loglevel.
>>>
>>> Cc: xe-linux-external@cisco.com
>>> Signed-off-by: Daniel Walker <danielwa@cisco.com>
>>> ---
>>> drivers/of/overlay.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
>>> index bd8ff4df723d..4ae276ed9a65 100644
>>> --- a/drivers/of/overlay.c
>>> +++ b/drivers/of/overlay.c
>>> @@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
>>> }
>>>
>>> if (!of_node_check_flag(target->np, OF_OVERLAY))
>>> - pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
>>> + pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
>>> target->np, new_prop->name);
>>>
>>> if (ret) {
>>
>> NACK
>>
>> This is showing a real problem with the overlay.
>
> What's the real problem ?
>
> Daniel
A memory leak when the overlay is removed.
I'll send a patch to update the overlay file in Documumentation/devicetree/ to provide
more information about this. If you don't see a patch by tomorrow, feel free to
ping me.
-Frank
next prev parent reply other threads:[~2022-09-08 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 23:07 [PATCH] driver: of: overlay: demote message to warning Daniel Walker
2022-09-07 23:54 ` Frank Rowand
2022-09-08 0:35 ` Daniel Walker
2022-09-08 17:55 ` Frank Rowand [this message]
2022-09-12 6:45 ` Frank Rowand
2022-09-12 17:05 ` Daniel Walker
2022-09-12 20:32 ` Frank Rowand
2022-09-13 0:51 ` Daniel Walker
2022-09-16 22:47 ` Frank Rowand
2022-09-16 22:56 ` Daniel Walker
2022-09-17 2:47 ` Frank Rowand
2022-09-17 3:26 ` Daniel Walker
2022-09-26 22:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0c66918-f55e-83e4-edea-b2d32fdb27a7@gmail.com \
--to=frowand.list@gmail.com \
--cc=danielwa@cisco.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).