Devicetree
 help / color / mirror / Atom feed
From: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
To: Alim Akhtar <alim.akhtar@samsung.com>,
	krzk@kernel.org, peter.griffin@linaro.org, robh@kernel.org,
	conor+dt@kernel.org, linusw@kernel.org
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	hajun.sung@samsung.com
Subject: Re: [PATCH v3 1/6] dt-binding: ARM: samsung: Add Samsung Exynos8855
Date: Mon, 6 Jul 2026 10:57:24 +0300	[thread overview]
Message-ID: <c0e3a874-0d9b-4fc7-bfe9-23ad9d339918@gmail.com> (raw)
In-Reply-To: <08ba01dd0cf9$cbe0a4b0$63a1ee10$@samsung.com>

On 7/6/26 6:44 AM, Alim Akhtar wrote:
> Hi Ivaylo,
> Thanks for your review. 

No problem :D

> 
>> -----Original Message-----
>> From: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
>> Sent: Monday, July 6, 2026 4:11 AM
>> To: Alim Akhtar <alim.akhtar@samsung.com>; krzk@kernel.org;
>> peter.griffin@linaro.org; robh@kernel.org; conor+dt@kernel.org;
>> linusw@kernel.org
>> Cc: linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-gpio@vger.kernel.org;
>> hajun.sung@samsung.com
>> Subject: Re: [PATCH v3 1/6] dt-binding: ARM: samsung: Add Samsung
>> Exynos8855
>>
>> On 6/27/26 20:12, Alim Akhtar wrote:
>>> Add Samsung Exynos8855 smdk board to documentation
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> ---
>>>  .../devicetree/bindings/arm/samsung/samsung-boards.yaml     | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
>>> b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
>>> index 753b3ba1b607..273464400477 100644
>>> ---
>>> a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-
>> boards.yam
>>> +++ l
>>> @@ -235,6 +235,12 @@ properties:
>>>                - winlink,e850-96                 # WinLink E850-96
>>>            - const: samsung,exynos850
>>>
>>> +      - description: Exynos8855 based boards
>>> +        items:
>>> +          - enum:
>>> +              - samsung,exynos8855-smdk         # Samsung SMDK
>>> +          - const: samsung,exynos8855
>>
>> Is there any particular reason for using "exynos8855" rather than the
>> commercial name - exynos1580? We've already established using the latter
>> naming scheme as a convention (e.g. exynos3830 -> exynos850, exynos9830 ->
>> exynos990) rather than the development model numbers, so I don't think
>> breaking that will help anyone with the already painful model number confusion.
>>
> The reason for using Exynos8855 is that it comes from the chip-id register, which is RO register.
> And in my opinion it has to be chip-id, maintaining two names is confusing (as you also mentioned).

I see your point but I'm not sure whether exynos-based platforms like tensors
will follow this. Afaik GS101's development name is e9845. So there likely will
still be some deviation.

It's not really a fatal thing, just a nit imo because all bindings will have
to follow that for the upstreamed SoC, so non-revertable. But if maintainers
are okay with this, I'm happy to start using chip-id names for future contributions
too.

Best regards,
Ivaylo

> Yes, there were couple of deviation but let's come back to the "original" convention (which is to use chip-id).
> 
> @ Krzysztof, Peter 
> Any input on this? 
> 
>> Best regards,
>> Ivaylo
>>
>>> +
>>>        - description: Exynos8895 based boards
>>>          items:
>>>            - enum:
> 
> 


  reply	other threads:[~2026-07-06  7:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260627165402epcas5p4481839961bdedebfa4d96a3517edaf2b@epcas5p4.samsung.com>
2026-06-27 17:12 ` [PATCH v3 0/6] Add minimal Exynos8855 SoC support Alim Akhtar
2026-06-27 17:12   ` [PATCH v3 1/6] dt-binding: ARM: samsung: Add Samsung Exynos8855 Alim Akhtar
2026-07-05 22:40     ` Ivaylo Ivanov
2026-07-06  3:44       ` Alim Akhtar
2026-07-06  7:57         ` Ivaylo Ivanov [this message]
2026-07-06  9:29           ` Alim Akhtar
2026-07-06 16:05         ` Krzysztof Kozlowski
2026-06-27 17:12   ` [PATCH v3 2/6] dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible Alim Akhtar
2026-06-27 17:12   ` [PATCH v3 3/6] pinctrl: samsung: Add Exynos8855 pinctrl configuration Alim Akhtar
2026-06-27 17:04     ` sashiko-bot
2026-06-27 17:12   ` [PATCH v3 4/6] dt-bindings: pinctrl: samsung: Add exynos8855-wakeup-eint compatible Alim Akhtar
2026-06-27 17:05     ` sashiko-bot
2026-06-27 17:12   ` [PATCH v3 5/6] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk Alim Akhtar
2026-06-27 17:06     ` sashiko-bot
2026-06-27 17:12   ` [PATCH v3 6/6] MAINTAINERS: Add entry for Samsung Exynos8855 SoC Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0e3a874-0d9b-4fc7-bfe9-23ad9d339918@gmail.com \
    --to=ivo.ivanov.ivanov1@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hajun.sung@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox