* [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries
@ 2022-12-19 19:42 Hugo Villeneuve
2022-12-19 22:03 ` Rob Herring
2022-12-20 10:16 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Hugo Villeneuve @ 2022-12-19 19:42 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring,
Krzysztof Kozlowski
Cc: hugo, bruno.thomsen, Hugo Villeneuve, linux-rtc, devicetree,
linux-kernel
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
contains:
nxp,pcf2129
ncp,pca2129
Add these missing entries.
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
index cde7b1675ead..00dbae7e23c2 100644
--- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
@@ -14,7 +14,10 @@ maintainers:
properties:
compatible:
- const: nxp,pcf2127
+ enum:
+ - nxp,pcf2127
+ - nxp,pcf2129
+ - ncp,pca2129
reg:
maxItems: 1
base-commit: e88f319a2546fd7772c726bf3a82a23b0859ddeb
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries
2022-12-19 19:42 [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries Hugo Villeneuve
@ 2022-12-19 22:03 ` Rob Herring
2022-12-19 22:52 ` Hugo Villeneuve
2022-12-20 10:16 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-12-19 22:03 UTC (permalink / raw)
To: Hugo Villeneuve
Cc: Alessandro Zummo, Alexandre Belloni, Krzysztof Kozlowski,
bruno.thomsen, Hugo Villeneuve, linux-rtc, devicetree,
linux-kernel
On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
> contains:
> nxp,pcf2129
> ncp,pca2129
>
> Add these missing entries.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..00dbae7e23c2 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,10 @@ maintainers:
>
> properties:
> compatible:
> - const: nxp,pcf2127
> + enum:
> + - nxp,pcf2127
> + - nxp,pcf2129
> + - ncp,pca2129
Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml.
Maybe they aren't trivial after all and should be removed? Or
nxp,pcf2127 is also trivial?
Rob
P.S. 'make dt_compatible_check' will check in the kernel for
undocumented (by a schema) compatibles.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries
2022-12-19 22:03 ` Rob Herring
@ 2022-12-19 22:52 ` Hugo Villeneuve
2022-12-20 10:17 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Hugo Villeneuve @ 2022-12-19 22:52 UTC (permalink / raw)
To: Rob Herring
Cc: Alessandro Zummo, Alexandre Belloni, Krzysztof Kozlowski,
bruno.thomsen, Hugo Villeneuve, linux-rtc, devicetree,
linux-kernel
On Mon, 19 Dec 2022 16:03:35 -0600
Rob Herring <robh@kernel.org> wrote:
> On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >
> > The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
> > contains:
> > nxp,pcf2129
> > ncp,pca2129
> >
> > Add these missing entries.
> >
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > ---
> > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > index cde7b1675ead..00dbae7e23c2 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -14,7 +14,10 @@ maintainers:
> >
> > properties:
> > compatible:
> > - const: nxp,pcf2127
> > + enum:
> > + - nxp,pcf2127
> > + - nxp,pcf2129
> > + - ncp,pca2129
>
> Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml.
>
> Maybe they aren't trivial after all and should be removed? Or
> nxp,pcf2127 is also trivial?
Hi Rob,
the pcf2127, and also the pca/pcf2129, can use the "reset-source" property. Are they still considered "trivial" devices then?
Hugo.
> P.S. 'make dt_compatible_check' will check in the kernel for
> undocumented (by a schema) compatibles.
>
--
Hugo Villeneuve <hugo@hugovil.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries
2022-12-19 22:52 ` Hugo Villeneuve
@ 2022-12-20 10:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-20 10:17 UTC (permalink / raw)
To: Hugo Villeneuve, Rob Herring
Cc: Alessandro Zummo, Alexandre Belloni, Krzysztof Kozlowski,
bruno.thomsen, Hugo Villeneuve, linux-rtc, devicetree,
linux-kernel
On 19/12/2022 23:52, Hugo Villeneuve wrote:
> On Mon, 19 Dec 2022 16:03:35 -0600
> Rob Herring <robh@kernel.org> wrote:
>
>> On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote:
>>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>>
>>> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
>>> contains:
>>> nxp,pcf2129
>>> ncp,pca2129
>>>
>>> Add these missing entries.
>>>
>>> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>> ---
>>> Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> index cde7b1675ead..00dbae7e23c2 100644
>>> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> @@ -14,7 +14,10 @@ maintainers:
>>>
>>> properties:
>>> compatible:
>>> - const: nxp,pcf2127
>>> + enum:
>>> + - nxp,pcf2127
>>> + - nxp,pcf2129
>>> + - ncp,pca2129
>>
>> Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml.
>>
>> Maybe they aren't trivial after all and should be removed? Or
>> nxp,pcf2127 is also trivial?
>
> Hi Rob,
> the pcf2127, and also the pca/pcf2129, can use the "reset-source" property. Are they still considered "trivial" devices then?
Then they do not look trivial, so please remove them from trivial-rtc.yaml.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries
2022-12-19 19:42 [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries Hugo Villeneuve
2022-12-19 22:03 ` Rob Herring
@ 2022-12-20 10:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-20 10:16 UTC (permalink / raw)
To: Hugo Villeneuve, Alessandro Zummo, Alexandre Belloni, Rob Herring,
Krzysztof Kozlowski
Cc: bruno.thomsen, Hugo Villeneuve, linux-rtc, devicetree,
linux-kernel
On 19/12/2022 20:42, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
> contains:
> nxp,pcf2129
> ncp,pca2129
>
> Add these missing entries.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..00dbae7e23c2 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,10 @@ maintainers:
>
> properties:
> compatible:
> - const: nxp,pcf2127
> + enum:
> + - nxp,pcf2127
> + - nxp,pcf2129
> + - ncp,pca2129
Keep the entries sorted, e.g. alphabetically.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-20 10:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-19 19:42 [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries Hugo Villeneuve
2022-12-19 22:03 ` Rob Herring
2022-12-19 22:52 ` Hugo Villeneuve
2022-12-20 10:17 ` Krzysztof Kozlowski
2022-12-20 10:16 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).