From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F336C4332F for ; Wed, 19 Oct 2022 07:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbiJSHYM (ORCPT ); Wed, 19 Oct 2022 03:24:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229777AbiJSHYK (ORCPT ); Wed, 19 Oct 2022 03:24:10 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15976786F4 for ; Wed, 19 Oct 2022 00:24:07 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id bk15so27545694wrb.13 for ; Wed, 19 Oct 2022 00:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=pO5JseBz8j296HTsa3kKnD9/F7eh1kiGFetG6YGNQSM=; b=A/dTZiZGo87ELII687rFcq19EVEWe04nVPcMeBcmzA9KkKv8+iQGGIr3k4oPKMQkqK KnCnooJ7BEGW2zyS6gsC0AwJ8f7t3hSWDzRBD8KDfaRSJhL+Ou/aNNq2l0FHqutjgboE v2uiYoPrLAC88MPy5iiLVceaAFVZ81yzdfP0BwQdFyPAw9NqwC9hvHv4LMx04/gc28v1 nMxBEMdkmU+li7gSQXHOV71y1PB3hT6eZAPUpXwR0VCJ+F6GJraRC5X2DrZ3RpuPsMqA 2gOCqy7JPIVVjII+brkNwo77xieGLstZOEOFhC1DAGdlfcujziYCTVHkQuobSOv9sVkV 394w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pO5JseBz8j296HTsa3kKnD9/F7eh1kiGFetG6YGNQSM=; b=01e9catdSOdSU35ESJKDl0W/VDeZBdZpE6yBxzpTjL0er2wimFv8aWCOz+vBVu+Ix8 M16wrjqlx3DX57uTvt8W2jRTEJX0JH9x7w4hD6f7zxdpNYe3zXswPumv0B1yb4CbVKa5 IuUV+f26Zb9FySsoPR7sX7XfEZ4HLRGpQqdwp99S1A/OtH6WURKdiaVWSDIuQK+s452x s3cNUtgOK1h324/jPJFYCXNZDGU7ZPvI34k+Ac66toO8pjnkdooKO2u67+036CzsniEF HDqopkWyzqWo63xJuWB21AMUnj3CIs6ImBmQ9NTNChgMaxVqoTk9aQO6VA8DAWB/mN/d u94A== X-Gm-Message-State: ACrzQf0kWhpvXwU0MSDwXFDqy43G/4M77HEwAdnHJq2Y+Ws53xUmYr0d 6odYfIEzYJyFXd5thcrscvVlCw== X-Google-Smtp-Source: AMsMyM41BG7VmonFRVjNhVfV/BEj8FDJYM2MMC9XYIyg52OWiE/yTm381JfFpSAthVXGpTfwKDZ6bQ== X-Received: by 2002:a05:6000:1102:b0:22e:529:a43d with SMTP id z2-20020a056000110200b0022e0529a43dmr4122710wrw.412.1666164244704; Wed, 19 Oct 2022 00:24:04 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:b15b:4b56:592a:c397? ([2a01:e0a:982:cbb0:b15b:4b56:592a:c397]) by smtp.gmail.com with ESMTPSA id z9-20020a5d44c9000000b0022917d58603sm12975630wrr.32.2022.10.19.00.24.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 00:24:04 -0700 (PDT) Message-ID: Date: Wed, 19 Oct 2022 09:24:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] arm64: dts: meson: Enable active coling using gpio-fan on Odroid N2/N2+ Content-Language: en-US To: Martin Blumenstingl , Anand Moon Cc: Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221018195122.8877-1-linux.amoon@gmail.com> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 18/10/2022 23:16, Martin Blumenstingl wrote: > Hello Anand, > > On Tue, Oct 18, 2022 at 9:53 PM Anand Moon wrote: >> >> Odroid N2/N2+ support active cooling via gpio-fan controller. >> Add fan controls and tip point for cpu and ddr thermal sensor >> on this boards. > In the schematics for board rev 0.6 [0] I cannot find any information > about a fan connector. > The schematics for board rev 0.3 [1] on the other hand document a PWM > based fan connector on page 16. It seems the fan connector is on page 41 on rev 0.6 and it seems to be the same. > So now I am not sure whether your patch only applies to certain board > revisions, the schematics are incorrect, etc. > > Can you please provide some details about the fan connector on > Odroid-N2/N2+ and which hardware revisions are supported (and which > aren't) by your patch? > > > Thank you! > Martin > > > [0] https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf > [1] https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.3_20190117.pdf Neil