From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF4E17DFEB for ; Mon, 30 Sep 2024 08:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727686524; cv=none; b=ggQ9+yg6jO4bEZIhnx59oH5VMfjCE9EoQJyfdiigM5vXQDxI8NAijceO6Ai4Kka9sa5Gz6qiROqF7A3XOeK5RFEp6iAbo5eespNdXRIf3RQgRm3+7E9M4Jr6dAq4Fi62UKSEqHuSExJkj+g0EqxkVWtnGyN56I1j9Cb7jeT3akU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727686524; c=relaxed/simple; bh=Sc0whwRYzUxHFiiKA/Byp9+TYn/ZBK0ajmkeKMsqwEY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l/cJ91YLXP6EvGpMQ2LTlUgcAf7puAAwQwy6gIXm7D01XXMhlrdVrR9NfgBjHPCYwaX+P1lVbBoJ8MhstDqujlyUDg1uBlOYJtiL+tdHiSN4pMwGhG54gph8ftMr+38Ltb4jaIFgGOrd7ffdpLWKtEMzLB7SBClp+aOCtLJ6/NM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x2IddKr4; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x2IddKr4" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a8d43657255so646092066b.0 for ; Mon, 30 Sep 2024 01:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727686521; x=1728291321; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NUlj16IZIlE/BnsrhQgqo6rfm+qX/DDN32OWCmaTHPo=; b=x2IddKr4Z4xcdeO9sQbz3KfXg8PfKyhuN31cByp8W7VfVQsHtpUfqI+C7Zm0hhdLIB 1+mpo9gA/ECDxIOM7hiDFWaH6L9PhfP59cWLram9DOW0cjqo1RsLfCwHJCt8c5hDPEA1 O8Dr9YErbe3AY/5zXKXm0h0QDKLvinfYgzGlqPKQ9hDSZPBxDwhzymjqAkTodEza0WZp /jICOmpIwUYBwUECMrkkUyhw8cchcLFlKZS5fL35TWc5W74ex+jODbGiU2S4kLkogj+m EAD1Tzi8cB/lwYbqdNA/978O/6s6dFnNn6aUn2s6kDiTrDhLHhkuE9yRzy8vEtWki8Q4 K6Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727686521; x=1728291321; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NUlj16IZIlE/BnsrhQgqo6rfm+qX/DDN32OWCmaTHPo=; b=d0aZhgW0wdIDdjzm446Q621gdtEUoZ9b3soVNxXvrdCe+c7++72zYb+iC8fQ13j5/J zQ38Q/pB23hI14SRhvhPa7LWxgQD7dFGfb+AkbpO7t7i+13oJmUdgZRPm5hLKpzghf8s m9pLyRQQpuuOpa3QunjBfw05ovaBBDS0qssLo8OL+CkL58T81S/V+2d7ZXAy1bilLPRt yGMhhuE3xyeZl2KSr+fkvQ8xgijR8sgxseUxlLuHahMhZoEzuBSdvKGc7uWxJtKk9uDD bjTUP9j732QAtvzsKI4QhLT/b5xKPf8MxA2IhgoeScQnUGf1Mv4rLjk9pMkUeRga4VNK uJEw== X-Forwarded-Encrypted: i=1; AJvYcCXEMA/NnSMWML4CLPYR2HGfGCuoyNftlv/ycLkBXHdt076ZThLMXgpT+Ep1gI1CpmE52cjfcU3QH5xc@vger.kernel.org X-Gm-Message-State: AOJu0Yxzifbq9+iNO9gTBmU9ucOzzU2ZBBI+5eST2tKckwECGC2UHglx kyZy4lORsvVMP5QPDk1/xwgOK+X0bx0RCqkcNGutYtueN1JGKyQi/+nEeyAxZNo= X-Google-Smtp-Source: AGHT+IFgvE/PliHY6TjajbPHmCe35TGmXquD6tqKuayO2zMJA/3GTARoVqGeboOAWokff0EVeBn8bg== X-Received: by 2002:a17:907:74b:b0:a86:7e7f:69ab with SMTP id a640c23a62f3a-a93c49087f3mr1182345666b.15.1727686520863; Mon, 30 Sep 2024 01:55:20 -0700 (PDT) Received: from [192.168.0.15] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c2997f50sm492236566b.198.2024.09.30.01.55.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2024 01:55:20 -0700 (PDT) Message-ID: Date: Mon, 30 Sep 2024 09:55:19 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding To: Vladimir Zapolskiy , Krzysztof Kozlowski , Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240812144131.369378-1-quic_depengs@quicinc.com> <20240812144131.369378-8-quic_depengs@quicinc.com> <9ed92660-5f42-4a1a-9261-b8800133972a@linaro.org> <65e5796a-8b8d-44f0-aef4-e420083b9d52@kernel.org> <87419076-c355-4eb9-8bf4-a9f2064e3c0a@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <87419076-c355-4eb9-8bf4-a9f2064e3c0a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30/09/2024 09:46, Vladimir Zapolskiy wrote: > Hello Krzysztof, > > On 9/30/24 10:16, Krzysztof Kozlowski wrote: >> On 25/09/2024 17:13, Depeng Shao wrote: >>> Hi Vladimir, >>> >>> On 9/6/2024 11:56 PM, Vladimir Zapolskiy wrote: >>> >>>>> +            compatible = "qcom,sm8550-camss"; >>>>> + >>>>> +            reg = <0 0x0acb7000 0 0xd00>, >>>>> +                  <0 0x0acb9000 0 0xd00>, >>>>> +                  <0 0x0acbb000 0 0xd00>, >>>>> +                  <0 0x0acca000 0 0xa00>, >>>>> +                  <0 0x0acce000 0 0xa00>, >>>>> +                  <0 0x0acb6000 0 0x1000>, >>>>> +                  <0 0x0ace4000 0 0x2000>, >>>>> +                  <0 0x0ace6000 0 0x2000>, >>>>> +                  <0 0x0ace8000 0 0x2000>, >>>>> +                  <0 0x0acea000 0 0x2000>, >>>>> +                  <0 0x0acec000 0 0x2000>, >>>>> +                  <0 0x0acee000 0 0x2000>, >>>>> +                  <0 0x0acf0000 0 0x2000>, >>>>> +                  <0 0x0acf2000 0 0x2000>, >>>>> +                  <0 0x0ac62000 0 0xf000>, >>>>> +                  <0 0x0ac71000 0 0xf000>, >>>>> +                  <0 0x0ac80000 0 0xf000>, >>>>> +                  <0 0x0accb000 0 0x2800>, >>>>> +                  <0 0x0accf000 0 0x2800>; >>>> >>>> Please sort the list above in numerical order, this will change >>>> positions >>>> of "vfe_lite0", "vfe_lite1" etc. >>>> >>>> Another note, since it's not possible to map less than a page, so I >>>> believe >>>> it might make sense to align all sizes to 0x1000. >>>> >>> >>> Sure, I previously sorted by the alphabetical order of reg_name. >>> I will update it based on your suggestion. And will also make sure the >>> align all sizes to 0x1000. >> >> If I understood correctly, you want to change the order from existing >> devices, so no. You are supposed to keep the same order, as much as >> possible. > > Please elaborate, what do you mean here by the "existing evices"? > > The list is not sorted by reg values, I ask to sort the list by reg values. > > -- > Best wishes, > Vladimir We always sort by address: camss: camss@ac5a000 { compatible = "qcom,sc8280xp-camss"; reg = <0 0x0ac5a000 0 0x2000>, <0 0x0ac5c000 0 0x2000>, <0 0x0ac65000 0 0x2000>, <0 0x0ac67000 0 0x2000>, <0 0x0acaf000 0 0x4000>, <0 0x0acb3000 0 0x1000>, <0 0x0acb6000 0 0x4000>, <0 0x0acba000 0 0x1000>, <0 0x0acbd000 0 0x4000>, <0 0x0acc1000 0 0x1000>, <0 0x0acc4000 0 0x4000>, <0 0x0acc8000 0 0x1000>, <0 0x0accb000 0 0x4000>, <0 0x0accf000 0 0x1000>, <0 0x0acd2000 0 0x4000>, <0 0x0acd6000 0 0x1000>, <0 0x0acd9000 0 0x4000>, <0 0x0acdd000 0 0x1000>, <0 0x0ace0000 0 0x4000>, <0 0x0ace4000 0 0x1000>; reg-names = "csiphy2", "csiphy3", "csiphy0", "csiphy1", "vfe0", "csid0", "vfe1", "csid1", "vfe2", "csid2", "vfe_lite0", "csid0_lite", "vfe_lite1", "csid1_lite", "vfe_lite2", "csid2_lite", "vfe_lite3", "csid3_lite", "vfe3", "csid3"; This is the way. --- bod