From: "Nuno Sá" <noname.nuno@gmail.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
nuno.sa@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Olivier Moysan <olivier.moysan@foss.st.com>
Subject: Re: [PATCH v7 1/9] of: property: fix typo in io-channels
Date: Tue, 30 Jan 2024 11:32:00 +0100 [thread overview]
Message-ID: <c15cff6c67a9cbb9dc191175cb550ef28639c252.camel@gmail.com> (raw)
In-Reply-To: <CAGETcx-_FbMuisXb5aw40RxgnMT8xTOaq2FOmTo-twY09EV1sQ@mail.gmail.com>
On Mon, 2024-01-29 at 14:33 -0800, Saravana Kannan wrote:
> On Mon, Jan 29, 2024 at 12:15 AM Nuno Sá <noname.nuno@gmail.com> wrote:
> >
> > On Sat, 2024-01-27 at 15:07 +0000, Jonathan Cameron wrote:
> > > On Wed, 24 Jan 2024 19:14:35 -0800
> > > Saravana Kannan <saravanak@google.com> wrote:
> > >
> > > > On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay
> > > > <devnull+nuno.sa.analog.com@kernel.org> wrote:
> > > > >
> > > > > From: Nuno Sa <nuno.sa@analog.com>
> > > > >
> > > > > The property is io-channels and not io-channel. This was effectively
> > > > > preventing the devlink creation.
> > >
> > > I'm a bit lost on the devlink side of things. Is this something with
> > > effects on existing drivers before this patch set, or is it only causing
> > > real problems with the changes in here?
> > >
> > > i.e. Should we mark it for stable and rush it in as a fix, or can it wait
> > > for the rest of the set?
> > >
> >
> > I guess you already figured this out? Anyways, this is a real fix that was
> > affecting any consumer using io-channels (so nothing to do with the current
> > series). Since the there was a typo, no fw_links were being created.
> >
> > I stated in the cover why I included this. Just to make the addition of io-
> > backends later on easier. But if Rob prefers (or you), I can just send this
> > standalone patch to the devicetree list.
>
> I think you should send this to Rob directly as a DT fix. I already
> gave you a Reviewed-by too. So it should land quickly.
>
> This is a real bug that we want to fix as soon as we can. And your
> series might take a bit longer to land.
>
> -Saravana
Alright... will do that
- Nuno Sá
next prev parent reply other threads:[~2024-01-30 10:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 15:14 [PATCH v7 0/9] iio: add new backend framework Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 1/9] of: property: fix typo in io-channels Nuno Sa via B4 Relay
2024-01-25 3:14 ` Saravana Kannan
2024-01-27 15:07 ` Jonathan Cameron
2024-01-27 15:16 ` Jonathan Cameron
2024-01-29 8:18 ` Nuno Sá
2024-01-29 22:33 ` Saravana Kannan
2024-01-30 10:32 ` Nuno Sá [this message]
2024-01-30 20:54 ` Rob Herring
2024-01-30 20:54 ` Rob Herring
2024-01-31 8:55 ` Nuno Sá
2024-01-23 15:14 ` [PATCH v7 2/9] dt-bindings: adc: ad9467: add new io-backend property Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 3/9] dt-bindings: adc: axi-adc: update bindings for backend framework Nuno Sa via B4 Relay
2024-01-23 16:36 ` Rob Herring
2024-01-23 15:14 ` [PATCH v7 4/9] driver: core: allow modifying device_links flags Nuno Sa via B4 Relay
2024-01-25 3:21 ` Saravana Kannan
2024-01-25 8:14 ` Nuno Sá
2024-01-25 15:34 ` Nuno Sá
2024-01-25 16:57 ` Rafael J. Wysocki
2024-01-26 8:04 ` Nuno Sá
2024-01-26 14:26 ` Nuno Sá
2024-01-27 15:15 ` Jonathan Cameron
2024-01-29 8:29 ` Nuno Sá
2024-01-29 22:31 ` Saravana Kannan
2024-01-30 10:54 ` Nuno Sá
2024-01-26 0:57 ` Saravana Kannan
2024-01-26 8:05 ` Nuno Sá
2024-01-26 0:50 ` Saravana Kannan
2024-01-26 8:13 ` Nuno Sá
2024-01-26 14:27 ` Nuno Sá
2024-01-26 18:09 ` Saravana Kannan
2024-01-27 8:43 ` Nuno Sá
2024-01-23 15:14 ` [PATCH v7 5/9] of: property: add device link support for io-backends Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 6/9] iio: buffer-dmaengine: export buffer alloc and free functions Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 7/9] iio: add the IIO backend framework Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 8/9] iio: adc: ad9467: convert to " Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 9/9] iio: adc: adi-axi-adc: move " Nuno Sa via B4 Relay
2024-01-27 15:20 ` Jonathan Cameron
2024-01-28 21:27 ` David Lechner
2024-01-29 8:15 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c15cff6c67a9cbb9dc191175cb550ef28639c252.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).