From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: uniphier: Use unevaluatedProperties and common bindings
Date: Fri, 15 Apr 2022 10:15:01 +0900 [thread overview]
Message-ID: <c16ca6b1-0363-7ddc-6736-3de738d7e5a5@socionext.com> (raw)
In-Reply-To: <YlccxAQ9adSZh22F@robh.at.kernel.org>
Hi Rob,
On 2022/04/14 3:56, Rob Herring wrote:
> On Thu, Apr 07, 2022 at 04:45:33PM +0900, Kunihiko Hayashi wrote:
>> This adds common bindings thermal-sensor.yaml and this is preferred for
>> unevaluatedProperties instead of additionalProperties.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../bindings/thermal/socionext,uniphier-thermal.yaml | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git
> a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yam
> l
> b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yam
> l
>> index c5b25ce44956..537c93da1397 100644
>> ---
> a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yam
> l
>> +++
> b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yam
> l
>> @@ -14,6 +14,9 @@ description: |
>> maintainers:
>> - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>>
>> +allOf:
>> + - $ref: "thermal-sensor.yaml#"
>
> No advantage to adding this as this schema still has to define the value
> for "#thermal-sensor-cells".
I see. Certainly it's not time to add the common schema yet.
I withdraw this patch.
Thank you,
---
Best Regards
Kunihiko Hayashi
prev parent reply other threads:[~2022-04-15 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 7:45 [PATCH] dt-bindings: thermal: uniphier: Use unevaluatedProperties and common bindings Kunihiko Hayashi
2022-04-13 18:56 ` Rob Herring
2022-04-15 1:15 ` Kunihiko Hayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c16ca6b1-0363-7ddc-6736-3de738d7e5a5@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).