From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Robert Marko <robert.marko@sartura.hr>,
Luka Perkov <luka.perkov@sartura.hr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Michael Walle <michael@walle.cc>,
linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Christian Eggers <ceggers@arri.de>,
Cory Tusar <cory.tusar@pid1solutions.com>
Subject: Re: [PATCH v3 1/6] dt-bindings: nvmem: Fix example
Date: Fri, 11 Nov 2022 16:47:56 +0000 [thread overview]
Message-ID: <c17ec8e0-a0c9-dc18-dbbe-3844b4147437@linaro.org> (raw)
In-Reply-To: <20221104163833.1289857-2-miquel.raynal@bootlin.com>
On 04/11/2022 16:38, Miquel Raynal wrote:
> Despite not being listed nor required within the top level nvmem yaml
> file, the "compatible" property is mandatory and is actually enforced by
> all the nvmem provider bindings.
>
> Unfortunately, the lack of compatible in the nvmem.yaml to level
> description file lead to the example not matching anything and thus not
> being checked at all.
>
> Let's pick a compatible almost randomly (one which is already used with
> the qfprom label) to make the example at least valid on a semantic
> point of view and getting it checked.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied thanks
--srini
> ---
> Documentation/devicetree/bindings/nvmem/nvmem.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> index 1eb22dba364c..0455506fc30f 100644
> --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> @@ -67,6 +67,7 @@ examples:
> #include <dt-bindings/gpio/gpio.h>
>
> qfprom: eeprom@700000 {
> + compatible = "qcom,msm8974-qfprom", "qcom,qfprom";
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x00700000 0x100000>;
next prev parent reply other threads:[~2022-11-11 16:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 16:38 [PATCH v3 0/6] Bindings for NVMEM layouts Miquel Raynal
2022-11-04 16:38 ` [PATCH v3 1/6] dt-bindings: nvmem: Fix example Miquel Raynal
2022-11-10 3:51 ` Rob Herring
2022-11-11 16:47 ` Srinivas Kandagatla [this message]
2022-11-04 16:38 ` [PATCH v3 2/6] dt-bindings: nvmem: Introduce the nvmem-layout container Miquel Raynal
2022-11-04 16:38 ` [PATCH v3 3/6] dt-bindings: eeprom: Inherit from nvmem.yaml Miquel Raynal
2022-11-04 16:38 ` [PATCH v3 4/6] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout Miquel Raynal
2022-11-10 13:49 ` Rob Herring
2022-11-10 17:38 ` Miquel Raynal
2022-11-10 19:31 ` Rob Herring
2022-11-04 16:38 ` [PATCH v3 5/6] dt-bindings: vendor-prefixes: Add ONIE Miquel Raynal
2022-11-04 16:38 ` [PATCH v3 6/6] dt-bindings: nvmem: add YAML schema for the ONIE tlv layout Miquel Raynal
2022-11-10 4:00 ` Rob Herring
2022-11-10 8:50 ` Miquel Raynal
2022-11-10 14:05 ` Rob Herring
2022-11-10 17:43 ` Miquel Raynal
2022-11-10 19:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c17ec8e0-a0c9-dc18-dbbe-3844b4147437@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=brgl@bgdev.pl \
--cc=ceggers@arri.de \
--cc=cory.tusar@pid1solutions.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).