From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9A9C761A6 for ; Wed, 5 Apr 2023 14:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238079AbjDEOQv (ORCPT ); Wed, 5 Apr 2023 10:16:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbjDEOQu (ORCPT ); Wed, 5 Apr 2023 10:16:50 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 286F36191; Wed, 5 Apr 2023 07:16:11 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 335AqQ2g001183; Wed, 5 Apr 2023 14:15:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=MrSFEYpQ3I7RkRnipX62YSTkvysw3V2fzJtTEJ8l0QQ=; b=JNJ3PPd9/80o3vj8Jlrz1/3/bpaWZ0DdvwsKW5QksGh8LbEffZBRQfeCjqInwxOElJxl yx6N6ubO1L5KXXI7jnqdvCCgbTGrrjyyEIH7JqUEACCPBJByts7nD0W/cUoZaum5Kyca RHytjLseTPwAKVIHogL1mEOoZQtnSnbh0HJzU9/k0/ceHvIsYsCZLYb0biQPJsMHaf3Y ND8XW0K03e360JrAi7g3sF6JB4ynureMdCXm6rwSoieoN1hTO7RAl8x6sJ/k6TpapCD1 bmCoGHd3sDg49x+d5bRws6W85Bn+w7/hIKQjKZjz3v9NOEc4s+7X5vkhIesTTWmAxeR3 zg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3prppujqv3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Apr 2023 14:15:19 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 335EFIvw021453 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Apr 2023 14:15:18 GMT Received: from [10.216.10.176] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 5 Apr 2023 07:15:11 -0700 Message-ID: Date: Wed, 5 Apr 2023 19:45:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v6 1/8] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller Content-Language: en-US To: Krzysztof Kozlowski , Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , Andy Gross , "Bjorn Andersson" , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski CC: , , , , , , , , , , , Bjorn Andersson References: <20230405125759.4201-1-quic_kriskura@quicinc.com> <20230405125759.4201-2-quic_kriskura@quicinc.com> <63bfaa1e-c627-bfe1-0bef-d001dae41014@linaro.org> From: Krishna Kurapati PSSNV In-Reply-To: <63bfaa1e-c627-bfe1-0bef-d001dae41014@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ir2MPhxUq0opjT1mMCSD3k47hQQL_Ykq X-Proofpoint-ORIG-GUID: ir2MPhxUq0opjT1mMCSD3k47hQQL_Ykq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-05_09,2023-04-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 clxscore=1011 malwarescore=0 suspectscore=0 adultscore=0 mlxlogscore=601 phishscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304050129 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/5/2023 7:31 PM, Krzysztof Kozlowski wrote: > On 05/04/2023 14:57, Krishna Kurapati wrote: >> Add bindings to indicate properties required to support multiport >> on Snps Dwc3 controller. >> >> Suggested-by: Bjorn Andersson >> Signed-off-by: Krishna Kurapati >> --- >> Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ > > You did not test it at v4 and you got report for this. Your changelog in > commit msg does not mention fixing it. > > It looks like you did not test it for the second time (or sixth time). > > Best regards, > Krzysztof > Hi Krzysztof, I did do a dt_binding_check and I got the following result: kriskura@hu-kriskura-hyd:/local/mnt/workspace/krishna/skales2/skales/kernel$ make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/snps,dwc3.yaml HOSTCC scripts/basic/fixdep HOSTCC scripts/dtc/dtc.o HOSTCC scripts/dtc/flattree.o HOSTCC scripts/dtc/fstree.o HOSTCC scripts/dtc/data.o HOSTCC scripts/dtc/livetree.o HOSTCC scripts/dtc/treesource.o HOSTCC scripts/dtc/srcpos.o HOSTCC scripts/dtc/checks.o HOSTCC scripts/dtc/util.o LEX scripts/dtc/dtc-lexer.lex.c YACC scripts/dtc/dtc-parser.tab.[ch] HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTCC scripts/dtc/dtc-parser.tab.o HOSTLD scripts/dtc/dtc LINT Documentation/devicetree/bindings invalid config: unknown option "max-spaces-inside-empty" for rule "brackets" xargs: /usr/bin/yamllint: exited with status 255; aborting CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,pre-emphasis-duration-bp /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: ignoring, error in schema: properties: gpio-controller /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: properties: adi,excitation-current-0-nanoamp DTEX Documentation/devicetree/bindings/usb/snps,dwc3.example.dts DTC_CHK Documentation/devicetree/bindings/usb/snps,dwc3.example.dtb I can try upgrading the dt-schema and try again. Regards, Krishna,