From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <kernel@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver support for qcs9100 platform
Date: Mon, 29 Jul 2024 18:13:24 +0800 [thread overview]
Message-ID: <c19dc3c8-8d29-46fc-9386-37e83b9217b5@quicinc.com> (raw)
In-Reply-To: <CACMJSevpinkT+jFTK6ijpRF2ULEeAFiWLkWEmQ6bJfJdofyO8g@mail.gmail.com>
On 7/9/2024 11:39 PM, Bartosz Golaszewski wrote:
> On Tue, 9 Jul 2024 at 15:05, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>
>> Add the tlmm driver support for QCS9100 platform.
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcom,qcs9100-tlmm" to the pinctrl device
>> match table.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>> drivers/pinctrl/qcom/pinctrl-sa8775p.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
>> index 5459c0c681a2..4687e11dfe75 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
>> @@ -1519,6 +1519,7 @@ static int sa8775p_pinctrl_probe(struct platform_device *pdev)
>> }
>>
>> static const struct of_device_id sa8775p_pinctrl_of_match[] = {
>> + { .compatible = "qcom,qcs9100-tlmm", },
>> { .compatible = "qcom,sa8775p-tlmm", },
>> { },
>> };
>>
>> --
>> 2.25.1
>>
>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore the current patche here.
Thank you for your input.
--
Thx and BRs,
Tengfei Fan
prev parent reply other threads:[~2024-07-29 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 13:04 [PATCH v2 0/2] pinctrl: qcom: Add the QCS9100 tlmm compatible Tengfei Fan
2024-07-09 13:04 ` [PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible Tengfei Fan
2024-07-10 10:14 ` Krzysztof Kozlowski
2024-07-10 10:26 ` Tengfei Fan
2024-07-29 10:12 ` Tengfei Fan
2024-07-09 13:04 ` [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver support for qcs9100 platform Tengfei Fan
2024-07-09 15:39 ` Bartosz Golaszewski
2024-07-29 10:13 ` Tengfei Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c19dc3c8-8d29-46fc-9386-37e83b9217b5@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox