From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AB01C10F1B for ; Tue, 13 Dec 2022 19:28:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236591AbiLMT2b (ORCPT ); Tue, 13 Dec 2022 14:28:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235893AbiLMT2a (ORCPT ); Tue, 13 Dec 2022 14:28:30 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7CA223EBD for ; Tue, 13 Dec 2022 11:28:28 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id 1so6653396lfz.4 for ; Tue, 13 Dec 2022 11:28:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CFrcfOUYi3nTn96rxqRBPL4KLleaoJ4XIQjtuefCT10=; b=TN7k30kv0Hol7Qz25R2Jzy0vyNTkSZ8Ib87jLudvkEa0UCRlC/Wz0z9xV1BeEGrJWN hqECeJYUzyTDS3pIJcT/nz7TxoXmmo1aYgJA9S5Ldp2dTjBbPHp3CmWzPtB2S8uWxRLO LcOucSYV9vHVxOkApgicHo99v3AbNmCIFKoaKWmuZek07GgjFI6PIvaMNQxSIvT7CENS zgPV4N/mhYrBoRgKOH6hT44hWMNsKcJVvjT90N+eD+I1YStbRHEeT1Qbb41F5867Eirb BaCB7FGqfVXJ/AW/5brdLk5rPwwCIyEDaiLJPiMrkOgGigDmpFEdbm9BRQ60TSkaPb7K +kUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CFrcfOUYi3nTn96rxqRBPL4KLleaoJ4XIQjtuefCT10=; b=XjAPhCxhosYDAO8uRqOXf4PMNdKX0q8Pjl1KH3pR653uejj5l/FC/NLnCzkeRZzsPM hT7PZIf9sUr/ie3xOSO/dolfVotnxGuj4xY+NyTZI+fvMXLpdVdnE92pjIlwFXPAtiDI hIKXbjBUIgi37v92jkG4MnsOdkHZVa+i6b/c86n26x7/EI9+lGk8mQ1F9BW0tULBEBlk pjyXgvMRyKWA+VdO8e9HBgQehjxCdohC96IeKCO2ub5uIzRsphq8dG6iaj2LcWA3gQgu qZI36k4QPMYbQu/LMkPEpbXvgRH3xmhA1fWQ2wMgQl70lvfmyDOxRKNMoPGACl3rOt6O RKSA== X-Gm-Message-State: ANoB5pk1CsL3LPwLZ1nBwQIE2eEp3rRo//XIuSeyXWSDszdRevc3cW2h GNUNTpH64sRI4caLBDD+jZ8WUA== X-Google-Smtp-Source: AA0mqf6rsUdXU64xn6m0QEWHsRnUq/TALCX5FjMIBfN4toCN9uU3ct9+4W/DM0TYi1Le4odI4jKaGw== X-Received: by 2002:ac2:4154:0:b0:4a4:86ff:9562 with SMTP id c20-20020ac24154000000b004a486ff9562mr5361647lfi.38.1670959706958; Tue, 13 Dec 2022 11:28:26 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id g27-20020a2ea4bb000000b002797e41e1bdsm377107ljm.86.2022.12.13.11.28.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 11:28:26 -0800 (PST) Message-ID: Date: Tue, 13 Dec 2022 20:28:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 1/6] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles Content-Language: en-US To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Loic Poulain , Robert Foss , Rob Herring , Krzysztof Kozlowski , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221213183305.544644-1-konrad.dybcio@linaro.org> <91e0e86c-480b-41a4-e4d5-21d59199e430@linaro.org> <96fd8fc1-96ba-2efe-f6ae-5786131d9c94@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <96fd8fc1-96ba-2efe-f6ae-5786131d9c94@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/12/2022 20:20, Konrad Dybcio wrote: > >> >>> then: >>> properties: >>> clocks: >>> @@ -105,10 +116,12 @@ allOf: >>> - if: >>> properties: >>> compatible: >>> - contains: >>> - enum: >>> - - qcom,msm8916-cci >>> - - qcom,msm8996-cci >>> + oneOf: >>> + - contains: >>> + enum: >>> + - qcom,msm8916-cci >>> + >>> + - const: qcom,msm8996-cci >> >> The same comment. > e.g. the 845 example contains 8996 but does not fall in this category, > reverting this change causes errors. Ah, I see, indeed. Looks reasonable: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof