From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61003C819D for ; Mon, 20 Jul 2026 10:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784542041; cv=none; b=rLz8FFwBUVhL9C7XCOW89IYwzBnlFxBfQiEGOjCeuQPoUZN2kQgoUdXBwJBYhRwTNPqO7KQwB6dF7x662OqgUiB7dgC18F4gAqAINmgnrP2uWF/ubnYmxTFr3w045tU4J1pkv/PymiNQg32Oh4so5xCbM2zdALqLvNAVQGYTHrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784542041; c=relaxed/simple; bh=tzQ9eHfyq3kzitdu3/JRiyY3psgb2hIO0GfXWpOqYiE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aXTs7jawXGzVIJq/JMklJv4VXEOluRXW9Z63Ko3zWQiL75j9yAxQAo9FaQ32PZAD0+eoOkgRWkMif+er7W2h3NZOZwm/KnAfbOQ52Owj9JRG20C6ILRxvbUk+YyysZRi1dR2EPLebhoHMvFd4bY3YwTjunsLxMOqH3b7KbL5ttY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kMO0Bdj/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B9ee149S; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kMO0Bdj/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B9ee149S" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66K9vWVI2403764 for ; Mon, 20 Jul 2026 10:07:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j3Y+UGlZuJ7U2i6U7ZQmiNteHAgHWI9jGYqp7rYzg6s=; b=kMO0Bdj/k49N74AZ PbXInzxTO6y2DZHyjRk1s6tOWGeUMb6jMOVwKTJbfM0+3CP821y+7ZP5qppJHdNw 0DC3W1NOCkUveisjyKQPslCZ1QDF1CrEMQSGy+NIqPmbQSMwjudgiTELc4bpG3wk Jf4ucmMu01j3Y1nQLFw5ZoLIfoW2nTqcR10hM+ZR1YrTpKbwRCYaeSddseN/l0OP +nUFCCmI5xRCahDY+2QGqEY1B3AX852QdffZicONw5tB65RSh8N96G5UfFOA2NWR RWinP77MKyYs8jG3qNAHLnZJeBMdGRzDkhen6rOQxVc6FDZSCfySYxI2cDQCwJaj WmRGrA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhfdcgp22-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 10:07:11 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c069f73e4so21336471cf.1 for ; Mon, 20 Jul 2026 03:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784542030; x=1785146830; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=j3Y+UGlZuJ7U2i6U7ZQmiNteHAgHWI9jGYqp7rYzg6s=; b=B9ee149SHO2CC+GViSSOgzYp+qxPnr5rpcRK3ETzcyWN9r+/d+sR6Xc94p71sycWT7 5/5CBdXgU3T12gOzZnkK7FIUXbhGvvT3i8Iow9BeimYReV38nrstBxBEp9+MNEQ8zobn LbHV3hqXmhZuLoRbsj9CFsIKIzAMvrbBhdrKucbjy0i0GfRoXZmO7qKIPyLRGqylePBO XjQYdQkMxOMo9gZssaslmenqevaBOby3cE4ZdKv+fdy42sfcxlM51wwGW21IBBebieS0 V8S5Fn3KU8M6Xjh2m8SLGQWZ2iLYqZCnTEJ19csBBw2dNPQDhAUl16/usAnQ4HMZvsJf RW2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784542030; x=1785146830; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j3Y+UGlZuJ7U2i6U7ZQmiNteHAgHWI9jGYqp7rYzg6s=; b=IytUtQbL8N3+FHPqklYZQBSZ1UT5DZ8EOxKnFB2yNkUvm2W4wjfQTZF2GtRu2vX8YP VEnmSSsldv0iH4DW2ASNuv47ZgK0JnZOZ+Uv+6lyhV8OyqXBeZ2tBxrOYrnlM8VSp/BG mGEh9duQ3WRtKJP2eg9pMyjZQVvxppg6p61LgfQFMAvCKUAp4qDjDpWAeWZGNP6roRYr +gU2jNK0u79eJJDhEdBFSvNtRXlrG7v7dfy5g5JtWCQvcEmAUmCZ3lOJPuISt46UXxZU qCmERAW+me24L3ZjYYQmORYsHhGtEGfuDkjD09eujTvhDLvg4eUn6jWATUnXpzLfkdNd Qz4g== X-Forwarded-Encrypted: i=1; AHgh+RqE14aiifi4JMM04a4//5SAI/RvOoWZqoueX9f2AxMuAQfF7DrPpbjRLF98P3+/oWyyOAAAtqo7j3HO@vger.kernel.org X-Gm-Message-State: AOJu0Yyw3IdWRLFnGKxuHCobTI4P0rXzEq3sSzpu+zKSxIpStwjkYXzQ wZS/z6Ywa3ao5SP7lPD0W2Ur6agawHg94izQPCTPmLhImIgd+vnNVG5ulgfoV5FSfJ/UXV+MUrS hjV0Mk1U6f3Hd6mXOQtVVTpwtWO92Hwa0K4VDJsXn7C0B1dAfua4bIR24FMED+Ko7 X-Gm-Gg: AfdE7cmktSUm/haHguioYAeTW5PyVF0LQSov55KN9x7Tc+XOHi+xthf1rNMHAuMyF3e fyReOVD1Ojgp3vlcTL+Sl1yiVhWsqVkwh0GAW3n1JHbjZOGoR1ZrRXxGFNvpFgoQUrqwLQYp4SZ 0ck3ezdppmj2PS+J/ODgxDms9cTE7i9WHAronOamG1mhekPb7w2fFfYhMJLUfSz76mqUM2eRwAe 4rZ7MgPq0TrR0ParrRZDxDxQO45K82m31iKB2oeVoXjseqYxWlrLi5SbIn64vHwRAfWZ3ND0c2m QQ4iZ4McQUi8yrwbl3up9gXHS8rTz6zrSeAQ8XBWtCId7HPQaVV+SnDsHnGs1eLNOMPgxbwuriQ 6dE6tYFxlO53kU+fW7FiiiK5j X-Received: by 2002:a05:622a:2515:b0:51b:ff1a:3d80 with SMTP id d75a77b69052e-5213e67f307mr108566321cf.7.1784542030125; Mon, 20 Jul 2026 03:07:10 -0700 (PDT) X-Received: by 2002:a05:622a:2515:b0:51b:ff1a:3d80 with SMTP id d75a77b69052e-5213e67f307mr108566091cf.7.1784542029722; Mon, 20 Jul 2026 03:07:09 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1740bf3ad3sm440846966b.55.2026.07.20.03.07.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 03:07:08 -0700 (PDT) Message-ID: Date: Mon, 20 Jul 2026 12:07:06 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Flatten usb controller nodes To: Xilin Wu , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Qiang Yu Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260507-sc8280xp-flatten-dwc3-v1-1-b18be56bebba@radxa.com> <2cb32deb-4266-416a-8db7-1b3b46b52162@oss.qualcomm.com> <843419F943CDE487+c183d00a-3967-4ba7-b6fe-fc50749701b9@radxa.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: xdqwQaN4zms6KNFjKh5_mVbwxZ-YpwXf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDExMyBTYWx0ZWRfX914WVWw9eSle hFoozYGApwYXDaQe33PCy5VmegaBS9HsK9zICSO/vxiSkNyfyygnKFGxFcmOAydqptU2i5+Nevo aMe4wEJsW5RYSEedxGd1HgDWKBTInb6UhPfyjHcflzMwL7cwD3Klir/ruVwNgD4IIpdE31yWD6K vPgfkHHM+ATgRHWgZ9iSGahLAkastFG+hXfiNVCBrtnt6Ov+2P9JQEysKUODHz/gKLA1yXauyu8 maGHxzDAOPSglYmAU6dXCjAdkUwx9xUF3K1MkP3g7XGXmSVRnauC10e+zIoHnjFFopHiCgHTHrQ 3T6sWGiPr40uKHECfxC4zt0Cd/uQxTtoMcmdMA0NYGkRO01E5NqJQqyPZfALjPEVxoKkuHob0mK X/e33+UVu3ef03+Qmw/Tg7k1DeQhJMvMmDJJNFZoNDBCgANZi0ew1F8nMTlM1yBokieLqH1tSX+ PGbb44eWq9EbFJGrsug== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDExMyBTYWx0ZWRfX+DxysfkXo6g8 z7+2xbCyVV9+ce22XKRrSdG8GDCcurkxc8JZqtfQqUo+m+QYJINViVTHlOMwD53T6GQxlWpFrvc 24bWPJ6PqkZxSP232U3HGsKMc+kNOYw= X-Proofpoint-GUID: xdqwQaN4zms6KNFjKh5_mVbwxZ-YpwXf X-Authority-Analysis: v=2.4 cv=bv58wkai c=1 sm=1 tr=0 ts=6a5df34f cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=0Miry4rRAAAA:8 a=NEAV23lmAAAA:8 a=ksxQWNrZAAAA:8 a=EUspDBNiAAAA:8 a=Pi0YOo2IrXSleUiyJT8A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=UT1Yo3WijKgCWNxi40OF:22 a=l7WU34MJF0Z5EO9KEJC3:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_02,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200113 On 7/1/26 6:12 PM, Konrad Dybcio wrote: > On 7/1/26 6:04 PM, Xilin Wu wrote: >> On 7/1/2026 11:10 PM, Konrad Dybcio wrote: >>> On 5/7/26 4:29 PM, Xilin Wu wrote: >>>> Flatten usb controller nodes and update to using latest bindings >>>> and flattened driver approach. >>>> >>>> Signed-off-by: Xilin Wu >>>> --- >>> >>> I tested this on a CRD and an x13s, both work fine across suspend. >>> >>> Turned out in my local experiments I made a typo in the name of the >>> interrupt that was carried over to the big node.. >>> >>> Reviewed-by: Konrad Dybcio >>> Tested-by: Konrad Dybcio # X13s, CRD8280 >>> >>> Konrad >>> >> >> Unfortunately as I mentioned on IRC [1], this actually causes random NoC timeout on reboot, which seems to be related to pcie. >> >> [1] https://oftc.catirclogs.org/linux-msm/2026-06-11#35405057; > > Ah, you mentioned this: > > https://gist.github.com/strongtz/50bbd71a9f41d0d1aa9849b8cf1dce21 > > This is an attempt to read CONFIG_SPACE+0x0.. I don't really know.. Could you try adding something like this diff --git a/drivers/pci/access.c b/drivers/pci/access.c index b123da16b63b..5e08cb239e78 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -43,6 +43,7 @@ int noinline pci_bus_read_config_##size \ if (PCI_##size##_BAD) \ return PCIBIOS_BAD_REGISTER_NUMBER; \ \ + dev_err(&bus->dev, "Reading configspace+0x%x as %s\n", pos, #size); \ pci_lock_config(flags); \ res = bus->ops->read(bus, devfn, pos, len, &data); \ if (res) (perhaps with a WARN_ON(1) to get a stack trace and only print for the crashing reg)? FWIW I can't repro on a CRD8280 Konrad