From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v2 3/7] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1
Date: Mon, 18 Dec 2023 11:13:47 +0100 [thread overview]
Message-ID: <c1d4f636-d068-48e0-9013-b5a586fff99f@linaro.org> (raw)
In-Reply-To: <e00b2c5a-cd79-40ed-b78b-0aa8c5b33fa0@quicinc.com>
On 18/12/2023 10:59, Tengfei Fan wrote:
>
>
> 在 12/11/2023 6:25 PM, Krzysztof Kozlowski 写道:
>> On 07/12/2023 10:27, Tengfei Fan wrote:
>>> Address/size-cells will cause dtbs check warning, because mdss_dsi1 node
>>> have not ranges and child also have not reg, so remove address/size-cells.
>>
>> Paste the excerpt of warning.
> Sure, I will paste the excerpt of warning.
>>
>>>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>
>> I am not sure if this is correct. The address/size cells are there for
>> panels. We have multiple of such warnings, so I would like to have here
>> consensus for all of them.
> Currently these address/size cells lead to dtc W=1 warning, so these
I know.
> should be dropped.
Why? They are correct.
> These can be re-added if needed at a later date.
Added where? These are rather properties of SoC.
This does not solve any of my concerns.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-18 10:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 9:27 [PATCH v2 0/7] arm64: qcom: add AIM300 AIoT board support Tengfei Fan
2023-12-07 9:27 ` [PATCH v2 1/7] dt-bindings: arm: qcom: Document qcs8550 SoC and board Tengfei Fan
2023-12-11 10:24 ` Krzysztof Kozlowski
2023-12-07 9:27 ` [PATCH v2 2/7] arm64: dts: qcom: sm8550: remove address/size-cells from pwm Tengfei Fan
2023-12-07 9:27 ` [PATCH v2 3/7] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1 Tengfei Fan
2023-12-11 10:25 ` Krzysztof Kozlowski
2023-12-18 9:59 ` Tengfei Fan
2023-12-18 10:13 ` Krzysztof Kozlowski [this message]
2023-12-19 0:40 ` Tengfei Fan
2023-12-07 9:27 ` [PATCH v2 4/7] dt-bindings: arm: qcom,ids: add SoC ID for QCS8550 Tengfei Fan
2023-12-11 10:26 ` Krzysztof Kozlowski
2023-12-07 9:27 ` [PATCH v2 5/7] soc: qcom: socinfo: add SoC Info support for the QCS8550 platform Tengfei Fan
2023-12-11 10:26 ` Krzysztof Kozlowski
2023-12-07 9:28 ` [PATCH v2 6/7] arm64: dts: qcom: add base AIM300 dtsi Tengfei Fan
2023-12-07 9:28 ` [PATCH v2 7/7] arm64: dts: qcom: aim300: add AIM300 AIoT Tengfei Fan
2023-12-11 10:33 ` Krzysztof Kozlowski
2023-12-13 14:04 ` Krzysztof Kozlowski
2023-12-13 19:01 ` Konrad Dybcio
2023-12-13 19:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1d4f636-d068-48e0-9013-b5a586fff99f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tengfan@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).