From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B829EB64DA for ; Wed, 19 Jul 2023 10:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229961AbjGSKxC (ORCPT ); Wed, 19 Jul 2023 06:53:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbjGSKxB (ORCPT ); Wed, 19 Jul 2023 06:53:01 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75B02119 for ; Wed, 19 Jul 2023 03:53:00 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-51e566b1774so8969917a12.1 for ; Wed, 19 Jul 2023 03:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689763979; x=1692355979; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sSY7y/1+6yYaMus6riUbfDhWCuuda/0kYuX0FoEcddU=; b=tg85zqDx6jj/Z3CoCLI5djTDjzQF9aAMa3YgvXDnU0pyHXw7rcuzBpIwA8yBdLN9sY Ph7R3+uuSvOImNSnY1NHoDAUTAI9eZIAa8K89C7emG9iKk/bPn/lnYIzYHtztZG4BHUZ 82KSkhPwiqrlrW4m8Za04gw0wk89u/ON6TvOn1LTgo/vBT5OqPfteSB6j2KYSKFlB1gQ 21T9jvMOgpYSRS+qKZSd7HgIOJPfBrPq2TJB8YnexUYD+Oy4n0kWA2RUqxWv+mk7OLZh cqV1ZhU0aoD1jPlxkUUCDZb00zf7OU9fnId5WENJqms4je4A/wNIjwLwJm/K8xh03b9i JOsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689763979; x=1692355979; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sSY7y/1+6yYaMus6riUbfDhWCuuda/0kYuX0FoEcddU=; b=DU1TMXDfmGbI9T0iI+G+ygPbwTVsVKosZXbykiU1mxA+fpJzTeQvQvG5EOXqIHjSek lSxQ7oUJI8/zkCIiklE7Bjouhs5gQguoHHAFm6vmSHLSfJ1774LliL5lmB+iDkAXvbI5 WUH0ei9C1d7caaYRgCddL1YA1FaCdzPhF7MMAJ6qPWnEMmcHlSqGKKTWwmOOMMPQehQA uB53jEW80r/toRwd1/mL3W9lZ8ixayCJ3Guc0l1/fZfynCsFqDk3bdEgw0CDPuDm0sbz MI0L0Oj8QCCcjubIF+JNgNF5YfwmjN9OQTgYeSgaszKa5pDetbs7e6DebwfgJZ/JJBEQ vQPA== X-Gm-Message-State: ABy/qLZBE1Y6nwzPmYHAY0ZuRr4rZIJMV9JrDxTgrdiDGau9zcQwkWbJ 1j8wAfpSAIIwlsDtkB87hmjvDfVnKeYknTeaCvu+Hw== X-Google-Smtp-Source: APBJJlEqIKUOT6GxeKOCN3apXOlhXrfPpHxzoJyFUMl+xVLbqY0+PPhlyCxzpRR+/9kMh+ghLV4jQg== X-Received: by 2002:aa7:cfd8:0:b0:51d:e30b:f33a with SMTP id r24-20020aa7cfd8000000b0051de30bf33amr2089692edy.34.1689763978715; Wed, 19 Jul 2023 03:52:58 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id r18-20020aa7da12000000b0051d9de03516sm2570472eds.52.2023.07.19.03.52.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 03:52:58 -0700 (PDT) Message-ID: Date: Wed, 19 Jul 2023 12:52:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 1/9] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties Content-Language: en-US To: Minda Chen , Daire McNamara , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Emil Renner Berthing Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Mason Huo , Leyfoon Tan , Kevin Xie References: <20230719102057.22329-1-minda.chen@starfivetech.com> <20230719102057.22329-2-minda.chen@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230719102057.22329-2-minda.chen@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/07/2023 12:20, Minda Chen wrote: > Add PLDA XpressRICH PCIe host common properties dt-binding doc. > Microchip PolarFire PCIe host using PLDA IP. > Extract properties from Microchip PolarFire PCIe host. > > Signed-off-by: Minda Chen > Reviewed-by: Hal Feng > --- > .../pci/plda,xpressrich-pcie-common.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml How is it related with existing plda,xpressrich3-axi? > > diff --git a/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml > new file mode 100644 > index 000000000000..3627a846c5d1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/plda,xpressrich-pcie-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PLDA XpressRICH PCIe host common properties > + > +maintainers: > + - Daire McNamara > + - Minda Chen > + > +description: > + Generic PLDA XpressRICH PCIe host common properties. > + > +select: false This should not be needed. > + > +properties: > + reg: > + description: > + At least host IP register set and configuration space are "At least" does not fit here since you do not allow anything else. > + required for normal controller work. > + maxItems: 2 > + > + reg-names: > + oneOf: > + - items: > + - const: cfg > + - const: apb > + - items: > + - const: host > + - const: cfg Maybe keep similar order, so cfg followed by host? Best regards, Krzysztof