From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: YAML-ify SSBI bindings
Date: Mon, 3 Oct 2022 19:32:26 +0200 [thread overview]
Message-ID: <c1e79572-e5d0-079f-76db-c9e8d4edbcd3@linaro.org> (raw)
In-Reply-To: <20221003171714.GA2462016-robh@kernel.org>
On 03/10/2022 19:17, Rob Herring wrote:
> On Mon, Oct 03, 2022 at 08:46:09AM +0200, Krzysztof Kozlowski wrote:
>> On 02/10/2022 15:46, Dmitry Baryshkov wrote:
>>>>> + enum:
>>>>> + - ssbi
>>>>> + - ssbi2
>>>>> + - pmic-arbiter
>>>>> +
>>>>> + pmic:
>>>>> + type: object
>>>>
>>>> This is quite unspecific... Can we make it a ref to some PMICs schemas?
>>>
>>> Yes, I thought about listing all compats, but probably a $ref:
>>> ../mfd/qcom-pm8xxx.yaml# makes more sense.
>>
>> Then full path - /schemas/mfd/qcom-....
>
> While effectively it's always a QCom PMIC, this is a bus binding, so
> shouldn't it just be 'additionalProperties: { type: object }' without
> any reference to the type of device?
If we treat it as generic bus, then maybe also "pmic" is not
appropriate. What if other devices are connected?
Bindings were saying it is Qualcomm SoC specific bus, so I don't think
we can have here anything else than Qualcomm PMIC.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-03 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 21:20 [PATCH 1/2] dt-bindings: soc: qcom: YAML-ify SSBI bindings Dmitry Baryshkov
2022-09-30 21:20 ` [PATCH 2/2] ARM: dts: qcom: mdm9615: drop unit ids from PMIC nodes Dmitry Baryshkov
2022-10-01 9:40 ` Krzysztof Kozlowski
2022-10-02 13:20 ` Dmitry Baryshkov
2022-10-03 6:46 ` Krzysztof Kozlowski
2022-10-01 9:43 ` [PATCH 1/2] dt-bindings: soc: qcom: YAML-ify SSBI bindings Krzysztof Kozlowski
2022-10-02 13:46 ` Dmitry Baryshkov
2022-10-03 6:46 ` Krzysztof Kozlowski
2022-10-03 17:17 ` Rob Herring
2022-10-03 17:32 ` Krzysztof Kozlowski [this message]
2022-10-03 21:28 ` Dmitry Baryshkov
2022-10-03 13:24 ` Rob Herring
2022-10-03 17:18 ` Rob Herring
2022-11-08 1:27 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1e79572-e5d0-079f-76db-c9e8d4edbcd3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).