From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9489FC433F5 for ; Mon, 3 Oct 2022 17:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbiJCRdV (ORCPT ); Mon, 3 Oct 2022 13:33:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbiJCRcg (ORCPT ); Mon, 3 Oct 2022 13:32:36 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E8E138A2D for ; Mon, 3 Oct 2022 10:32:29 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id j16so17631678lfg.1 for ; Mon, 03 Oct 2022 10:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=zk/FIFXjXpMILVIlFIoyKaAbby/6KJ8jb8SmUTjwY5Y=; b=a/O73w00KNm0068Ren0MjKieUEKT53hh9gpmgrlhb7nZi/HJ5ppD1WYJjQbqcw5jnk DHNXBpZGFJWnYfCeJRzy9G7LvuR0K4JGSX2kaEFm+x2cslXjhbh+QD037DE0+a63lcsu 2OtXWa69+nyWDovRPq64ojsfqjIVYIQ1p8J0moOnqYuKlrP/dY0sjQ9Nu9i0U2MOmPmD VlDbDWnzqm9tG/CDYSB6nD4ISPIF2ZZqrG0yXxDCcdEgJqIfa5zNSmxGTjsNeDlwdLmw gEYF34wI/X8FVWUE3nkw0LNHZe6WsdPmTyH9XO84v4WxzccVYMkY9h0jyWckQsKupTFs HFbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=zk/FIFXjXpMILVIlFIoyKaAbby/6KJ8jb8SmUTjwY5Y=; b=hsvSLEkWSU8QMNSvJaoiOtOoUKbB5jLZmLzDIufrXdhq8/GU1TlSKFCNawvyI1NNvz 2jPvk9FDjk6/TeZCNtZmMJGryxVfQcyjg+Al8Eo233v/e4lqvNDxAje0a3tSkpnidEuH NB3ryr9Y1IMBohfe9322E8uzkDyLQ/X1p7sxakzdz+fy8rhaS8YzfY1VyCbbS7WwW1/R EXodBDulLRKbd9z/8IXrQsQ8YAC48vwrYR0YQ87sJ1E64+sjVQSlKeS2UUUftY5CjeqL hOATvz7WLMYZu/p+pje9SGewZilKaiX2sAKkWc0F6fU6EftBeiVzFgxOLzClPbSiO48Y zfNA== X-Gm-Message-State: ACrzQf2qqA0Wjv2g8D05/AnaniiPSTT+bCVdjsZxgjsSQfDi87a8JRhR iKzdO7TQN+MC54J+JYO1zXRqNA== X-Google-Smtp-Source: AMsMyM6Fp5A19LILl+oYBQki9vEji3xbEl4A1Bqn0ONCv0kCWo5r/nBlPmeh5GX6uQd0akuJjP8pHA== X-Received: by 2002:a05:6512:11e9:b0:49d:7909:ff9b with SMTP id p9-20020a05651211e900b0049d7909ff9bmr7268070lfs.568.1664818347441; Mon, 03 Oct 2022 10:32:27 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id n5-20020a0565120ac500b0048a9e899693sm1543877lfu.16.2022.10.03.10.32.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 10:32:27 -0700 (PDT) Message-ID: Date: Mon, 3 Oct 2022 19:32:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: YAML-ify SSBI bindings Content-Language: en-US To: Rob Herring Cc: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20220930212052.894834-1-dmitry.baryshkov@linaro.org> <4658c7bc-b26f-d22b-73ea-9deb7d29f90f@linaro.org> <20221003171714.GA2462016-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20221003171714.GA2462016-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/10/2022 19:17, Rob Herring wrote: > On Mon, Oct 03, 2022 at 08:46:09AM +0200, Krzysztof Kozlowski wrote: >> On 02/10/2022 15:46, Dmitry Baryshkov wrote: >>>>> + enum: >>>>> + - ssbi >>>>> + - ssbi2 >>>>> + - pmic-arbiter >>>>> + >>>>> + pmic: >>>>> + type: object >>>> >>>> This is quite unspecific... Can we make it a ref to some PMICs schemas? >>> >>> Yes, I thought about listing all compats, but probably a $ref: >>> ../mfd/qcom-pm8xxx.yaml# makes more sense. >> >> Then full path - /schemas/mfd/qcom-.... > > While effectively it's always a QCom PMIC, this is a bus binding, so > shouldn't it just be 'additionalProperties: { type: object }' without > any reference to the type of device? If we treat it as generic bus, then maybe also "pmic" is not appropriate. What if other devices are connected? Bindings were saying it is Qualcomm SoC specific bus, so I don't think we can have here anything else than Qualcomm PMIC. Best regards, Krzysztof