From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>,
Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/2] arm64: dts: qcom: msm8916: Enable blsp_dma by default
Date: Sat, 7 Jan 2023 12:51:09 +0100 [thread overview]
Message-ID: <c20125c3-b5a9-daed-1823-689ae3f02bfe@linaro.org> (raw)
In-Reply-To: <20230107110958.5762-2-stephan@gerhold.net>
On 7.01.2023 12:09, Stephan Gerhold wrote:
> Adding the "dmas" to the I2C controllers prevents probing them if
> blsp_dma is disabled (infinite probe deferral). Avoid this by enabling
> blsp_dma by default - it's an integral part of the SoC that is almost
> always used (even if just for UART).
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 4 ----
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index ef5b39ba1238..c52d79a55d80 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -169,10 +169,6 @@ led@6 {
> };
> };
>
> -&blsp_dma {
> - status = "okay";
> -};
> -
> &blsp_i2c2 {
> /* On Low speed expansion */
> status = "okay";
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index ffb4ce8935b3..98da982548a1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1522,7 +1522,6 @@ blsp_dma: dma-controller@7884000 {
> clock-names = "bam_clk";
> #dma-cells = <1>;
> qcom,ee = <0>;
> - status = "disabled";
> };
>
> blsp1_uart1: serial@78af000 {
next prev parent reply other threads:[~2023-01-07 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 11:09 [PATCH 0/2] arm64: dts: qcom: msm8916: Enable DMA by default Stephan Gerhold
2023-01-07 11:09 ` [PATCH 1/2] arm64: dts: qcom: msm8916: Enable blsp_dma " Stephan Gerhold
2023-01-07 11:51 ` Konrad Dybcio [this message]
2023-01-07 11:09 ` [PATCH 2/2] arm64: dts: qcom: msm8916: Add DMA for all I2C controllers Stephan Gerhold
2023-01-07 11:51 ` Konrad Dybcio
2023-01-11 19:49 ` [PATCH 0/2] arm64: dts: qcom: msm8916: Enable DMA by default Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c20125c3-b5a9-daed-1823-689ae3f02bfe@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).