Re: [RFC PATCH] dt-bindings: incomplete-devices: allow additional properties

[Krzysztof Kozlowski <krzk@kernel.org>]

On 02/04/2026 14:27, Wolfram Sang wrote:
> Linux test infrastructure is rightfully handled as 'incomplete devices.'
> It may need additional properties, though, like this mailbox test entry:
> 
> mailbox_test_send_to_recv@c1000000 {
>         compatible = "mailbox-test";
>         broken-usage-of-incorrect-compatible;
>         reg = <0x0 0xc1000000 0x0 0x100>;
>         mboxes = <&mfis 0 (MFIS_CHANNEL_IICR | MFIS_CHANNEL_TX)>,
>                  <&mfis 0 (MFIS_CHANNEL_EICR | MFIS_CHANNEL_RX)>;
>         mbox-names = "tx", "rx";
>  };
> 
> So, allow additional properties to prevent:
> 
> .../arch/arm64/boot/dts/renesas/r8a78000-ironhide.dtb: mailbox_test_send_to_recv@c1000000 (mailbox-test): 'broken-usage-of-incorrect-compatible', 'mbox-names', 'mboxes', 'reg' do not match any of the regexes: '^pinctrl-[0-9]+$'
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

And with your patch how does the warning look like?

This solves nothing - the entire point is to have warning for
'broken-usage-of-incorrect-compatible'. If there are warnings for
mboxes, does not really matter.


> ---
> 
> Maybe this is not worth the hazzle because these testing bindings should
> never be used in production DTs. During development, however, this is
> useful because it reduces noise, so real bugs become more visible.
> 
> If this is not applicable for reasons I overlooked, another approach
> could be to use 'broken-usage-of-incorrect-compatible' as an early exit
> in fixup_node_props() of the validator?
> 
> RFC because of all of the above. Is this worth it?
> 
>  Documentation/devicetree/bindings/incomplete-devices.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/incomplete-devices.yaml b/Documentation/devicetree/bindings/incomplete-devices.yaml
> index 4bb6c0141e9f..8f6df738f5e9 100644
> --- a/Documentation/devicetree/bindings/incomplete-devices.yaml
> +++ b/Documentation/devicetree/bindings/incomplete-devices.yaml
> @@ -282,4 +282,4 @@ required:
>    - compatible
>    - broken-usage-of-incorrect-compatible
>  
> -additionalProperties: false
> +additionalProperties: true


Best regards,
Krzysztof