Devicetree
 help / color / mirror / Atom feed
From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"donald.robson@imgtec.com" <donald.robson@imgtec.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "sarah.walker@imgtec.com" <sarah.walker@imgtec.com>,
	"kristo@kernel.org" <kristo@kernel.org>, "nm@ti.com" <nm@ti.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node
Date: Tue, 5 Dec 2023 11:15:51 +0000	[thread overview]
Message-ID: <c20b213534667337f08b75a6c325fafec6526135.camel@siemens.com> (raw)
In-Reply-To: <20231204121522.47862-1-donald.robson@imgtec.com>

Hi Donald, Sarah et al,

thanks for the patch!

On Mon, 2023-12-04 at 12:15 +0000, Donald Robson wrote:
> From: Sarah Walker <sarah.walker@imgtec.com>
> 
> Add the Series AXE GPU node to the AM62 device tree.
> 
> Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> Signed-off-by: Donald Robson <donald.robson@imgtec.com>

powervr fd00000.gpu: [drm] loaded firmware powervr/rogue_33.15.11.3_v1.fw
powervr fd00000.gpu: [drm] FW version v1.0 (build 6503725 OS)
[drm] Initialized powervr 1.0.0 20230904 for fd00000.gpu on minor 0

In general it allows the driver to be probed on TI AM625 EK, so
Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>

But I'm not sure if you maybe want to disable it by default like
other HW blocks for the (potential) boards which don't have video at all.

> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index e5c64c86d1d5..4338fd8ab2d7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -965,4 +965,13 @@ mcasp2: audio-controller@2b20000 {
>                 power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
>                 status = "disabled";
>         };
> +
> +       gpu: gpu@fd00000 {
> +               compatible = "ti,am62-gpu", "img,img-axe";
> +               reg = <0x00 0x0fd00000 0x00 0x20000>;
> +               clocks = <&k3_clks 187 0>;
> +               clock-names = "core";
> +               interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> +               power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> +       };
>  };

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

  parent reply	other threads:[~2023-12-05 11:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 12:15 [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node Donald Robson
2023-12-04 13:08 ` Nishanth Menon
2023-12-05 11:15 ` Sverdlin, Alexander [this message]
2023-12-05 11:26   ` Donald Robson
2023-12-05 11:43     ` mripard
2023-12-05 15:19   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c20b213534667337f08b75a6c325fafec6526135.camel@siemens.com \
    --to=alexander.sverdlin@siemens.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=donald.robson@imgtec.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=sarah.walker@imgtec.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox