From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 372A5CA9ED3 for ; Mon, 4 Nov 2019 06:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D8E6222C6 for ; Mon, 4 Nov 2019 06:56:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="XyxBdQ1N"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="RL01cePn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726018AbfKDG4r (ORCPT ); Mon, 4 Nov 2019 01:56:47 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:51482 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727567AbfKDG4p (ORCPT ); Mon, 4 Nov 2019 01:56:45 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2881E60DAF; Mon, 4 Nov 2019 06:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572850604; bh=AhKc5wWa30wa/WEEpKjo85dpiL/PXLkjhkK4VBEnxWg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=XyxBdQ1NLS+LAGi1NKtYYmihmAhNvIVUX+82A3BNEQEq3VNoUE0SG0nK24twwwzVx mb7X7wQ1lExFdySDfXNzSh8KNy8Mnq1wX0/GrBfE1/prwMobWA3tP4YKmdBhpGRPWo Ghp3S75HF+58K1EV95vjxS+36EUMyShDIsOuNuaw= Received: from [10.79.136.17] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rnayak@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8E3A160DAF; Mon, 4 Nov 2019 06:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572850603; bh=AhKc5wWa30wa/WEEpKjo85dpiL/PXLkjhkK4VBEnxWg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=RL01cePnSeK1p8UZDWKH1KsinywU/JXZjQI9c0w23nvtKGyN0MMcWtLxpcoSvu+R5 XJWpLQmNKoW5I0z8IDdLZU2EE3QsskYyry3JVxLPLpDxlPHtBjbqn76XtjCv++wJ9/ IdcBHFudOnJdz0gALRcyrvxhnD1yV/T/ar2zpbAk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8E3A160DAF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rnayak@codeaurora.org Subject: Re: [PATCH v3 11/11] arm64: dts: qcom: sc7180: Add pdc interrupt controller To: Bjorn Andersson Cc: Matthias Kaehlcke , Stephen Boyd , agross@kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maulik Shah References: <20191023090219.15603-1-rnayak@codeaurora.org> <20191023090219.15603-12-rnayak@codeaurora.org> <5db86de0.1c69fb81.9e27d.0f47@mx.google.com> <20191030195021.GC27773@google.com> <6610d7fe-5a4d-5a43-5c4f-9ae61e7e53ee@codeaurora.org> <20191104063348.GA2464@tuxbook-pro> From: Rajendra Nayak Message-ID: Date: Mon, 4 Nov 2019 12:26:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191104063348.GA2464@tuxbook-pro> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/4/2019 12:03 PM, Bjorn Andersson wrote: > On Sun 03 Nov 22:17 PST 2019, Rajendra Nayak wrote: > >> >> >> On 10/31/2019 1:20 AM, Matthias Kaehlcke wrote: >>> On Tue, Oct 29, 2019 at 09:50:40AM -0700, Stephen Boyd wrote: >>>> Quoting Rajendra Nayak (2019-10-23 02:02:19) >>>>> From: Maulik Shah >>>>> >>>>> Add pdc interrupt controller for sc7180 >>>>> >>>>> Signed-off-by: Maulik Shah >>>>> Signed-off-by: Rajendra Nayak >>>>> --- >>>>> v3: >>>>> Used the qcom,sdm845-pdc compatible for pdc node >>>> >>>> Everything else isn't doing the weird old compatible thing. Why not just >>>> add the new compatible and update the driver? I guess I'll have to go >>>> read the history. >>> >>> Marc Zyngier complained on v2 about the churn from adding compatible >>> strings for identical components, and I kinda see his point. >>> >>> I agree that using the 'sdm845' compatible string for sc7180 is odd too. >>> Maybe we should introduce SoC independent compatible strings for IP blocks >>> that are shared across multiple SoCs? If differentiation is needed SoC >>> specific strings can be added. >> >> Sure, I will perhaps add a qcom,pdc SoC independent compatible to avoid >> confusion. >> > > I agree, > > compatible = "qcom,sc7180-pdc", "qcom,pdc"; > > is the way to go. I wasn't planning on adding a qcom,sc7180-pdc, but instead just use the qcom,pdc one for sc7180. > > Reusing qcom,sdm845-pdc would prevent us from tackling any unforeseen > issues/variations/erratas with one or the other platform in the future. That was the intention of adding qcom,sc7180-pdc in the first place, but Marc Zyngier was not happy with the churn, given there aren't really any variations or erratas that we know of. > > Regards, > Bjorn > >> >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member >> of Code Aurora Forum, hosted by The Linux Foundation -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation