Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes

[Alexandre TORGUE <alexandre.torgue@foss.st.com>]

Hi Krzysztof

On 9/19/22 13:32, Krzysztof Kozlowski wrote:
> On 13/09/2022 09:46, Alexandre Torgue wrote:
>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
>> fix dtb validation.
> 
> Rebase your patch on recent Linux kernel and use get_maintainers.pl.

I did it on 6.0-rc5 but yes I used your kernel.org address instead of 
linaro ones. Sorry.

> 
>>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> index d35dcc4f0242..92582cccbb1b 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> @@ -65,6 +65,10 @@ patternProperties:
>>         '#gpio-cells':
>>           const: 2
>>   
>> +      interrupt-controller: true
>> +      '#interrupt-cells':
>> +        const: 2
>> +
>>         reg:
>>           maxItems: 1
>>         clocks:
>> @@ -80,6 +84,8 @@ patternProperties:
>>           minimum: 1
>>           maximum: 16
>>   
>> +      gpio-line-names: true
> 
> maxItems?

Generic question, Is it mandatory to add maxItems information for all 
entries ?

For sure I'll send a v2 with it.

Alex

> 
> 
> Best regards,
> Krzysztof