From: Arnaud Pouliquen <arnaud.pouliquen@st.com>
To: Fabrice Gasnier <fabrice.gasnier@st.com>,
jic23@kernel.org, robh+dt@kernel.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
benjamin.gaignard@linaro.org, lars@metafoo.de,
alexandre.torgue@st.com, linux-iio@vger.kernel.org,
pmeerw@pmeerw.net, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, mcoquelin.stm32@gmail.com,
knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells
Date: Fri, 23 Feb 2018 14:46:19 +0100 [thread overview]
Message-ID: <c221e43d-c7fb-c33b-6fd1-bbf8aca6fa49@st.com> (raw)
In-Reply-To: <1519384041-23782-1-git-send-email-fabrice.gasnier@st.com>
Hello,
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Regards,
Arnaud
On 02/23/2018 12:07 PM, Fabrice Gasnier wrote:
> io-channel-cells should be <0> since sigma delta modulator exports only
> one channel, as described in ../iio/iio-bindings.txt "IIO providers"
> section. Only the phandle is necessary for IIO consumers in this case.
>
> Fixes: af11143757b7 ("IIO: Add DT bindings for sigma delta adc modulator")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> index e9ebb8a..ba24ca7 100644
> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> @@ -3,11 +3,11 @@ Device-Tree bindings for sigma delta modulator
> Required properties:
> - compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
> as a generic SD modulator if modulator not specified in compatible list.
> -- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers".
> +- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
>
> Example node:
>
> ads1202: adc@0 {
> compatible = "sd-modulator";
> - #io-channel-cells = <1>;
> + #io-channel-cells = <0>;
> };
>
next prev parent reply other threads:[~2018-02-23 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 11:07 [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells Fabrice Gasnier
2018-02-23 13:46 ` Arnaud Pouliquen [this message]
2018-02-24 13:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c221e43d-c7fb-c33b-6fd1-bbf8aca6fa49@st.com \
--to=arnaud.pouliquen@st.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).