From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaud Pouliquen Subject: Re: [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells Date: Fri, 23 Feb 2018 14:46:19 +0100 Message-ID: References: <1519384041-23782-1-git-send-email-fabrice.gasnier@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1519384041-23782-1-git-send-email-fabrice.gasnier@st.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fabrice Gasnier , jic23@kernel.org, robh+dt@kernel.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, benjamin.gaignard@linaro.org, lars@metafoo.de, alexandre.torgue@st.com, linux-iio@vger.kernel.org, pmeerw@pmeerw.net, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mcoquelin.stm32@gmail.com, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hello, Acked-by: Arnaud Pouliquen Regards, Arnaud On 02/23/2018 12:07 PM, Fabrice Gasnier wrote: > io-channel-cells should be <0> since sigma delta modulator exports only > one channel, as described in ../iio/iio-bindings.txt "IIO providers" > section. Only the phandle is necessary for IIO consumers in this case. > > Fixes: af11143757b7 ("IIO: Add DT bindings for sigma delta adc modulator") > > Signed-off-by: Fabrice Gasnier > --- > Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt > index e9ebb8a..ba24ca7 100644 > --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt > +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt > @@ -3,11 +3,11 @@ Device-Tree bindings for sigma delta modulator > Required properties: > - compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use > as a generic SD modulator if modulator not specified in compatible list. > -- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers". > +- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers". > > Example node: > > ads1202: adc@0 { > compatible = "sd-modulator"; > - #io-channel-cells = <1>; > + #io-channel-cells = <0>; > }; >