From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>
Cc: mathieu.poirier@linaro.org, mchehab@kernel.org,
krzysztof.kozlowski+dt@linaro.org, quic_vgarodia@quicinc.com,
konrad.dybcio@linaro.org, agross@kernel.org,
freedreno@lists.freedesktop.org, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, jonathan@marek.ca,
conor+dt@kernel.org, robh+dt@kernel.org, airlied@gmail.com,
linux-mmc@vger.kernel.org, quic_tdas@quicinc.com,
stanimir.k.varbanov@gmail.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, andersson@kernel.org,
mturquette@baylibre.com, linux-remoteproc@vger.kernel.org,
sean@poorly.run, ulf.hansson@linaro.org,
devicetree@vger.kernel.org, vladimir.zapolskiy@linaro.org,
rfoss@kernel.org, mani@kernel.org, linux-media@vger.kernel.org,
sboyd@kernel.org, quic_abhinavk@quicinc.com,
bhupesh.sharma@linaro.org, linux-arm-msm@vger.kernel.org,
marijn.suijten@somainline.org, neil.armstrong@linaro.org,
robdclark@gmail.com
Subject: Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
Date: Thu, 27 Jul 2023 15:24:41 +0300 [thread overview]
Message-ID: <c246ab77-0dcd-e6a1-bbec-0924c0923a75@linaro.org> (raw)
In-Reply-To: <432ab1d3-0f9e-4072-ff4d-6362886584b8@quicinc.com>
On 27/07/2023 15:21, Rohit Agarwal wrote:
>
> On 7/27/2023 5:15 PM, Krzysztof Kozlowski wrote:
>> On 27/07/2023 13:19, Rohit Agarwal wrote:
>>> On 7/27/2023 4:46 PM, Rob Herring wrote:
>>>> On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote:
>>>>> Update the RPMHPD references with new bindings defined in rpmhpd.h
>>>>> for Qualcomm SoCs SM8[2345]50.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> ---
>>>>>
>>>>> Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml |
>>>>> 4 ++--
>>>>>
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml |
>>>>> 4 ++--
>>>>>
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml |
>>>>> 4 ++--
>>>>>
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml |
>>>>> 4 ++--
>>>>>
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml |
>>>>> 4 ++--
>>>>>
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml |
>>>>> 4 ++--
>>>>>
>>>>> Documentation/devicetree/bindings/clock/qcom,videocc.yaml |
>>>>> 4 ++--
>>>>>
>>>>> .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml |
>>>>> 4 ++--
>>>>>
>>>>> .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml |
>>>>> 8 ++++----
>>>>>
>>>>> .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml |
>>>>> 4 ++--
>>>>>
>>>>> .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml |
>>>>> 6 +++---
>>>>>
>>>>> .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml |
>>>>> 4 ++--
>>>>>
>>>>> .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml |
>>>>> 8 ++++----
>>>>>
>>>>> .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml |
>>>>> 4 ++--
>>>>>
>>>>> .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml |
>>>>> 8 ++++----
>>>>>
>>>>> Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml |
>>>>> 4 ++--
>>>>>
>>>>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml |
>>>>> 4 ++--
>>>>>
>>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml |
>>>>> 6 +++---
>>>>> 18 files changed, 44 insertions(+), 44 deletions(-)
>>>>>
>>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>>>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>>>
>>>> yamllint warnings/errors:
>>>>
>>>> dtschema/dtc warnings/errors:
>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory
>>>> 21 | #include <dt-bindings/power/qcom,rpmhpd.h>
>>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> compilation terminated.
>>>> make[2]: *** [scripts/Makefile.lib:419:
>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1
>>>> make[2]: *** Waiting for unfinished jobs....
>>>> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500:
>>>> dt_binding_check] Error 2
>>>> make: *** [Makefile:234: __sub-make] Error 2
>>>>
>>>> doc reference errors (make refcheckdocs):
>>>>
>>>> See
>>>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690448953-23425-1-git-send-email-quic_rohiagar@quicinc.com
>>>>
>>>> The base for the series is generally the latest rc1. A different
>>>> dependency
>>>> should be noted in *this* patch.
>>>>
>>>> If you already ran 'make dt_binding_check' and didn't see the above
>>>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>>>> date:
>>>>
>>>> pip3 install dtschema --upgrade
>>>>
>>>> Please check and re-submit after running the above command yourself.
>>>> Note
>>>> that DT_SCHEMA_FILES can be set to your schema file to speed up
>>>> checking
>>>> your schema. However, it must be unset to test all examples with
>>>> your schema.
>>> This should be ignored as the patch that creates the new header is
>>> already applied.
>>> Please follow this series
>>>
>>> https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohiagar@quicinc.com/
>> Please mention the dependency in patch changelog ---, so it is obvious
>> for people applying it and also for the bot.
> Sure. Will send a cover letter for this patch mentioning the changelogs
> and will
> keep the version as v2 since there no change at all in the patch.
What would be the merge strategy? Even if you split it per subsystem, I
probably can not pick up display parts. Is there an immutable branch
with the new header? Otherwise I can either ack Bjorn picking up this
patch or it will have to wait for the next cycle.
>
> Thanks,
> Rohit.
>> Best regards,
>> Krzysztof
>>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-07-27 12:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 9:09 [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs Rohit Agarwal
2023-07-27 11:16 ` Rob Herring
2023-07-27 11:19 ` Rohit Agarwal
2023-07-27 11:45 ` Krzysztof Kozlowski
2023-07-27 12:21 ` Rohit Agarwal
2023-07-27 12:24 ` Dmitry Baryshkov [this message]
2023-07-27 12:28 ` Rohit Agarwal
2023-07-27 12:27 ` Krzysztof Kozlowski
2023-07-27 12:30 ` Rohit Agarwal
2023-07-27 12:36 ` Rohit Agarwal
-- strict thread matches above, loose matches on Subject: below --
2023-07-27 12:43 Rohit Agarwal
2023-07-27 13:16 ` Rob Herring
2023-07-28 5:08 ` Rohit Agarwal
2023-08-11 17:04 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c246ab77-0dcd-e6a1-bbec-0924c0923a75@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_rohiagar@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=stanimir.k.varbanov@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).