From: "Nuno Sá" <noname.nuno@gmail.com>
To: Angelo Dureghello <adureghello@baylibre.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>, Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dlechner@baylibre.com
Subject: Re: [PATCH v3 01/10] iio: backend: adi-axi-dac: fix wrong register bitfield
Date: Fri, 20 Sep 2024 14:45:42 +0200 [thread overview]
Message-ID: <c247b5dab409475633ea8dac5ad23fb75aecb1ef.camel@gmail.com> (raw)
In-Reply-To: <20240919-wip-bl-ad3552r-axi-v0-iio-testing-v3-1-a17b9b3d05d9@baylibre.com>
On Thu, 2024-09-19 at 11:19 +0200, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
>
> Fix ADI_DAC_R1_MODE of AXI_DAC_REG_CNTRL_2.
>
> Both generic DAC and ad3552r DAC IPs docs are reporting
> bit 5 for it.
>
> https://wiki.analog.com/resources/fpga/docs/axi_dac_ip
> https://analogdevicesinc.github.io/hdl/library/axi_ad3552r/index.html
>
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
Ouch... Missing Fixes tag. With that,
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> drivers/iio/dac/adi-axi-dac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c
> index 0cb00f3bec04..b8b4171b8043 100644
> --- a/drivers/iio/dac/adi-axi-dac.c
> +++ b/drivers/iio/dac/adi-axi-dac.c
> @@ -46,7 +46,7 @@
> #define AXI_DAC_REG_CNTRL_1 0x0044
> #define AXI_DAC_SYNC BIT(0)
> #define AXI_DAC_REG_CNTRL_2 0x0048
> -#define ADI_DAC_R1_MODE BIT(4)
> +#define ADI_DAC_R1_MODE BIT(5)
> #define AXI_DAC_DRP_STATUS 0x0074
> #define AXI_DAC_DRP_LOCKED BIT(17)
> /* DAC Channel controls */
>
next prev parent reply other threads:[~2024-09-20 12:45 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 9:19 [PATCH v3 00/10] iio: add support for the ad3552r AXI DAC IP Angelo Dureghello
2024-09-19 9:19 ` [PATCH v3 01/10] iio: backend: adi-axi-dac: fix wrong register bitfield Angelo Dureghello
2024-09-20 12:45 ` Nuno Sá [this message]
2024-09-29 10:38 ` Jonathan Cameron
2024-09-19 9:19 ` [PATCH v3 02/10] dt-bindings: iio: dac: axi-dac: add ad3552r axi variant Angelo Dureghello
2024-09-20 12:47 ` Nuno Sá
2024-09-22 20:59 ` Krzysztof Kozlowski
2024-09-29 10:46 ` Jonathan Cameron
2024-09-30 12:52 ` Angelo Dureghello
2024-09-30 13:15 ` Nuno Sá
2024-09-30 14:52 ` Jonathan Cameron
2024-09-19 9:19 ` [PATCH v3 03/10] dt-bindings: iio: dac: ad3552r: fix maximum spi speed Angelo Dureghello
2024-09-22 20:59 ` Krzysztof Kozlowski
2024-09-19 9:20 ` [PATCH v3 04/10] dt-bindings: iio: dac: ad3552r: add io-backend support Angelo Dureghello
2024-09-22 21:02 ` Krzysztof Kozlowski
2024-09-23 15:50 ` Angelo Dureghello
2024-09-24 8:02 ` Krzysztof Kozlowski
2024-09-24 12:27 ` Nuno Sá
2024-09-25 7:22 ` Krzysztof Kozlowski
2024-09-25 11:55 ` Nuno Sá
2024-09-28 12:20 ` Krzysztof Kozlowski
2024-09-29 10:59 ` Jonathan Cameron
2024-09-30 7:20 ` Nuno Sá
2024-09-30 7:31 ` Krzysztof Kozlowski
2024-09-30 8:24 ` Nuno Sá
2024-09-30 13:22 ` Angelo Dureghello
2024-09-30 15:09 ` Jonathan Cameron
2024-10-01 8:23 ` Nuno Sá
2024-10-01 18:29 ` Jonathan Cameron
2024-10-02 5:54 ` Krzysztof Kozlowski
2024-10-02 9:00 ` Nuno Sá
2024-09-29 10:51 ` Jonathan Cameron
2024-09-30 14:15 ` Angelo Dureghello
2024-09-30 14:49 ` Jonathan Cameron
2024-09-30 15:08 ` Angelo Dureghello
2024-09-30 19:20 ` David Lechner
2024-10-01 8:09 ` Angelo Dureghello
2024-09-19 9:20 ` [PATCH v3 05/10] iio: backend: extend features Angelo Dureghello
2024-09-20 12:50 ` Nuno Sá
2024-09-24 14:11 ` Angelo Dureghello
2024-09-25 11:59 ` Nuno Sá
2024-10-02 9:14 ` Angelo Dureghello
2024-09-29 11:05 ` Jonathan Cameron
2024-09-30 19:25 ` David Lechner
2024-10-01 8:14 ` Nuno Sá
2024-10-01 8:35 ` Angelo Dureghello
2024-10-01 18:32 ` Jonathan Cameron
2024-09-19 9:20 ` [PATCH v3 06/10] iio: backend: adi-axi-dac: " Angelo Dureghello
2024-09-20 13:10 ` Nuno Sá
2024-09-29 11:28 ` Jonathan Cameron
2024-09-19 9:20 ` [PATCH v3 07/10] iio: dac: ad3552r: changes to use FIELD_PREP Angelo Dureghello
2024-09-19 9:20 ` [PATCH v3 08/10] iio: dac: ad3552r: extract common code (no changes in behavior intended) Angelo Dureghello
2024-09-29 11:57 ` Jonathan Cameron
2024-10-02 15:50 ` Angelo Dureghello
2024-10-04 14:21 ` Jonathan Cameron
2024-09-19 9:20 ` [PATCH v3 09/10] iio: dac: ad3552r: add axi platform driver Angelo Dureghello
2024-09-29 12:17 ` Jonathan Cameron
2024-09-19 9:20 ` [PATCH v3 10/10] iio: backend: adi-axi-dac: add registering of child fdt node Angelo Dureghello
2024-09-29 12:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c247b5dab409475633ea8dac5ad23fb75aecb1ef.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=adureghello@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).