From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D48F6C04A94 for ; Mon, 17 Jul 2023 06:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbjGQGnr (ORCPT ); Mon, 17 Jul 2023 02:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbjGQGnp (ORCPT ); Mon, 17 Jul 2023 02:43:45 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D4A81BC for ; Sun, 16 Jul 2023 23:43:43 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-992acf67388so519981166b.1 for ; Sun, 16 Jul 2023 23:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689576221; x=1692168221; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b9Ume/qTRfngrnyWbD+BRJS3/e2BWmcYqf3mdPXfSMQ=; b=cjZeXkVU6Pk6nF2snpWM2Mj6uikGUWkkeFnF8CZ86VOUjvH2prV0v9Hnd+TbPRR4H0 2iXmJ2dg2PR4uHWEAe8j3TggGHcmd+LWqlF2NYhDxVcQWoilhH8lEMi3UBqvEqx4KErX UkKlxBPeuMwIwoDq0CLSGFm1cejon3fgLl/miymqlGDIcQ8lgOK4hcfsfsas6Yl69hTz ZnQ3ekP/zzWtdWMo2BhdMDervZM+scIP3a568xKL4ogZrpf5Z599ix04F3aqeth6iRId aaQ1DLRAaKqdCbfIVc2yGMc6svibja7UHDX6HQ0+BZOovxTYg7D5Fxnnr2x5T/UId8dA C/jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689576221; x=1692168221; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b9Ume/qTRfngrnyWbD+BRJS3/e2BWmcYqf3mdPXfSMQ=; b=guEMmdM9LJJ5l7cqOLm2R7RwlBoYTUDuSPGE6gKnguc4bce/ICApvhZ6hD+kM8yr/4 EY3nhfB5Plue45WUZkYYuK/UKoRj6QlGCJMJTjRJ1pxDN//ywp8vHmJr4kY66uWnPqmG qcOXs9BAs4Cehdq8sd9dyYHBlM4ctnBFwRbDTw31rfd8PKJbVSLCLtDVbnawebmNAhvV H6QNhpXWrhA+h34RqSFL8i+XXS0/cM5NQTBDP571VGUk5duU/rZIyLCeO1vTKE3PK5p4 IyR392HNNJXKhi4A61tGXStLoKpJ5HBT2uh/NSsjXg5jBAnO32edC35EUnFc1U93EJn9 i9lg== X-Gm-Message-State: ABy/qLZ/tpTL8sa9gK9PBhmyzFabbRQaSrwXxXPe/XbgF0nnCp8opE/v d/16jqcwMlenh2kYWyO74wx9eg== X-Google-Smtp-Source: APBJJlGR/Ol29HxtOvmYMnrVhmgGMv1ul3W+ZJjHfrbgeyHhp5GcsB6SnEqFlu9Iz5t8zfTpaSWIGA== X-Received: by 2002:a17:906:20d6:b0:994:4e9c:30c6 with SMTP id c22-20020a17090620d600b009944e9c30c6mr3619450ejc.57.1689576221485; Sun, 16 Jul 2023 23:43:41 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id d21-20020a170906c21500b0098884f86e41sm8679105ejz.123.2023.07.16.23.43.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 23:43:41 -0700 (PDT) Message-ID: Date: Mon, 17 Jul 2023 08:43:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x Content-Language: en-US To: "Li, Hua Qian" , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "conor+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "robh+dt@kernel.org" Cc: "Su, Bao Cheng" , "kristo@kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "huaqianlee@gmail.com" , "nm@ti.com" , "linux-arm-kernel@lists.infradead.org" , "Kiszka, Jan" , "linux-watchdog@vger.kernel.org" , "vigneshr@ti.com" References: <20230717040723.1306374-1-huaqian.li@siemens.com> <625a92b8-b629-a4ef-6176-635e1b7885db@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/07/2023 08:34, Li, Hua Qian wrote: > On Mon, 2023-07-17 at 08:27 +0200, Krzysztof Kozlowski wrote: >> On 17/07/2023 08:24, Li, Hua Qian wrote: >>> On Mon, 2023-07-17 at 08:16 +0200, Krzysztof Kozlowski wrote: >>>> On 17/07/2023 06:07, huaqian.li@siemens.com wrote: >>>>> From: Li Hua Qian >>>>> >>>>> The watchdog hardware of TI AM65X platform does not support >>>>> WDIOF_CARDRESET feature, add a reserved memory to save the >>>>> watchdog >>>>> reset cause, to know if the board reboot is due to a watchdog >>>>> reset. >>>>> >>>>> Signed-off-by: Li Hua Qian >>>>> --- >>>>> Changes in v4: >>>>> - Fix the coding style. >>>>> - Add usage note for the reserved memory. >>>>> - Link to v3: >>>>>   >>>>> https://lore.kernel.org/linux-watchdog/20230713095127.1230109-1-huaqian.li@siemens.com >>>> >>>> Much more changed. You added example in the bindings which no one >>>> asked >>>> for. Then you added multiple fake review tags to all the patches. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> Hi, >>> >>> Sorry for the wrong statement. I missed some key information and >>> missunderstood `Reviewed-by`, I treated `Reviewed-by` as `Who >>> has reviewed`. >> >> But you don't have even that information who has reviewed! Where do >> you >> see any reviews coming from me for patch #2? Where do you see reviews >> from Rob for patch #3? >> >> Best regards, >> Krzysztof >> > I got these information from my email thread. Anyway I made a stupid > mistake, sorry for wasting your time. > > By the way, when you wrote the following in '[PATCH v3 1/3] dt- > bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET', you > were kind of saying that it looks good to you if I remove the extra > empty line, right? > > In any case: > Reviewed-by: Krzysztof Kozlowski This was patch 1. But you added my review to patch 2 also. Why then not adding to patch 3? What logic is driving this? Best regards, Krzysztof