From: Krzysztof Kozlowski <krzk@kernel.org>
To: wjjsn <wjjsn@qq.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
chenhuacai@kernel.org
Cc: kernel@xen0n.name, devicetree@vger.kernel.org,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
wjjsn <2858482031@qq.com>
Subject: Re: [PATCH v5 2/2] loongarch: boot: dts: Add Loongson-2K0300 support
Date: Sun, 22 Mar 2026 09:53:01 +0100 [thread overview]
Message-ID: <c26f35ce-6d15-4f6d-8ac9-e52a0aa0b44f@kernel.org> (raw)
In-Reply-To: <tencent_6C692FE25219A76D5F73D250006D543B6709@qq.com>
On 22/03/2026 08:13, wjjsn wrote:
> From: wjjsn <2858482031@qq.com>
>
> Signed-off-by: wjjsn <2858482031@qq.com>
I don't understand what is happening here. You sent bunch of unthreaded
patches, empty commit msgs, some are being duplicated (seems at least?)...
> ---
> arch/loongarch/boot/dts/Makefile | 2 +-
> .../boot/dts/loongson-2k0300-ref.dts | 34 +++++++
> arch/loongarch/boot/dts/loongson-2k0300.dtsi | 94 +++++++++++++++++++
> 3 files changed, 129 insertions(+), 1 deletion(-)
> create mode 100644 arch/loongarch/boot/dts/loongson-2k0300-ref.dts
> create mode 100644 arch/loongarch/boot/dts/loongson-2k0300.dtsi
>
> diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile
> index 15d5e14fe418..4a096608cfad 100644
> --- a/arch/loongarch/boot/dts/Makefile
> +++ b/arch/loongarch/boot/dts/Makefile
> @@ -1,3 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -dtb-y = loongson-2k0500-ref.dtb loongson-2k1000-ref.dtb loongson-2k2000-ref.dtb
> +dtb-y = loongson-2k0300-ref.dtb loongson-2k0500-ref.dtb loongson-2k1000-ref.dtb loongson-2k2000-ref.dtb
> diff --git a/arch/loongarch/boot/dts/loongson-2k0300-ref.dts b/arch/loongarch/boot/dts/loongson-2k0300-ref.dts
> new file mode 100644
> index 000000000000..f85d2caa94b0
> --- /dev/null
> +++ b/arch/loongarch/boot/dts/loongson-2k0300-ref.dts
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2023 Loongson Technology Corporation Limited
> + */
> +
> +/dts-v1/;
> +
> +#include "loongson-2k0300.dtsi"
> +
> +/ {
> + compatible = "loongson,ls2k0300-ref", "loongson,ls2k0300";
> + model = "Loongson-2K0300 Reference Board";
> +
> + aliases {
> + serial0 = &uart0;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + memory@200000 {
> + device_type = "memory";
> + reg = <0x0 0x00200000 0x0 0x0ee00000>,
> + <0x0 0x90000000 0x0 0x10000000>;
> + };
> +
> +};
> +
> +
This code has many white space issues. Please clean it up everywhere.
> +&uart0 {
> + status = "okay";
> +};
> +
And here
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-22 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260322071316.1537953-1-wjjsn@qq.com>
2026-03-22 7:13 ` [PATCH v5 1/2] dt-bindings: loongarch: Add Loongson-2K0300 wjjsn
2026-03-22 7:13 ` [PATCH v5 2/2] loongarch: boot: dts: Add Loongson-2K0300 support wjjsn
2026-03-22 8:53 ` Krzysztof Kozlowski [this message]
2026-03-22 9:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c26f35ce-6d15-4f6d-8ac9-e52a0aa0b44f@kernel.org \
--to=krzk@kernel.org \
--cc=2858482031@qq.com \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=robh@kernel.org \
--cc=wjjsn@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox