From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: usb: Convert fsl-usb to yaml
Date: Thu, 27 Jun 2024 09:00:03 +0200 [thread overview]
Message-ID: <c26f76eb-5f1f-40e2-af5e-13029ee32a95@kernel.org> (raw)
In-Reply-To: <Znwt+vZZ0chXQp+Q@lizhi-Precision-Tower-5810>
On 26/06/2024 17:04, Frank Li wrote:
> On Wed, Jun 26, 2024 at 11:26:18AM +0200, Krzysztof Kozlowski wrote:
>> On 25/06/2024 04:25, Frank Li wrote:
>>> Convert fsl-usb binding doc to yaml format.
>>>
>>> Additional change:
>>
>>
>>> - usb@4000 {
>>> - compatible = "fsl,mpc5121-usb2-dr";
>>> - reg = <0x4000 0x1000>;
>>> - #address-cells = <1>;
>>> - #size-cells = <0>;
>>> - interrupt-parent = < &ipic >;
>>> - interrupts = <44 0x8>;
>>> - dr_mode = "otg";
>>> - phy_type = "utmi_wide";
>>> - fsl,invert-drvvbus;
>>> - fsl,invert-pwr-fault;
>>> - };
>>> diff --git a/Documentation/devicetree/bindings/usb/fsl-usb.yaml b/Documentation/devicetree/bindings/usb/fsl-usb.yaml
>>> new file mode 100644
>>> index 0000000000000..8b5724e213f09
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/fsl-usb.yaml
>>
>> fsl,usb.yaml
>> or: fsl,usb2.yaml
>>
>>> +
>>> +maintainers:
>>> + - Frank Li <Frank.Li@nxp.com>
>>> +
>>> +description: |
>>
>> Do not need '|' unless you need to preserve formatting.
>
> dt_binding_check report error without '|'
> fsl,usb2.yaml:15:11: [error] syntax error: mapping values are not allowed here (syntax)
>
> "Practice:" impact yaml parse.
Ah, indeed.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-27 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 2:25 [PATCH 1/1] dt-bindings: usb: Convert fsl-usb to yaml Frank Li
2024-06-26 9:26 ` Krzysztof Kozlowski
2024-06-26 15:04 ` Frank Li
2024-06-27 7:00 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c26f76eb-5f1f-40e2-af5e-13029ee32a95@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).