From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0216267B1F for ; Thu, 13 Mar 2025 13:06:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741871188; cv=none; b=iLPrzXXhApHYF9P/wovLtoIj0FPEvK6BM5Ksg9+iEXf5PRRB3iMG6PD/2al0ntOMziFsSCotq/WMgrG1VeHvpj3Ry6I7mXXqUCsaxYQqZugK+SO8Nn7PpuikB1O2Z2ZwojWltLKw3kD+w65aPRe/WkYfhR4FDoF6dsTPDPN30Tc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741871188; c=relaxed/simple; bh=6zXjh1h2grdtWlh32q/xSiG2WPMUoNGZUBzmL6hMRUM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=CH9NkgUgr9T3nsQ8mePJCYTtUFY06OgifyTjsAwqcwpa+9qmjT/lTiiVGI7BptgnVc+D/V/vIIA+L911lpvioliSoDpBQ1TFQVeH2MSPEwL3nKKiO/lLC8+F1eML5R8VkrxkbEJwftIkMvYDUCusqANLpcx9r4p2J1N4gDvOo84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tsiGM-0001HM-Ri; Thu, 13 Mar 2025 14:06:14 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tsiGL-005XTg-2Z; Thu, 13 Mar 2025 14:06:13 +0100 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1tsiGL-0009sV-2J; Thu, 13 Mar 2025 14:06:13 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] reset: Add USB2PHY control driver for Renesas RZ/V2H(P) From: Philipp Zabel To: Fabrizio Castro , Prabhakar , Geert Uytterhoeven , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Biju Das , Prabhakar Mahadev Lad , Chris Paterson Date: Thu, 13 Mar 2025 14:06:13 +0100 In-Reply-To: References: <20250305123915.341589-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20250305123915.341589-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <30b6841b3ce199488698ab272f103a0364adb000.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Hi Fabrizio, On Do, 2025-03-13 at 10:14 +0000, Fabrizio Castro wrote: > Hi Philipp, >=20 > Thanks for your feedback! >=20 > > From: Philipp Zabel > > Sent: 13 March 2025 08:37 > > Subject: Re: [PATCH v2 2/2] reset: Add USB2PHY control driver for Renes= as RZ/V2H(P) > >=20 > > On Mi, 2025-03-05 at 12:39 +0000, Prabhakar wrote: > > > From: Lad Prabhakar > > >=20 > > > Add support for the USB2PHY control driver on the Renesas RZ/V2H(P) S= oC. > > > Make the driver handle reset and power-down operations for the USB2PH= Y. > > >=20 > > > Pass OF data to support future SoCs with similar USB2PHY hardware but > > > different register configurations. Define device-specific initializat= ion > > > values and control register settings in OF data to ensure flexibility > > > for upcoming SoCs. > > >=20 > > > Signed-off-by: Lad Prabhakar > > > --- > > > drivers/reset/Kconfig | 7 + > > > drivers/reset/Makefile | 1 + > > > drivers/reset/reset-rzv2h-usb2phy-ctrl.c | 223 +++++++++++++++++++++= ++ > > > 3 files changed, 231 insertions(+) > > > create mode 100644 drivers/reset/reset-rzv2h-usb2phy-ctrl.c > > >=20 [...] > > > diff --git a/drivers/reset/reset-rzv2h-usb2phy-ctrl.c b/drivers/reset= /reset-rzv2h-usb2phy-ctrl.c > > > new file mode 100644 > > > index 000000000000..a6daeaf37e1c > > > --- /dev/null > > > +++ b/drivers/reset/reset-rzv2h-usb2phy-ctrl.c > > > @@ -0,0 +1,223 @@ [...] > > > +static const struct rzv2h_usb2phy_regval rzv2h_init_vals[] =3D { > > > + { .reg =3D 0xc10, .val =3D 0x67c }, > > > + { .reg =3D 0xc14, .val =3D 0x1f }, > > > + { .reg =3D 0x600, .val =3D 0x909 }, > >=20 > > What are these registers and what are those values doing? >=20 > Unfortunately, there are some licensing restrictions on this IP, this is > the best that we can do, as per the license agreement. How am I expected to review this? For now, I'll assume that these registers are not related to reset functionality at all, and that this driver should be a phy controller driver instead of a reset controller driver. Can you convince me otherwise without breaking license agreements? regards Philipp