From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Josua Mayer <josua@solid-run.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] arm64: dts: add description for solidrun am642 som and evaluation board
Date: Thu, 4 Jan 2024 12:22:19 +0100 [thread overview]
Message-ID: <c28ab577-35ad-45f6-8be4-08b441cdb50b@linaro.org> (raw)
In-Reply-To: <0402b960-6daa-446b-8503-d991deac5532@solid-run.com>
On 04/01/2024 12:01, Josua Mayer wrote:
>>> +
>>> + leds {
>>> + compatible = "gpio-leds";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&leds_pins_default>;
>>> + status = "okay";
>> Where was it disabled?
> Nowhere. Better to omit status on new nodes added by new dts file?
Yes, you should not have any redundant status properties. okay is by
default.
>>> +
>>> + /* D24 */
>>> + led1: led-1 {
>>> + label = "led1:green";
>> Use function
> This board has no default function defined by labels or enclosure.
> Not sure what to pick for "function" property. Can I omit it and set only color?
>
> If so - should I drop label completely - or keep the "led1" part?
Then keep label.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-04 11:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 11:27 [PATCH 0/5] arm64: dts: add description for solidrun am642 som and hummingboard evb Josua Mayer
2024-01-03 11:27 ` [PATCH 1/5] dt-bindings: arm: ti: Add bindings for SolidRun AM642 HummingBoard-T Josua Mayer
2024-01-04 7:50 ` Krzysztof Kozlowski
2024-01-03 11:27 ` [PATCH 2/5] arm64: dts: add description for solidrun am642 som and evaluation board Josua Mayer
2024-01-04 7:54 ` Krzysztof Kozlowski
2024-01-04 11:01 ` Josua Mayer
2024-01-04 11:22 ` Krzysztof Kozlowski [this message]
2024-01-04 11:25 ` Josua Mayer
2024-01-03 11:27 ` [PATCH 3/5] arm64: dts: ti: hummingboard-t: add descriptions for m.2 pci-e and usb-3 Josua Mayer
2024-01-03 11:27 ` [PATCH 4/5] arm64: dts: ti: k3-am64-main: Add ICSSG IEP nodes Josua Mayer
2024-01-03 11:27 ` [PATCH 5/5] arm64: dts: ti: am642-sr-som: enable iep for pru ethernet ports Josua Mayer
2024-01-04 7:55 ` Krzysztof Kozlowski
2024-01-04 9:57 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c28ab577-35ad-45f6-8be4-08b441cdb50b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=josua@solid-run.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).