From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE7F42F4A0C for ; Mon, 29 Jun 2026 05:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711363; cv=none; b=JAta7m/vcwqJ5wFze99AT79q63PzOLiWPVgUAEBeKskpXAobqY+wsVexO91SmbfWvDefIgtt2xqj1gxKRH4zg5eFJ7v44bBQL9MIiFqZRJ4TG0rgf3V3njRkzoGVjlM62QXDknNcDYg8gmZaI6T8ivGvO9RQ2BJaCuHYWmxrOVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711363; c=relaxed/simple; bh=tv1mZI4KEvM2V8q6plCcGch8qL3k2C6y7tULqw8J7NA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QpD4Y6nEJD0zEUudLfPLDrqaR+PPRqEfOuQ71qkgUtjS+yKYymH+xMJBF0xr0QD1QcqoGIURT75/XKROhyzmVOB1sSKUcxnM4AxG46jMcP0PhB+qgN8Haw8FE1SkcJMNsjMaSJ7+lIsSa6Qf+MyDMgyOjn/YkuCZrbZhPSzfAcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Kms/lHB3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dHIzXJnm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Kms/lHB3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dHIzXJnm" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T4NHkG1737487 for ; Mon, 29 Jun 2026 05:36:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2Yi4ev90l3hg9+EhL4WZIfvzByHsix7quj5Oa7F0Z58=; b=Kms/lHB3pUrNLcfM J2ms+8hjVuXdP9L6K9Srf2a2odC1kMIPxInyu99OMG7MDzvq6AWT/AJygP7xcjio 4mToFebGXAv2ls1ea4wB2FCUgQDaQAjb+V4EfMF4KYih/MmzpNziyTqByALnW7d2 dRaFomFa65n6U2UadSc791Gd+AL2SzaAoMe8WWIDAkCKQdtPTi027d5cOIX52bRF PJPZ9S9HRgJPHqyWWkB0td4U1uLZUEYPKsT+x3BjZu9ec9d9vxcR5+NfkgD8zGH7 SQSXfUQmpvYoFGKPkbTD8CAPTAYpuHID2tUiQQ0RcSRVzSxPkz2+kYe0hsQ5aALF 4QDoqA== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f279cmjqr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 05:36:01 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-30bcb065bfdso3420024eec.0 for ; Sun, 28 Jun 2026 22:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782711361; x=1783316161; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2Yi4ev90l3hg9+EhL4WZIfvzByHsix7quj5Oa7F0Z58=; b=dHIzXJnmgyXkOt6QUtKUV/E5ZZLsV9AvUVWNQrxYCmZ/Z0rni+vRuXgGpSBI+yn6fA XaIg3mu1xncognJsVoiwxMVrBJ89K4ktlz1qtlG8qG+xGU49usifaCHruMw3u1d8Okmb dLg1uTe0NHIcVw/j5WDRQEtiKAfzgpYkv5HOUlorKMbbjagnfFmYlrpa3JbEt1dzcmPM iSK04/oGgvmviL7H5eey9xc391vK2xERZ0Fw2Bg+TW68p1+HVMUOXy4ZoxEaGROgOEkw UBsGLlbRRXxOCNSHd4Wrclf9tD35o9oH5A3i3uH+QoiM6/GJ+2y5OZ4vRcas+6upwG9S T3hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782711361; x=1783316161; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Yi4ev90l3hg9+EhL4WZIfvzByHsix7quj5Oa7F0Z58=; b=f2Pk2xdZ5+aOCbc036SA13yg6ZJ7YufjVt0KYh8vA3RGlfDBrqEcqPXcA0nIR534ld SGsCoNmXrKX2ZWFaAespymhoOtcRCoBI9ATRO4H8r6EQ/MQBKzpS8TFzUM1TZA0zQgXF vtusKKJBjqMbN43bEh9jin6AXAL5UV+dAgyIvQ32St1Ns8PmEMIGX0yMzaSlBkjFDjrr oXtRFJmKvVQEA5a1QGVeaks33Ba+XrbS4JulGO5nT89OSDlqqb/NQgbcxZQ1a0yJa80+ YI8XqM5+no7nrVDPMPCzBihL2LAcNLFA49G00w//AbKBHIQcws3uDocBuVwF+Moiixq1 bmuw== X-Forwarded-Encrypted: i=1; AHgh+RrTQo8qVs/hWrGMNa23w34DLfw6+Cat38f8Tp1z9py2plyjBZUUiAU+ueSCl49049QIwhh14qIPZ/Hl@vger.kernel.org X-Gm-Message-State: AOJu0YzXrzPOCqZxVMIx/32x1SO8Vea+GQFy2GroWeUL+b1mq/IDRTV4 e3pa//+jmUKtYYiyRdb0HrSTkkKYFzJZcxSYai1KK8uI2CvfsvGsAZ4RW7e3mldlTiTQZQ2xAEA dSrdDIoLVdb86NPVrwo7Xmt14PaefixkfViqeecydWJXa367ORLnQDHRIe8fdVDHr X-Gm-Gg: AfdE7cnyXnLOcKs4TASYDVoJZDY0UYH4Yurdlax4R9gutimjWcsIMMmL5xI7Mx4aD/o KDWAHCR8kDIC5hNoxtr/AAb4AN7DB7/pvCF/wI1lWwtVRbnzQ2Hti5DvPWcfMjsE8DPTwjiHLV0 y4DZrwj7mJoPJ3Qs4laFfz+RoIsXWkJKDLX3wABt3i+fjosfYhWkZAouRKLwk4Yc2yeth3oSOeQ nvgTf881nuFLqm8D96xt+NNDWBK2BmjMEEDOPBZSxyf0ps6CzcQSzEg7JL9egZAibt/y0fdrPb1 86MyoOvc0mkoH1Hs62z/TPkcMjsitZnIwu8scsJfu+DxnzCXmBycy8ncVPO82nI2uVDqAT/FCyr jwIOgdsI1oP1ihFTBniwD1CJ3G81yTAunQKG2XYy6lGrv X-Received: by 2002:a05:693c:3b05:b0:30c:ab4d:da49 with SMTP id 5a478bee46e88-30cab4ddc47mr8830425eec.45.1782711361349; Sun, 28 Jun 2026 22:36:01 -0700 (PDT) X-Received: by 2002:a05:693c:3b05:b0:30c:ab4d:da49 with SMTP id 5a478bee46e88-30cab4ddc47mr8830401eec.45.1782711360877; Sun, 28 Jun 2026 22:36:00 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ca5f15024sm32011581eec.17.2026.06.28.22.35.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jun 2026 22:36:00 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 11:05:55 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] spi: qcom-geni: Add property to force GSI mode To: Dmitry Baryshkov , Pengyu Luo Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260614083424.464132-1-mitltlatltl@gmail.com> <20260614083424.464132-2-mitltlatltl@gmail.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=evzvCIpX c=1 sm=1 tr=0 ts=6a420442 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=pGLkceISAAAA:8 a=thXrHHpa5qkMojcJ7kgA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA0NSBTYWx0ZWRfX/Sw4SL9t8+CY AqURCHu65aAIOmMxo+YIbjtKu0FdBaxES2S1YwQH6gF8l5jSKnLXH3jIKfsiqnWe/U2yk4uWwJ3 NLxVbtz1ohXHwXAhSO9afKLft/AFQEk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA0NSBTYWx0ZWRfX4PwseT3kuCZN psfjdAQ534NtFelkdCkNm8lnwyBqqIu6iKjVQywZxWuZez56Hcg00iHqnE8IJA73LddZZVHQn+d vfBtcgm3p0qZXIpRkrWUFVUs0JmL4Z5lgeqeegnA0z2ZU6FqRfm53N9scOvyd0+Va1u4XCgVLq2 EYWZsxT59K2TLVy9JezZkwaYChUMrgntF6sVxcdfBg1wQ5ZmEdJGOeqVHnf1VEDtvXgy6dLmAQf dKdSMUBy6TTJo6VB7ScukiIOqOLOaLzrK6rR5H/QSarfFxfjg+A8p7Aw7RToKTz+KQWCZv8ZeIy zzRb/wQSF6Ud/2Vh4mXztnIcVrdaDwf7SFapjIRanO4WbpXr1I1e/IDfCE6iGpT1aZ1s0OgMHlU 4bKguwgZKOIxCCHjgI9XA1YVQ2Wm7RVGtaTMVj+TNtsI7wVfcfTKgNlZlJ+FWgyFQ1nBe5Iqjc0 bqbW3L4+Fm7/xtLJSyQ== X-Proofpoint-GUID: xStoZvjjvP8Qzg1BNlbXgeQfjdd7QmbE X-Proofpoint-ORIG-GUID: xStoZvjjvP8Qzg1BNlbXgeQfjdd7QmbE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290045 Hi Pengyu, On 6/15/2026 2:48 AM, Dmitry Baryshkov wrote: > On Sun, Jun 14, 2026 at 04:34:24PM +0800, Pengyu Luo wrote: >> Some devices (such as gaokun3) do not disable FIFO mode, causing the >> driver to fallback to FIFO mode by default. However, these platforms >> also support GSI mode, which is highly preferred for certain >> peripherals like SPI touchscreens to improve performance. >> >> Introduce the "qcom,force-gsi-mode" device property to hint and force >> the controller into GSI mode during initialization. Why to force ? You can directly configure in GSI mode. Note there are some configuration done prior to Linux bootup too. > > Ideally, this should be decided by the SPI controller based on the > requirements. Another option would be to prefer GSI for all transfers if > it is available, ignoring the FIFO even if it is not disabled. > Yes, it should be decided in advance and configured accordingly for GSI vs non GSI mode. Because there would be limited set of GSI pipes, which will actually make must have GSI mode device run with FIFO mode. Why don't you decide prior and configure for GSI mode ? We don't need to change the current logic of deciding FIFO vs GSI. >> >> Signed-off-by: Pengyu Luo >> --- >> drivers/spi/spi-geni-qcom.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >