From: Krzysztof Kozlowski <krzk@kernel.org>
To: Depeng Shao <quic_depengs@quicinc.com>,
andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, bryan.odonoghue@linaro.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com,
Yongsheng Li <quic_yon@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: camss: Add CAMSS block definition
Date: Wed, 7 Aug 2024 14:43:09 +0200 [thread overview]
Message-ID: <c2a3e578-b098-450f-96f6-a3ae321f2b4c@kernel.org> (raw)
In-Reply-To: <1c0ff0fa-73d3-400f-a58d-15fb9b0574d1@kernel.org>
On 07/08/2024 14:39, Krzysztof Kozlowski wrote:
> On 07/08/2024 14:33, Depeng Shao wrote:
>> Add CAMSS block definition for sm8550.
>>
>> This drop contains definitions for the following components on sm8550:
>
> 1. Subject: there is no prefix camss. There is no such file, directory
> or module.
>
> 2. You already sent this, so this should be v2 or v3 or vX. Provide
> changelog under ---.
>
> If there is going to be resend, please fix above.
>
> 3. If this was tested on aim300, I am surprised this being not enabled
> on aim300.
One more thing, bindings were not accepted, thus this patch should not
go in. There were no new bindings, so I assume patchset is using
rejected ones.
It's fine to send it to get some comments, although would be nice to
mention to maintainer that this cannot be picked up as is. :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-07 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 12:33 [PATCH] arm64: dts: qcom: sm8550: camss: Add CAMSS block definition Depeng Shao
2024-08-07 12:39 ` Krzysztof Kozlowski
2024-08-07 12:43 ` Krzysztof Kozlowski [this message]
2024-08-07 12:53 ` Depeng Shao
2024-08-07 14:17 ` Bryan O'Donoghue
2024-08-07 14:51 ` Krzysztof Kozlowski
2024-08-07 14:58 ` Bryan O'Donoghue
2024-08-07 15:30 ` Depeng Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2a3e578-b098-450f-96f6-a3ae321f2b4c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_depengs@quicinc.com \
--cc=quic_yon@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox