From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E67C41513 for ; Fri, 4 Aug 2023 09:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbjHDJpp (ORCPT ); Fri, 4 Aug 2023 05:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231184AbjHDJpj (ORCPT ); Fri, 4 Aug 2023 05:45:39 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 742BC49EF for ; Fri, 4 Aug 2023 02:45:36 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-522462d8416so2378355a12.1 for ; Fri, 04 Aug 2023 02:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691142335; x=1691747135; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1xPeMw/tdJ7IioEcDvwAyboMLZ4pz6UEfuXX/4uGyxA=; b=FLyAljQ1t8b3Xk/pCIKYZrMFdYexo+hFibSNEUp2p3wd64yBa2ddbVuCdDrlswKKlx +tSS4CUQ1j8xWfs/JLtTG0hZmgDZOoJcRz/AvsNvA8uA4o7Ubo9dEDD5yrYtIOn20Qj0 gbelwu6DcDfbQRUyKbYb6Iio0eb2WVn4o0WSswkPqcnGMmYZumCBnFZj+cAP+Trxdjpf We1i0/GrNkkIfZmIt1B6hrEr0Z+Fl/QiC2l9ZxPJQVc/oYLW6VQF+ZKYZEV2nKnq4T2k QvdENM2dG5mzNO61iE2XdVwJY950YBmDWnP5uB8XQS/mdCP38qao1kbUIk6TXDAXvY8e T1PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691142335; x=1691747135; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1xPeMw/tdJ7IioEcDvwAyboMLZ4pz6UEfuXX/4uGyxA=; b=h70e+2Zs2pU0iNnRaMEHw2Nke0lJCLvMflC0E9OSjhp7q54WR1o/THPw7Y/6NquUyl YEuJcdqaZIhrImPLzUyYqvjLVKiEJ1Csr9Ixaga8gP9btnY5pCKNgECdUQJpfgK8Cbl3 45mDlPa5YeEgME7gvEBixfT1g36SdrTk3r4gPTPNRkrSXsWQyCWsAI3jKIayj6ev16t1 /VVAJHIXIo5HShNIrUW195TvY6ovglcihyknl+LXPffg1973Vk7mLQA31Xt2NIQtJZ68 XGur/aY2UGvW6x03BhVSFBpZoF/hkFbRYydp1Ii2tvByz4kdOB25JQDFBvRJB50JdbAG eZ6Q== X-Gm-Message-State: AOJu0YwwsnOJX0YEbEkshJ0a6ZF56bOd7VAbQxQSzwX7vI10pBFy842L p8LoyXIcTsCAtowjYRk6pc98bg== X-Google-Smtp-Source: AGHT+IEKy6dK//8+SePubKh4DJRoYWXex01cl/WJEu49hdwZPoBKQhqGx2/J5yCGkCRtvETRm0rtUw== X-Received: by 2002:aa7:c783:0:b0:522:bae5:282a with SMTP id n3-20020aa7c783000000b00522bae5282amr1270942eds.1.1691142334837; Fri, 04 Aug 2023 02:45:34 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.245]) by smtp.gmail.com with ESMTPSA id bc5-20020a056402204500b005230f06de15sm1016539edb.78.2023.08.04.02.45.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Aug 2023 02:45:34 -0700 (PDT) Message-ID: Date: Fri, 4 Aug 2023 11:45:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 6/6] ASoC: dt-bindings: mediatek,mt7986-afe: add audio afe document Content-Language: en-US To: =?UTF-8?B?TWFzbyBIdWFuZyAo6buD5Yqg56u5KQ==?= , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "chenxiangrui@huaqin.corp-partner.google.com" , =?UTF-8?B?VHJldm9yIFd1ICjlkLPmlofoia8p?= , "devicetree@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "broonie@kernel.org" , =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsik=?= , "conor+dt@kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "perex@perex.cz" , "arnd@arndb.de" , "angelogioacchino.delregno@collabora.com" , "alsa-devel@alsa-project.org" References: <20230728090819.18038-1-maso.huang@mediatek.com> <20230728090819.18038-7-maso.huang@mediatek.com> <5d005f518d974b7912c832101b5cfbde77f57270.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <5d005f518d974b7912c832101b5cfbde77f57270.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/08/2023 10:25, Maso Huang (黃加竹) wrote: > On Fri, 2023-07-28 at 14:51 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 28/07/2023 11:08, Maso Huang wrote: >>> Add mt7986 audio afe document. >>> >>> Signed-off-by: Maso Huang >> >> Thank you for your patch. There is something to discuss/improve. >> >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >>> + - clocks >>> + - clock-names >>> + - assigned-clocks >>> + - assigned-clock-parents >> >> You should constrain your clocks per variants. I doubt that they are >> really so flexible/optional on each SoC... or maybe missing clocks >> are >> result of unimplemented parts in the driver? But then this should not >> really affect bindings. Bindings still should require such clocks. >> Your >> DTS can always provide a <0>, if needed. >> >> > > Hi Krzysztof, > > After internal check, assigned-clocks and assigned-clock-parents are > not required on this SoC. > Maybe we can just drop these two options? It's separate issue, but yes - why requiring them? I wrote about missing constraints for your clocks in the bindings. Best regards, Krzysztof