From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CC0C3F6B0 for ; Tue, 9 Aug 2022 05:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235135AbiHIFrH (ORCPT ); Tue, 9 Aug 2022 01:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231970AbiHIFrG (ORCPT ); Tue, 9 Aug 2022 01:47:06 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D70871CB01 for ; Mon, 8 Aug 2022 22:47:04 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id o2so8265537lfb.1 for ; Mon, 08 Aug 2022 22:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5LBQJymvxNHE24FaPTYPnqJCdE1pFFrxPDyluiIfEnc=; b=kBvlTxpCOc5yaYvsppc8dS4mw7EXR/4QpqKBKhq00yO3Jv5hBVhBuwd6ub3f2wxDYk nkAxBhpDh6d0aZl3Iq5V7ZxwsxD3XzbAxz00VeASRTPVjw5CiP0zEAKYuimVwln1UBb3 sA9ytrIe1SxMnvtdI3mrLXE2PMKzH5s/Jo1+zUojl1Sz3ypUMEESTKGQ2lS/8mc7lX4m D7Tn8un3arGcnF2TdIk4EzGBzuAlFY9PL1ssbRjP51oy3ZWU0KFhxnkfUD3yMfr5tZG9 oQhGqI2HTvlFhfuQvbOhad1ourha+qmSa9OrmEJ2FtN1/9qpunXSgjm49s83X6B/ZqnG MqsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5LBQJymvxNHE24FaPTYPnqJCdE1pFFrxPDyluiIfEnc=; b=EgL7xZJ7szQcWBYh4z5PYfMPyRQJJWAEpIYfcrN6jK9YVGseHKHvR7c9UGLXwUv2GH xItuyqhYUjkiyA7XuGYztvrIKxxTIrlUeDiM4YKgq+S0dFBhz7/8ODBuhwbqsJ+2MEl7 GNa9dypsolWb+xLbo5FhfOHCK3In2DeUp80jeX8ttZK+iApi9q7C9MMDkGiMhqXnALsV Itd2NibCBV7Y8L80sCPUrm9ITDp2ooRNMAHpzhrUTkgFrEwN3m6iat7qoz6GEnjaylbJ ILDgKe6hmTGIhipmxXdwP5nBaC3EkPH7HqX6BYoM+OrlqmmRSx+3C2WoqAUqlvWMkZ2o 998w== X-Gm-Message-State: ACgBeo3fyTYqBgQtk+u0jgeKrI2uIUNCMUQiiwYJWusxMUuVoXE8YkXr KUitz0Vx7F1h1d1VTtYmUxnb4w== X-Google-Smtp-Source: AA6agR499O4vzQhRHFVBRwbN0SJDy9NXAQre2YictNprW6je38pUaKfxM07XbZ/bVPFhFXBEHu92hA== X-Received: by 2002:ac2:59c2:0:b0:48b:1827:dd43 with SMTP id x2-20020ac259c2000000b0048b1827dd43mr7951297lfn.132.1660024023224; Mon, 08 Aug 2022 22:47:03 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id z18-20020a2e3512000000b0025e2ff06c19sm1549428ljz.50.2022.08.08.22.47.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 22:47:02 -0700 (PDT) Message-ID: Date: Tue, 9 Aug 2022 08:47:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC PATCH 2/6] dt-bindings: crypto: add binding for eip29t2 public key accelerator (PKA) Content-Language: en-US To: Daniel Parks , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <856cbf3a002b5d400bbbdb7aa914ab5b8681a96e.1659985696.git.danielrparks@ti.com> From: Krzysztof Kozlowski In-Reply-To: <856cbf3a002b5d400bbbdb7aa914ab5b8681a96e.1659985696.git.danielrparks@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/08/2022 22:12, Daniel Parks wrote: > The PKA is a mmio-only asymmetric crypto accelerator available on > certain K3 devices. > > Signed-off-by: Daniel Parks > --- > .../inside-secure,safexcel-eip29t2.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml > new file mode 100644 > index 000000000000..b1e195a108cc > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/inside-secure,safexcel-eip29t2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: K3 SoC SA2UL PKA crypto module If this is the child mentioned in patch #1, then this should be first patch and your next one should reference it. > + > +maintainers: > + - Daniel Parks > + > +description: | > + Asymmetric crypto accelerator > + > +properties: > + compatible: > + const: inside-secure,safexcel-eip29t2 > + > + reg: > + items: > + - description: control registers > + - description: mapped memory > + > + interrupts: > + items: > + - description: PKA interrupt This could be "maxItems:1" because your description actually does not bring anything new, but current choice is also OK. Best regards, Krzysztof