From: Swark Yang <syang@axiado.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-i3c@lists.infradead.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
robh@kernel.org, Frank.Li@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant
Date: Fri, 17 Jul 2026 15:57:48 +0800 [thread overview]
Message-ID: <c2cef6dc-fa0f-4c43-aa97-6c5952c9bc4d@axiado.com> (raw)
In-Reply-To: <20260717040056.6BA971F000E9@smtp.kernel.org>
On 7/17/2026 12:00 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The schema enforces a 3-item compatible string chain that unintentionally forces AX3005 devices to inherit an AX3000-specific driver quirk, contradicting the commit message.
> --
Thanks for the report.
To clarify, the 3-item fallback in the code is intentional and correct.
The AX3005 GPIO block is fully compatible with the AX3000 implementation
and indeed requires the exact same driver quirks (such as the specific
direction mode and output enable handling).
The issue is just a poor description in my commit message. It should
have been worded as follows:
"Add binding for the Axiado AX3005 GPIO controller. The AX3005 GPIO
block is fully compatible with the AX3000 implementation and requires
the same driver quirks. Therefore, it is added with a fallback to the
'axiado,ax3000-gpio' compatible string, which in turn falls back to the
generic 'cdns,gpio-r1p02'."
I will hold off on sending a v4 just for this commit message update to
avoid unnecessary noise on the list. I'll wait for further review
comments on the rest of the series and will include this updated message
if a v4 re-roll is needed.
Best Regards,
Swark
next prev parent reply other threads:[~2026-07-17 7:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 3:51 [PATCH v3 0/8] arm64: Add Axiado AX3005 SoC and EVK support Swark Yang
2026-07-17 3:51 ` [PATCH v3 1/8] dt-bindings: arm: axiado: add AX3005 EVK Swark Yang
2026-07-17 3:51 ` [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant Swark Yang
2026-07-17 4:00 ` sashiko-bot
2026-07-17 7:57 ` Swark Yang [this message]
2026-07-17 8:30 ` Krzysztof Kozlowski
2026-07-17 8:33 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 3/8] dt-bindings: i2c: cdns: add Axiado AX3005 I2C variant Swark Yang
2026-07-17 8:32 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 4/8] dt-bindings: i3c: cdns: add Axiado AX3005 I3C variant Swark Yang
2026-07-17 8:32 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 5/8] dt-bindings: serial: cdns: add Axiado AX3005 UART variant Swark Yang
2026-07-17 8:32 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 6/8] dt-bindings: spi: dw-apb-ssi: add Axiado AX3005 SPI variant Swark Yang
2026-07-17 8:34 ` Krzysztof Kozlowski
2026-07-17 8:35 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 7/8] dt-bindings: usb: generic-xhci: add Axiado AX3005 xHCI variant Swark Yang
2026-07-17 8:37 ` Krzysztof Kozlowski
2026-07-17 3:51 ` [PATCH v3 8/8] arm64: dts: axiado: Add initial support for AX3005 SoC and eval board Swark Yang
2026-07-17 8:58 ` (subset) [PATCH v3 0/8] arm64: Add Axiado AX3005 SoC and EVK support Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2cef6dc-fa0f-4c43-aa97-6c5952c9bc4d@axiado.com \
--to=syang@axiado.com \
--cc=Frank.Li@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox