From: Angus Ainslie <angus@akkea.ca>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>,
robh@kernel.org, krzysztof.kozlowski@linaro.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, kernel@puri.sm, linux-imx@nxp.com,
devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Subject: Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0
Date: Wed, 15 Mar 2023 05:30:34 -0700 [thread overview]
Message-ID: <c2cf4eb5fc984aec8a21adfc440b511e@akkea.ca> (raw)
In-Reply-To: <20230314072832.GC143566@dragon>
Hi Shawn,
On 2023-03-14 00:28, Shawn Guo wrote:
> On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote:
>> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
>>
>> This reduces power consumption in system suspend by about 10%.
>
> Is there any other impact than this nice power gain? Otherwise,
> I would wonder why the quirk was enabled in the first place.
>
This comes from the early days of board bring-up and IIRC it seemed to
stabilize flashing using the mfgtools over USB. Whatever gremlin was in
those early boards is long gone and this is no longer needed.
Cheers
Angus
> Shawn
>
>>
>> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> index 0b4b49fa1392a..f557632f574fa 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> @@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> dr_mode = "otg";
>> - snps,dis_u3_susphy_quirk;
>> usb-role-switch;
>> status = "okay";
>>
>> --
>> 2.30.2
>>
next prev parent reply other threads:[~2023-03-15 12:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 20:45 [PATCH v1 00/14] arm64: dts: imx8mq-librem5: updates and fixes until march 2023 Martin Kepplinger
2023-03-09 20:45 ` [PATCH v1 01/14] arm64: dts: imx8mq-librem5: lower the mipi csi 1 frequencies Martin Kepplinger
2023-03-09 20:45 ` [PATCH v1 02/14] arm64: dts: imx8mq-librem5: describe the clock for the csi sensors Martin Kepplinger
2023-03-09 20:45 ` [PATCH v1 03/14] arm64: dts: imx8mq-librem5: fix audio-1v8 regulator name Martin Kepplinger
2023-03-09 20:45 ` [PATCH v1 04/14] arm64: dts: imx8mq-librem5: Describe MIC_2V4 regulator Martin Kepplinger
2023-03-09 20:45 ` [PATCH v1 05/14] arm64: dts: imx8mq-librem5: add brightness levels to led-backlight Martin Kepplinger
2023-03-09 20:46 ` [PATCH v1 06/14] arm64: dts: imx8mq-librem5: Set charger parameters for each batch Martin Kepplinger
2023-03-09 20:46 ` [PATCH v1 07/14] arm64: dts: imx8mq-librem5: Set the DVS voltages lower Martin Kepplinger
2023-03-09 20:46 ` [PATCH v1 08/14] arm64: dts: imx8mq-librem5: add the magnetometer mount matrix Martin Kepplinger
2023-03-09 20:46 ` [PATCH v1 09/14] arm64: dts: imx8mq-librem5: Bump usdhc2 frequency to 100MHz Martin Kepplinger
2023-03-09 20:46 ` [PATCH v1 10/14] arm64: dts: imx8mq-librem5: Adjust proximity sensor's near levels Martin Kepplinger
2023-03-09 20:46 ` [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0 Martin Kepplinger
2023-03-14 7:28 ` Shawn Guo
2023-03-15 12:30 ` Angus Ainslie [this message]
2023-03-09 20:46 ` [PATCH v1 12/14] arm64: dts: imx8mq-librem5: Bump BUCK1 suspend voltage to 0.81V Martin Kepplinger
2023-03-09 20:46 ` [PATCH v1 13/14] arm64: dts: imx8mq-librem5: Reduce I2C frequency to 384kHz Martin Kepplinger
2023-03-09 20:46 ` [PATCH v1 14/14] arm64: dts: imx8mq-librem5: Add 166MHz to DDRC OPP table Martin Kepplinger
2023-03-27 1:48 ` [PATCH v1 00/14] arm64: dts: imx8mq-librem5: updates and fixes until march 2023 Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2cf4eb5fc984aec8a21adfc440b511e@akkea.ca \
--to=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).