From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA178C43334 for ; Mon, 11 Jul 2022 14:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230459AbiGKOxr (ORCPT ); Mon, 11 Jul 2022 10:53:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231187AbiGKOxq (ORCPT ); Mon, 11 Jul 2022 10:53:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 54BBABCBC for ; Mon, 11 Jul 2022 07:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657551220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WJKzatRpxuBvlw+y/WmRUjNpFDe0w/BjpatBDpchBJM=; b=JfoC/2v0koMztXy7nlpLhI0AoMujYOKff3fWmuX6J8CEZPQS7isOwwXRRP50myoB/RkD3h 7xUr0M+b2kmSQf/fJXBIKsASnXitmIL4pmX0exPXDaVkUG8xgtaV3r2IOQMbUOOpxpvNHU h7/Jq22YZ2jVxii4OLzsFeYkQvax53s= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-iloXWk2zMHuZ17IWWIregg-1; Mon, 11 Jul 2022 10:53:39 -0400 X-MC-Unique: iloXWk2zMHuZ17IWWIregg-1 Received: by mail-wr1-f71.google.com with SMTP id h6-20020adfa4c6000000b0021d6a5ac938so719987wrb.20 for ; Mon, 11 Jul 2022 07:53:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=WJKzatRpxuBvlw+y/WmRUjNpFDe0w/BjpatBDpchBJM=; b=Iopuxquo1bBsdu/cJ/fuSkQK53+7c5It3t+nhH3X8p6qTEoeObSGXU/WOal7t46pBJ ELKmAZlIDlG7KX0qQ14p/vRjBBmKSle18PgEZMxY944zPS9piTiy0svDtd1IX/7Kpz7V tEuscwWoaixMyb0tqwS5kVSF1OC6GeTcYeNp85ZXLA4cuwFzhndAIUUglVHRzzQa+5rk F6v6ENzqUBHVK0U5hDfESZv4nzZnNxSnuRdR5lCDflpwj8TL6HSueZXdY5BQggpaSTSf BIT+LczhlSysKD2Oazt2GHSS+izTRu7tlZUlAr3ja0AHG8GjNiyZ7JQWlNcPTUa9Dhvv V6SA== X-Gm-Message-State: AJIora8BYDSWiqOyiognaXHQz1RZbylGbsRSkX/QL7wnc7bBtzBqZ0Ni +WKkEBnWdvM5INAMqJaLGRKy85z46hOewpbthZwGCyNOLhRwD3nvSaRxpOhHEcm4GOcRIUkaVb8 WsmATNGi+39myXvwceDi43g== X-Received: by 2002:a05:600c:3592:b0:3a1:9e9d:2595 with SMTP id p18-20020a05600c359200b003a19e9d2595mr16789387wmq.76.1657551217928; Mon, 11 Jul 2022 07:53:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uF7fVJz9gV/LGNy5ZuztDsIKohRmcbcs6QZEq6X8YOCi+3alMsLlZbv00GX9vpBHFadMKsmA== X-Received: by 2002:a05:600c:3592:b0:3a1:9e9d:2595 with SMTP id p18-20020a05600c359200b003a19e9d2595mr16789363wmq.76.1657551217690; Mon, 11 Jul 2022 07:53:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:1400:c3:4ae0:6d5c:1ab2? (p200300cbc702140000c34ae06d5c1ab2.dip0.t-ipconnect.de. [2003:cb:c702:1400:c3:4ae0:6d5c:1ab2]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c3b0800b003a2ead2c884sm528930wms.13.2022.07.11.07.53.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 07:53:37 -0700 (PDT) Message-ID: Date: Mon, 11 Jul 2022 16:53:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/4] mm/sparse: skip no-map memblock check when fill_subsection_map Content-Language: en-US To: Li Chen , Catalin Marinas , Will Deacon , Rob Herring , Frank Rowand , Andrew Morton Cc: Li Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org References: <20220711122459.13773-1-me@linux.beauty> <20220711122459.13773-3-me@linux.beauty> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220711122459.13773-3-me@linux.beauty> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11.07.22 14:24, Li Chen wrote: > From: Li Chen > > When mhp use sparse_add_section, don't check no-map region, > so that to allow no-map reserved memory to get struct page > support. > > Signed-off-by: Li Chen > Change-Id: I0d2673cec1b66adf695251037a00c240976b226f > --- > mm/sparse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 120bc8ea5293..a29cd1e7014f 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -690,7 +690,9 @@ static int fill_subsection_map(unsigned long pfn, unsigned long nr_pages) > > if (bitmap_empty(map, SUBSECTIONS_PER_SECTION)) > rc = -EINVAL; > - else if (bitmap_intersects(map, subsection_map, SUBSECTIONS_PER_SECTION)) > + else if (memblock_is_map_memory(PFN_PHYS(pfn)) && > + bitmap_intersects(map, subsection_map, > + SUBSECTIONS_PER_SECTION)) > rc = -EEXIST; > else > bitmap_or(subsection_map, map, subsection_map, I'm not sure I follow completely what you are trying to achieve. But if you have to add memblock hacks into mm/sparse.c you're most probably doing something wrong. Please explain why that change is necessary, and why it is safe. If the subsection map already spans memory (iow, subsection map is set) you intend to add, then something already added memory in that range? -- Thanks, David / dhildenb