From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E68CCA47C for ; Tue, 7 Jun 2022 12:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243558AbiFGMIu (ORCPT ); Tue, 7 Jun 2022 08:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243557AbiFGMIs (ORCPT ); Tue, 7 Jun 2022 08:08:48 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A012380220 for ; Tue, 7 Jun 2022 05:08:47 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id h23so23680456ejj.12 for ; Tue, 07 Jun 2022 05:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=xV+JNWROXIXNNl72An2tMAra5xOJapsLU/5a6Polwlg=; b=p8WSw2UMIhQNr2Fwr8cpY5cZqsab+1E35dtmXpB41xaHUUoak4LJRLYksNib4yNTik t0+d1YA7pOXHFbyDI5/w/PSMRJn2b1otbPqCKptEO6LjOiQYGxLvxohrBSkzvKqKZjzv eXpzqayAHIETEYiDAZVNbAE+SUc8MNrVk6jm5JzjS6ygFRirmZueNBO167lnAvlYQtj1 mcU3zA6ggk0c2VHVTjAy15pCP91j2Shz/q1lvUWmaKKMAwssV8CWTjktGezp/honngST Qj3vhh8HEDRk1Y1SzxPh5IGFbC38EyNYCgnKjMEZW6ycmUN17A0DIAJ+ANpqxUHx4IOk UbEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=xV+JNWROXIXNNl72An2tMAra5xOJapsLU/5a6Polwlg=; b=eTj5VfKaxZEUmJITgmp9DHtOde6ORYnE+r+2F6ck3tm2cU193smdznEkYyS7PaZFiS H47BmcvC427LUH6DIBbqv8pfSzUTB63ZP6md2Wjsjc6UA8sRRr4zmhwesd6n2Xx1w/YS pq6agej3Vj6KsF79tdeA2/UCEA7cXxR5zj2e/UOU8Ny+fEGFt8Tuw/IISgBrlQa5MaJi yhyLT+wyiU9E7PfFwu1rutThb87DsfuR8+2woK/jAzEM2U/TilKtBEdpJfalZ2VgkkhM 58OAxNm9Z3rfz1gUDPCxHXaWjx4he9QRiBHk8YPt8OofW4g6VOVEC5ZARhPCe/gpA2EP KQBg== X-Gm-Message-State: AOAM533KFV8at17FD+Pxvd16LPpDHow/jpHeEOeAwEoaGcBalxkHq6Pm 1nIq68xVHgAD4zoI9dS+Ff2p2Q== X-Google-Smtp-Source: ABdhPJyczAHK7KPQ/MU9ZVoX5hsVjj1U5sR9a+dXDnJEexExXSxpVn7QuiQ2RX1o5bvhSIAmm4Grwg== X-Received: by 2002:a17:907:d29:b0:711:d215:5a5e with SMTP id gn41-20020a1709070d2900b00711d2155a5emr8283950ejc.697.1654603726171; Tue, 07 Jun 2022 05:08:46 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id v4-20020a170906488400b006fea2035036sm7546255ejq.86.2022.06.07.05.08.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 05:08:45 -0700 (PDT) Message-ID: Date: Tue, 7 Jun 2022 14:08:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/7] dt-bindings: display: panel: Add Innolux TD4328 panel bindings Content-Language: en-US To: Teguh Sobirin , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, phone-devel@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/06/2022 01:05, Teguh Sobirin wrote: > Add documentation for "innolux,td4328" panel. > > Signed-off-by: Teguh Sobirin > --- > .../display/panel/innolux,td4328.yaml | 83 +++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100755 Documentation/devicetree/bindings/display/panel/innolux,td4328.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/innolux,td4328.yaml b/Documentation/devicetree/bindings/display/panel/innolux,td4328.yaml > new file mode 100755 > index 000000000000..d4773ade0f13 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/innolux,td4328.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual License please (like checkpatch asks). > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/innolux,td4328.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synaptics TD4328 based DSI display Panels > + > +maintainers: > + - Teguh Sobirin > + > +description: | > + The TD4328 IC from Synaptics is a DSI Panel IC used to drive DSI panels. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: innolux,td4328 Innolux or Synaptics? > + description: This indicates the panel manufacturer of the panel that is > + in turn using the TD4328 panel driver. What does the "panel driver" mean here? > + > + reset-gpios: > + maxItems: 1 > + description: phandle of gpio for reset line - This should be 8mA, gpio > + can be configured using mux, pinctrl, pinctrl-names (active high) s/phandle of gpio// Everywhere. > + > + vddio-supply: > + description: phandle of the regulator that provides the supply voltage > + Power IC supply s/phandle of the regulator// Everywhere. This should be simply: "Power IC supply" > + > + vddpos-supply: > + description: phandle of the positive boost supply regulator "Positive boost supply" > + > + vddneg-supply: > + description: phandle of the negative boost supply regulator "Negative boost supply" > + > + rotation: > + description: Display rotation in degrees counter clockwise (0,90,180,270) No need for description, just true > + > + reg: true maxItems > + port: true > + > +required: > + - compatible > + - reg > + - vddio-supply > + - vddpos-supply > + - vddneg-supply > + - reset-gpios > + - rotation > + - port > + > +unevaluatedProperties: false > + > +examples: > + - |+ Just " - |" > + #include > + > + dsi0 { dsi > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "innolux,td4328"; > + reg = <0>; > + vddio-supply = <&vreg_l14a_1p88>; > + vddpos-supply = <&lab>; > + vddneg-supply = <&ibb>; > + > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > + rotation = <90>; > + > + port { > + panel0_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > + }; > + > +... Best regards, Krzysztof