From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8DA1C77B75 for ; Wed, 17 May 2023 09:22:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbjEQJWt (ORCPT ); Wed, 17 May 2023 05:22:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230123AbjEQJW2 (ORCPT ); Wed, 17 May 2023 05:22:28 -0400 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B59AC4EED; Wed, 17 May 2023 02:22:25 -0700 (PDT) Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34H7JbdB020560; Wed, 17 May 2023 11:21:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=owLPVSO/dm+xJZ7As/5XR7paSy5kCGsKocE9XQSXo+k=; b=L8OLTisy6aKGO9Go67ltvYm2RSTOUE8QvtJ8oS1TGEYOcNoNWbnvA6rNA01WtMMaSJem MxYB3EGHuBP+jDXqnV0mLX05JMZ0oaHiWb78Fwym5YhzBjFnfydpT/8RymAx4ileh6yy QtpxoeSgtkG+oG6rv35C5RhQrCAFUL2G1ALOAKLg7wxxpOM40q3idvE3tDrJ1M4WUX0D lbX/adGbsDmzKTvQ/nDEnwMzPkDmbC+S8VZ4tnxj9NLgKhdeHJgPwrWKUKsC1zm25kZV MXg+dRy9RpTW0e7sp92qxClVVnERTjjgaBUHW/6W3IxlBsh5B63QAkM/P6wcaldwnvI0 Hw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3qmtefh0ba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 11:21:53 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 22DD110002A; Wed, 17 May 2023 11:21:51 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 057CC21F14C; Wed, 17 May 2023 11:21:51 +0200 (CEST) Received: from [10.129.178.187] (10.129.178.187) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 17 May 2023 11:21:50 +0200 Message-ID: Date: Wed, 17 May 2023 11:21:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] ARM: dts: stm32: fix several DT warnings on stm32mp15 To: Alexandre TORGUE , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Marek Vasut CC: Philippe Cornu , Yannick Fertre , , , , , References: <20230516132542.27298-1-raphael.gallais-pou@foss.st.com> <72c49b26-120a-64b1-60cf-bbafb2276660@foss.st.com> Content-Language: en-US From: Raphael Gallais-Pou In-Reply-To: <72c49b26-120a-64b1-60cf-bbafb2276660@foss.st.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.129.178.187] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-17_01,2023-05-16_01,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5/16/23 18:04, Alexandre TORGUE wrote: > Hi Raphael > > On 5/16/23 15:25, Raphael Gallais-Pou wrote: >> Several warnings regarding LTDC and DSI on stm32mp15* device-trees remains. >> >> Those concern: >>    * "#size-cells" and "#address-cells" wrongly used >>    * residual "reg" property appearing on endpoints where it could be >>      avoided >> >> Signed-off-by: Raphael Gallais-Pou >> --- > > Thanks to cleanup the last W=1 issues on stm32 MPU boards. It seems that your > patch introduces YAML validation regression for some boards. Can you check > this point please ? > > stm32mp157a-icore-stm32mp1-ctouch2-of10.dtb: dsi@5a000000: '#address-cells' is > a required property >     From schema: > /local/home/frq08678/STLINUX/kernel/my-kernel/stm32/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml > > stm32mp157a-icore-stm32mp1-edimm2.2.dtb: dsi@5a000000: '#address-cells' is a > required property >     From schema: > /local/home/frq08678/STLINUX/kernel/my-kernel/stm32/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml Hi Alex, This is due to the properties #address-cells and #size-cells being required in the YAML file. I will make a second patch in a serie to order those things out. Thanks, Raphaël > > alex > > >>   arch/arm/boot/dts/stm32mp151.dtsi                         | 5 ----- >>   arch/arm/boot/dts/stm32mp157.dtsi                         | 7 ------- >>   .../boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts  | 6 ++++-- >>   arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts | 6 ++++-- >>   .../dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts | 3 +-- >>   arch/arm/boot/dts/stm32mp157c-dk2.dts                     | 8 ++++++++ >>   arch/arm/boot/dts/stm32mp157c-ev1.dts                     | 8 ++++++-- >>   arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts                 | 3 +-- >>   arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi        | 6 +----- >>   arch/arm/boot/dts/stm32mp15xx-dkx.dtsi                    | 3 +-- >>   10 files changed, 26 insertions(+), 29 deletions(-) >> >> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi >> b/arch/arm/boot/dts/stm32mp151.dtsi >> index 664825418c32..0dc46fd9c269 100644 >> --- a/arch/arm/boot/dts/stm32mp151.dtsi >> +++ b/arch/arm/boot/dts/stm32mp151.dtsi >> @@ -1529,11 +1529,6 @@ ltdc: display-controller@5a001000 { >>               clock-names = "lcd"; >>               resets = <&rcc LTDC_R>; >>               status = "disabled"; >> - >> -            port { >> -                #address-cells = <1>; >> -                #size-cells = <0>; >> -            }; >>           }; >>             iwdg2: watchdog@5a002000 { >> diff --git a/arch/arm/boot/dts/stm32mp157.dtsi >> b/arch/arm/boot/dts/stm32mp157.dtsi >> index 54e73ccea446..5e733cd16ff9 100644 >> --- a/arch/arm/boot/dts/stm32mp157.dtsi >> +++ b/arch/arm/boot/dts/stm32mp157.dtsi >> @@ -24,14 +24,7 @@ dsi: dsi@5a000000 { >>               clock-names = "pclk", "ref", "px_clk"; >>               resets = <&rcc DSI_R>; >>               reset-names = "apb"; >> -            #address-cells = <1>; >> -            #size-cells = <0>; >>               status = "disabled"; >> - >> -            ports { >> -                #address-cells = <1>; >> -                #size-cells = <0>; >> -            }; >>           }; >>       }; >>   }; >> diff --git a/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts >> b/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts >> index 9a2a4bc7d079..4279b26547df 100644 >> --- a/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts >> +++ b/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts >> @@ -49,6 +49,9 @@ &dsi { >>       phy-dsi-supply = <®18>; >>         ports { >> +        #address-cells = <1>; >> +        #size-cells = <0>; >> + >>           port@0 { >>               reg = <0>; >>               dsi_in: endpoint { >> @@ -104,8 +107,7 @@ <dc { >>       status = "okay"; >>         port { >> -        ltdc_ep0_out: endpoint@0 { >> -            reg = <0>; >> +        ltdc_ep0_out: endpoint { >>               remote-endpoint = <&dsi_in>; >>           }; >>       }; >> diff --git a/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts >> b/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts >> index 390ee8c05754..efba54289820 100644 >> --- a/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts >> +++ b/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts >> @@ -49,6 +49,9 @@ &dsi { >>       phy-dsi-supply = <®18>; >>         ports { >> +        #address-cells = <1>; >> +        #size-cells = <0>; >> + >>           port@0 { >>               reg = <0>; >>               dsi_in_ltdc: endpoint { >> @@ -104,8 +107,7 @@ <dc { >>       status = "okay"; >>         port { >> -        ltdc_out_dsi: endpoint@0 { >> -            reg = <0>; >> +        ltdc_out_dsi: endpoint { >>               remote-endpoint = <&dsi_in_ltdc>; >>           }; >>       }; >> diff --git >> a/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts >> b/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts >> index 0d7560ba2950..5116a7785201 100644 >> --- a/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts >> +++ b/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts >> @@ -81,8 +81,7 @@ <dc { >>       status = "okay"; >>         port { >> -        ltdc_ep0_out: endpoint@0 { >> -            reg = <0>; >> +        ltdc_ep0_out: endpoint { >>               remote-endpoint = <&panel_in>; >>           }; >>       }; >> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts >> b/arch/arm/boot/dts/stm32mp157c-dk2.dts >> index ab13e340f4ef..4bef2300ed7c 100644 >> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts >> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts >> @@ -31,10 +31,15 @@ &cryp1 { >>   }; >>     &dsi { >> +    #address-cells = <1>; >> +    #size-cells = <0>; >>       status = "okay"; >>       phy-dsi-supply = <®18>; >>         ports { >> +        #address-cells = <1>; >> +        #size-cells = <0>; >> + >>           port@0 { >>               reg = <0>; >>               dsi_in: endpoint { >> @@ -82,6 +87,9 @@ <dc { >>       status = "okay"; >>         port { >> +        #address-cells = <1>; >> +        #size-cells = <0>; >> + >>           ltdc_ep1_out: endpoint@1 { >>               reg = <1>; >>               remote-endpoint = <&dsi_in>; >> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts >> b/arch/arm/boot/dts/stm32mp157c-ev1.dts >> index ba8e9d9a42fa..961e85b07a5e 100644 >> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts >> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts >> @@ -101,9 +101,14 @@ dcmi_0: endpoint { >>     &dsi { >>       phy-dsi-supply = <®18>; >> +    #address-cells = <1>; >> +    #size-cells = <0>; >>       status = "okay"; >>         ports { >> +        #address-cells = <1>; >> +        #size-cells = <0>; >> + >>           port@0 { >>               reg = <0>; >>               dsi_in: endpoint { >> @@ -239,8 +244,7 @@ <dc { >>       status = "okay"; >>         port { >> -        ltdc_ep0_out: endpoint@0 { >> -            reg = <0>; >> +        ltdc_ep0_out: endpoint { >>               remote-endpoint = <&dsi_in>; >>           }; >>       }; >> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts >> b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts >> index 407ed3952f75..eada9cf257be 100644 >> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts >> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts >> @@ -161,8 +161,7 @@ <dc { >>       status = "okay"; >>         port { >> -        ltdc_ep0_out: endpoint@0 { >> -            reg = <0>; >> +        ltdc_ep0_out: endpoint { >>               remote-endpoint = <&panel_input>; >>           }; >>       }; >> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi >> b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi >> index 50af4a27d6be..a564063b8f5a 100644 >> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi >> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi >> @@ -330,11 +330,7 @@ <dc { >>       status = "okay"; >>         port { >> -        #address-cells = <1>; >> -        #size-cells = <0>; >> - >> -        ltdc_ep0_out: endpoint@0 { >> -            reg = <0>; >> +        ltdc_ep0_out: endpoint { >>               remote-endpoint = <&adv7513_in>; >>           }; >>       }; >> diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >> b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >> index 0f1110e42c93..a6e2e20f12fa 100644 >> --- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >> +++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >> @@ -457,8 +457,7 @@ <dc { >>       status = "okay"; >>         port { >> -        ltdc_ep0_out: endpoint@0 { >> -            reg = <0>; >> +        ltdc_ep0_out: endpoint { >>               remote-endpoint = <&sii9022_in>; >>           }; >>       }; >